[GitHub] [celix] Oipo commented on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
Oipo commented on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623179786 Okay, testing it with clang shows that clang follows the spec more strictly. All c11 atomic functions should only be done on _Atomic specified variables. However, _Atomic is not availa

[GitHub] [celix] Oipo edited a comment on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
Oipo edited a comment on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623172986 So there are two ways to use atomics in C11: 1) ~~use the _Atomic specifier. No atomic functions are possible, but assign/increment/decrement are all usable as normal and

[GitHub] [celix] Oipo commented on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
Oipo commented on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623172986 So there are two ways to use atomics in C11: 1) use the _Atomic specifier. No atomic functions are possible, but assign/increment/decrement are all usable as normal and atomic.

Re: Use master as development branch

2020-05-03 Thread Roy Lenferink
Alexander, Were you able to have a look at the proposed workflow I visualized on the wiki page [1][2]? If so, what did you think of it and does this change your -1 to a +1 ? If not, what else is missing before we can move this forward? [1] https://cwiki.apache.org/confluence/x/MwwRCQ [2] https

[GitHub] [celix] Oipo edited a comment on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
Oipo edited a comment on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623097384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [celix] Oipo commented on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
Oipo commented on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623097384 Sounds good. Re: ATOMIC_VAR_INIT, cppreference notes the following: ```This macro was a part of early draft design for C11 atomic types. It is not needed in C11, and is deprec

Re: Send GitHub notifications to new notifications@ list (instead of dev@)

2020-05-03 Thread Roy Lenferink
Hi Alexander, Thanks for the answer, great input! Answers inline. On 2020/04/29 21:17:01, Alexander Broekhuis wrote: > Not saying that I like all the mails to dev, but those mails do contain the > only discussions we have nowadays (Issues at github and comments on Pull > Requests). > So I also

Re: Questions

2020-05-03 Thread Pepijn Noltes
Hi Brian, On Fri, May 1, 2020 at 5:02 PM Brian Michael wrote: > > Hello, > > I was curious about some of the capabilities of Celix. In particular the RSA > and PubSub implementations. Could you inform me of the following items: > - Is Celix setup to perform PubSub between Java and C/C++? I

[GitHub] [celix] pnoltes commented on pull request #214: Fix data race in get/set bundle state

2020-05-03 Thread GitBox
pnoltes commented on pull request #214: URL: https://github.com/apache/celix/pull/214#issuecomment-623075033 If we introduce atomic, then I prefer that we use the c11 standard stuff for that. This means update the top level cmake lists file to use -std=c11 instead of -std=gnu99 and