Re: [PR] [WIP]Feature/dfi cleanup (celix)

2024-01-23 Thread via GitHub
PengZheng commented on PR #699: URL: https://github.com/apache/celix/pull/699#issuecomment-1905582200 > I agree with both. And making a nullptr possible is good improvement I had not considered. > Concerning JSON, If you treat the descriptor as a low level (JSON) schema, it is also logic

[I] Precise Definitions of DFI Argument Types (celix)

2024-01-23 Thread via GitHub
PengZheng opened a new issue, #723: URL: https://github.com/apache/celix/issues/723 For `am=handle`, it is clear that a handle should be untyped pointer, with descriptor 'P'. For `am=pre`, the Doxygen documentation says that the type should be pre-allocated by the function caller. Let me

Re: [I] Precise Definitions of DFI Argument Types (celix)

2024-01-23 Thread via GitHub
PengZheng commented on issue #723: URL: https://github.com/apache/celix/issues/723#issuecomment-1907419591 > Is text pre-allocatable? I guess not, since the caller can not predict how long a string will be. The current implementation of `jsonRpc_handleReply` is confusing in this rega