[PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
pnoltes opened a new pull request, #734: URL: https://github.com/apache/celix/pull/734 This PR adds support for creating a service tracking in a `celix_bundleContext_useTrackedService(s)*` calls. This is done by calling the use callbacks outside of the (read) lock. The prevent that

Re: [PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
codecov-commenter commented on PR #734: URL: https://github.com/apache/celix/pull/734#issuecomment-1975253780 ## [Codecov](https://app.codecov.io/gh/apache/celix/pull/734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

Re: [PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
PengZheng commented on code in PR #734: URL: https://github.com/apache/celix/pull/734#discussion_r1510524927 ## libs/framework/src/bundle_context.c: ## @@ -839,7 +841,28 @@ static void celix_bundleContext_removeServiceTrackerTracker(void *data) { free(tracker); } -stati

Re: [PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
PengZheng commented on code in PR #734: URL: https://github.com/apache/celix/pull/734#discussion_r1510544621 ## libs/framework/src/bundle_context.c: ## @@ -1058,11 +1082,10 @@ bool celix_bundleContext_useServiceWithId( const char *serviceName, void *callbackHan

Re: [PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
PengZheng commented on code in PR #734: URL: https://github.com/apache/celix/pull/734#discussion_r1510544621 ## libs/framework/src/bundle_context.c: ## @@ -1058,11 +1082,10 @@ bool celix_bundleContext_useServiceWithId( const char *serviceName, void *callbackHan

Re: [PR] Feature/87 create service tracker inside use tracked service call (celix)

2024-03-03 Thread via GitHub
PengZheng commented on code in PR #734: URL: https://github.com/apache/celix/pull/734#discussion_r1510544621 ## libs/framework/src/bundle_context.c: ## @@ -1058,11 +1082,10 @@ bool celix_bundleContext_useServiceWithId( const char *serviceName, void *callbackHan

Re: [PR] Remove deprecated header for public api (celix)

2024-03-03 Thread via GitHub
PengZheng commented on PR #542: URL: https://github.com/apache/celix/pull/542#issuecomment-1975793940 Given that pubsub has already been removed, it this PR already done? @xuzhenbao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G