pnoltes merged pull request #241:
URL: https://github.com/apache/celix/pull/241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abroekhuis commented on a change in pull request #230:
URL: https://github.com/apache/celix/pull/230#discussion_r427600200
##
File path: bundles/pubsub/pubsub_spi/include/pubsub_protocol.h
##
@@ -32,27 +33,29 @@ typedef struct pubsub_protocol_header
pubsub_protocol_header_t;
abroekhuis opened a new pull request #242:
URL: https://github.com/apache/celix/pull/242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/celix/pull/242#issuecomment-631244721
# [Codecov](https://codecov.io/gh/apache/celix/pull/242?src=pr&el=h1) Report
> Merging [#242](https://codecov.io/gh/apache/celix/pull/242?src=pr&el=desc)
into
[m
codecov-commenter commented on pull request #242:
URL: https://github.com/apache/celix/pull/242#issuecomment-631244721
# [Codecov](https://codecov.io/gh/apache/celix/pull/242?src=pr&el=h1) Report
> Merging [#242](https://codecov.io/gh/apache/celix/pull/242?src=pr&el=desc)
into
[master](
abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631248351
@Oipo this still seems to fail on CLang (see nightly builds for Ubuntu
CLang).
This is an automated mess
Oipo commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631287109
It sometimes works: https://github.com/apache/celix/runs/689314715
Sometimes doesn't:
https://github.com/apache/celix/runs/691022810?check_suite_focus=true
abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631293443
> It sometimes works: https://github.com/apache/celix/runs/689314715
> Sometimes doesn't:
https://github.com/apache/celix/runs/691022810?check_suite_focus=true
Nice thos
Oipo commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631315570
If we upload an artifact during an action, we can download it:
https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts#downloading
abroekhuis opened a new pull request #243:
URL: https://github.com/apache/celix/pull/243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
codecov-commenter commented on pull request #243:
URL: https://github.com/apache/celix/pull/243#issuecomment-631368341
# [Codecov](https://codecov.io/gh/apache/celix/pull/243?src=pr&el=h1) Report
> Merging [#243](https://codecov.io/gh/apache/celix/pull/243?src=pr&el=desc)
into
[master](
codecov-commenter edited a comment on pull request #243:
URL: https://github.com/apache/celix/pull/243#issuecomment-631368341
# [Codecov](https://codecov.io/gh/apache/celix/pull/243?src=pr&el=h1) Report
> Merging [#243](https://codecov.io/gh/apache/celix/pull/243?src=pr&el=desc)
into
[m
pnoltes merged pull request #239:
URL: https://github.com/apache/celix/pull/239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes merged pull request #242:
URL: https://github.com/apache/celix/pull/242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes merged pull request #243:
URL: https://github.com/apache/celix/pull/243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes opened a new pull request #244:
URL: https://github.com/apache/celix/pull/244
This is added so that registering / unregistering service can be done
(safely) outside of locks/mutexes.
Note that although this is not part of the OSGi specification, IMO this is
an added benefit
codecov-commenter commented on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[master](
Oipo commented on a change in pull request #230:
URL: https://github.com/apache/celix/pull/230#discussion_r430265487
##
File path: bundles/pubsub/pubsub_spi/include/pubsub_protocol.h
##
@@ -32,27 +33,29 @@ typedef struct pubsub_protocol_header
pubsub_protocol_header_t;
* The
codecov-commenter commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
# [Codecov](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=desc)
into
[master](
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
# [Codecov](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
# [Codecov](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
# [Codecov](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
# [Codecov](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/celix/pull/245?src=pr&el=desc)
into
[m
pnoltes commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-636324099
> Fix some issues,
>
> epoll_wait in pubsub is stuck
is the "stuck" fixed in this or is this still an issue?
--
pnoltes opened a new issue #246:
URL: https://github.com/apache/celix/issues/246
There are multiple copies of the civetweb. If I am correct this is used at
least in the http admin, remote service admin.
Only one copy of the sources should be used and shared in the celix project
as s
Oipo commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-636324797
It has been fixed (I think I forgot to unlock a mutex somewhere before...)
This is an automated message from the Apache
pnoltes commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-636324962
This PR fixes some race conditions in the civetweb sources we are using.
First we have the civetweb sources at multiple location. IMO we should
combine this to a static lib o
pnoltes commented on a change in pull request #230:
URL: https://github.com/apache/celix/pull/230#discussion_r432838035
##
File path: bundles/pubsub/pubsub_spi/include/pubsub_protocol.h
##
@@ -32,27 +33,29 @@ typedef struct pubsub_protocol_header
pubsub_protocol_header_t;
*
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[m
codecov-commenter commented on pull request #230:
URL: https://github.com/apache/celix/pull/230#issuecomment-636326046
# [Codecov](https://codecov.io/gh/apache/celix/pull/230?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@97ff579`). [Click here t
Oipo commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-636335092
I've started a discussion about upstreaming at
[civetweb](https://github.com/civetweb/civetweb/issues/861).
This is an
abroekhuis opened a new pull request #247:
URL: https://github.com/apache/celix/pull/247
…hDebInfo and Release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
codecov-commenter edited a comment on pull request #247:
URL: https://github.com/apache/celix/pull/247#issuecomment-637395417
# [Codecov](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=h1) Report
> Merging [#247](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=desc)
into
[m
codecov-commenter commented on pull request #247:
URL: https://github.com/apache/celix/pull/247#issuecomment-637395417
# [Codecov](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=h1) Report
> Merging [#247](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=desc)
into
[master](
codecov-commenter edited a comment on pull request #247:
URL: https://github.com/apache/celix/pull/247#issuecomment-637395417
# [Codecov](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=h1) Report
> Merging [#247](https://codecov.io/gh/apache/celix/pull/247?src=pr&el=desc)
into
[m
abroekhuis merged pull request #247:
URL: https://github.com/apache/celix/pull/247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #230:
URL: https://github.com/apache/celix/pull/230#issuecomment-636326046
# [Codecov](https://codecov.io/gh/apache/celix/pull/230?src=pr&el=h1) Report
> Merging [#230](https://codecov.io/gh/apache/celix/pull/230?src=pr&el=desc)
into
[m
Oipo opened a new issue #248:
URL: https://github.com/apache/celix/issues/248
On Ubuntu 20.04 I get this warning when compiling experimental promises:
```
In file included from
/home/oipo-unencrypted/Programming/celix/misc/experimental/promise/api/celix/Deferred.h:29,
Oipo opened a new pull request #249:
URL: https://github.com/apache/celix/pull/249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Oipo commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-638206559
@pnoltes the OSX error is because pubsub_utils.c:186 tries to put 512 kb on
the stack, but the default stack size on OSX is 512 kb, leading to problems. I
can either reduce the stack s
pnoltes commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-638338893
> @pnoltes the OSX error is because pubsub_utils.c:186 tries to put 512 kb
on the stack, but the default stack size on OSX is 512 kb, leading to problems.
I can either reduce the st
codecov-commenter commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-638667860
# [Codecov](https://codecov.io/gh/apache/celix/pull/249?src=pr&el=h1) Report
> Merging [#249](https://codecov.io/gh/apache/celix/pull/249?src=pr&el=desc)
into
[master](
abroekhuis commented on pull request #185:
URL: https://github.com/apache/celix/pull/185#issuecomment-638694699
@pnoltes @Oipo is this one still relevant?
This is an automated message from the Apache Git Service.
To respond t
abroekhuis commented on pull request #226:
URL: https://github.com/apache/celix/pull/226#issuecomment-638695232
@pnoltes what are we going to do with this one?
This is an automated message from the Apache Git Service.
To resp
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r435084243
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -180,13 +180,8 @@ pubsub_tcpHandler_t
*pubsub_tcpHandler_create(pubsub_protoc
abroekhuis commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r435092917
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,34 @@ typedef struct celix_service_registration_options {
* for this.
abroekhuis commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r435096268
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -47,7 +47,7 @@ extern "C" {
* @param svc the service object. Normally a pointer to a ser
rbulter opened a new pull request #250:
URL: https://github.com/apache/celix/pull/250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
codecov-commenter commented on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc)
into
[master](
codecov-commenter edited a comment on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #250:
URL: https://github.com/apache/celix/pull/250#issuecomment-639468411
# [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc)
into
[m
pnoltes opened a new pull request #251:
URL: https://github.com/apache/celix/pull/251
The construction if (.. IN_LIST ..) is giving some problems with some
version of CMake (If I am correct 3.4 and 3.11).
For that reason this PR replace the usage of IN_LIST with a different
approac
codecov-commenter commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640286242
# [Codecov](https://codecov.io/gh/apache/celix/pull/251?src=pr&el=h1) Report
> Merging [#251](https://codecov.io/gh/apache/celix/pull/251?src=pr&el=desc)
into
[master](
abroekhuis commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640348749
I'm going to object this one. Not sure what the issue is, some details might
convinced me otherwise.
But, in_list is already in cmake since 3.3. And more importantly, we should
pnoltes commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640442026
> I'm going to object this one. Not sure what the issue is, some details
might convinced me otherwise.
> But, in_list is already in cmake since 3.3. And more importantly, we
shou
abroekhuis commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640450518
> > I'm going to object this one. Not sure what the issue is, some details
might convinced me otherwise.
> > But, in_list is already in cmake since 3.3. And more importantly, w
pnoltes commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640454450
> > > I'm going to object this one. Not sure what the issue is, some details
might convinced me otherwise.
> > > But, in_list is already in cmake since 3.3. And more importantly,
abroekhuis commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640458139
> > > > I'm going to object this one. Not sure what the issue is, some
details might convinced me otherwise.
> > > > But, in_list is already in cmake since 3.3. And more import
pnoltes commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640462987
> > > > > I'm going to object this one. Not sure what the issue is, some
details might convinced me otherwise.
> > > > > But, in_list is already in cmake since 3.3. And more impor
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436571355
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -180,13 +180,8 @@ pubsub_tcpHandler_t
*pubsub_tcpHandler_create(pubsub_protocol_ser
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436572520
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1266,9 +1269,12 @@ void pubsub_tcpHandler_handler(pubsub_tcpHandler_t
*handle) {
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436572662
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1301,11 +1308,14 @@ void pubsub_tcpHandler_handler(pubsub_tcpHandler_t
*handle) {
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436576299
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -501,10 +496,13 @@ static inline int pubsub_tcpHandler_closeConnectionEntry(
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436577961
##
File path: bundles/http_admin/test/test/http_websocket_tests.cc
##
@@ -222,7 +222,8 @@ TEST(HTTP_ADMIN_INT_GROUP, websocket_echo_test) {
usleep(100
abroekhuis commented on a change in pull request #251:
URL: https://github.com/apache/celix/pull/251#discussion_r436583406
##
File path: cmake/cmake_celix/BundlePackaging.cmake
##
@@ -195,15 +195,20 @@ function(add_celix_bundle)
endif ()
if (NOT DEFINED BUNDLE_FILEN
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436585222
##
File path: bundles/http_admin/test/test/http_websocket_tests.cc
##
@@ -222,7 +222,8 @@ TEST(HTTP_ADMIN_INT_GROUP, websocket_echo_test) {
usleep(1
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436585494
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -180,13 +180,8 @@ pubsub_tcpHandler_t
*pubsub_tcpHandler_create(pubsub_protoc
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436586668
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1301,11 +1308,14 @@ void pubsub_tcpHandler_handler(pubsub_tcpHandler_t
*hand
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436586585
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1266,9 +1269,12 @@ void pubsub_tcpHandler_handler(pubsub_tcpHandler_t
*handl
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436587250
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -501,10 +496,13 @@ static inline int pubsub_tcpHandler_closeConnectionEntry(
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436589233
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1266,9 +1269,12 @@ void pubsub_tcpHandler_handler(pubsub_tcpHandler_t
*handle) {
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436590234
##
File path: bundles/remote_services/topology_manager/src/topology_manager.c
##
@@ -207,68 +182,62 @@ celix_status_t topologyManager_rsaAdded(void * handle,
se
pnoltes merged pull request #251:
URL: https://github.com/apache/celix/pull/251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rbulter opened a new pull request #253:
URL: https://github.com/apache/celix/pull/253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
abroekhuis commented on a change in pull request #249:
URL: https://github.com/apache/celix/pull/249#discussion_r436637754
##
File path: bundles/http_admin/http_admin/src/activator.c
##
@@ -61,6 +61,15 @@ static int http_admin_start(http_admin_activator_t *act,
celix_bundle_co
abroekhuis commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-641057905
> Note: If we accept this PR. We should align it with the Java PubSub impl
I would even go a bit further. At this moment the wireprotocol is released
as version 1.0. If we
pnoltes commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r436742794
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,34 @@ typedef struct celix_service_registration_options {
* for this.
pnoltes commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640845523
Note: If we accept this PR. We should align it with the Java PubSub impl
This is an automated message from the Apach
pnoltes commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436704695
##
File path: bundles/remote_services/civetweb/src/civetweb.c
##
@@ -1,4 +1,4 @@
- /* Copyright (c) 2013-2015 the Civetweb developers
+/* Copyright (c)
codecov-commenter commented on pull request #254:
URL: https://github.com/apache/celix/pull/254#issuecomment-640846079
# [Codecov](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=desc)
into
[master](
pnoltes opened a new pull request #254:
URL: https://github.com/apache/celix/pull/254
Changes how CelixTargets cmake file are generated and used for installs with
multiple build types.
Primary so that there is can be a single CelixTargets.cmake entry point.
Tthis is needed to not
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
pnoltes opened a new issue #252:
URL: https://github.com/apache/celix/issues/252
When ENABLE_TESTING is ON, 'make install' will also install google test
together with celix.
This is an automated message from the Apache Git S
codecov-commenter commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[master](
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436711361
##
File path: bundles/remote_services/civetweb/src/civetweb.c
##
@@ -1,4 +1,4 @@
- /* Copyright (c) 2013-2015 the Civetweb developers
+/* Copyright (c) 201
pnoltes merged pull request #230:
URL: https://github.com/apache/celix/pull/230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abroekhuis commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r436774569
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,34 @@ typedef struct celix_service_registration_options {
* for this.
codecov-commenter edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-635359947
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
abroekhuis commented on a change in pull request #254:
URL: https://github.com/apache/celix/pull/254#discussion_r437169729
##
File path: cmake/cmake_celix/BundlePackaging.cmake
##
@@ -845,9 +851,12 @@ function(install_celix_bundle_targets)
set(EXPORT_FILE ${EXPORT_NAME
Oipo commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-640855800
`getaddrinfo()` apparently does something else on mac than on linux...
This is an automated message from the Apache Git
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r437158850
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1116,8 +1117,7 @@ char
*pubsub_tcpHandler_get_interface_url(pubsub_tcpHandle
pnoltes commented on a change in pull request #254:
URL: https://github.com/apache/celix/pull/254#discussion_r437176462
##
File path: cmake/cmake_celix/BundlePackaging.cmake
##
@@ -201,13 +201,19 @@ function(add_celix_bundle)
endif ()
-set(BUNDLE_FILENAME ${BASE_BU
codecov-commenter edited a comment on pull request #254:
URL: https://github.com/apache/celix/pull/254#issuecomment-640846079
# [Codecov](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #254:
URL: https://github.com/apache/celix/pull/254#issuecomment-640846079
# [Codecov](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[m
abroekhuis commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r437626913
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,38 @@ typedef struct celix_service_registration_options {
* for this.
codecov-commenter edited a comment on pull request #244:
URL: https://github.com/apache/celix/pull/244#issuecomment-633279422
# [Codecov](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/celix/pull/244?src=pr&el=desc)
into
[m
801 - 900 of 2506 matches
Mail list logo
