[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Github user MJJoyce commented on the pull request: https://github.com/apache/climate/pull/83#issuecomment-47775552 Cheers @agoodm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-241) Make old docstrings in plotter.py sphinx compliant
[ https://issues.apache.org/jira/browse/CLIMATE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049903#comment-14049903 ] ASF GitHub Bot commented on CLIMATE-241: Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/83 Make old docstrings in plotter.py sphinx compliant -- Key: CLIMATE-241 URL: https://issues.apache.org/jira/browse/CLIMATE-241 Project: Apache Open Climate Workbench Issue Type: Improvement Components: visualization Affects Versions: 0.2-incubating Reporter: Alex Goodman Assignee: Michael Joyce Fix For: 0.4 The old docstrings for the functions in plotter.py aren't compliant with sphinx and need to be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CLIMATE-241) Make old docstrings in plotter.py sphinx compliant
[ https://issues.apache.org/jira/browse/CLIMATE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Joyce resolved CLIMATE-241. --- Resolution: Fixed PR Merged Make old docstrings in plotter.py sphinx compliant -- Key: CLIMATE-241 URL: https://issues.apache.org/jira/browse/CLIMATE-241 Project: Apache Open Climate Workbench Issue Type: Improvement Components: visualization Affects Versions: 0.2-incubating Reporter: Alex Goodman Assignee: Michael Joyce Fix For: 0.4 The old docstrings for the functions in plotter.py aren't compliant with sphinx and need to be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CLIMATE-480) plotter.draw_subregions requires outdated subregion object
Michael Joyce created CLIMATE-480: - Summary: plotter.draw_subregions requires outdated subregion object Key: CLIMATE-480 URL: https://issues.apache.org/jira/browse/CLIMATE-480 Project: Apache Open Climate Workbench Issue Type: Bug Components: visualization Affects Versions: 0.3-incubating Reporter: Michael Joyce Fix For: 0.4 plotter.draw_subregions [1, line 216] requires a 'subregion object' from the old RCMET code base [2, line 37]. This should be removed and replaced with ocw.dataset.Bounds object [3, line 205]. It's possible that additional functionality will need to be added to the Bounds class. Subtasks will track that work. [1] https://github.com/apache/climate/blob/master/ocw/plotter.py [2] https://github.com/apache/climate/blob/master/rcmet/src/main/python/rcmes/classes.py [3] https://github.com/apache/climate/blob/master/ocw/dataset.py -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CLIMATE-481) StddevRatio and PatternCorr metrics outputting bad values
Michael Joyce created CLIMATE-481:
-
Summary: StddevRatio and PatternCorr metrics outputting bad values
Key: CLIMATE-481
URL: https://issues.apache.org/jira/browse/CLIMATE-481
Project: Apache Open Climate Workbench
Issue Type: Bug
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Fix For: 0.4
Kyo reported the StdDevRatio and PatternCorr metrics were returning unexpected
results. He provided some example code (below) that demonstrated expected
values.
There seems to be a few problems with the current metrics. First, we don't have
a version of these that doesn't do some sort of rebin on the data first. That
should be changed (in fact, we should probably only have versions that don't
rebin the data, but that's a separate conversation perhaps). Second,
StdDevRatio currently normalizes to the target, instead of the reference
dataset. That's an easy fix. Third, Kyo is using a different stats method to
get what he wants. I will play around a bit and see if I can determine which we
should use and get it changed.
{code}
taylor_data[imodel, 0]=ma.std(model.values)/ma.std(ref_dataset.values)
taylor_data[imodel, 1]=stats.mstats.linregress(ref_dataset.values,
model.values)[2]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CLIMATE-482) Add non-rebinning version of StdDevRatio
Michael Joyce created CLIMATE-482: - Summary: Add non-rebinning version of StdDevRatio Key: CLIMATE-482 URL: https://issues.apache.org/jira/browse/CLIMATE-482 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 Add a version of StdDevRatio that doesn't do some sort of climate/seasonal rebin on the data. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-482) Add non-rebinning version of StdDevRatio
[ https://issues.apache.org/jira/browse/CLIMATE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049992#comment-14049992 ] ASF GitHub Bot commented on CLIMATE-482: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/84#issuecomment-47786180 Merged build started. Test Failed. Add non-rebinning version of StdDevRatio Key: CLIMATE-482 URL: https://issues.apache.org/jira/browse/CLIMATE-482 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 Add a version of StdDevRatio that doesn't do some sort of climate/seasonal rebin on the data. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-482) Add non-rebinning version of StdDevRatio
[ https://issues.apache.org/jira/browse/CLIMATE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049991#comment-14049991 ] ASF GitHub Bot commented on CLIMATE-482: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/84#issuecomment-47786167 Merged build triggered. Test Failed. Add non-rebinning version of StdDevRatio Key: CLIMATE-482 URL: https://issues.apache.org/jira/browse/CLIMATE-482 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 Add a version of StdDevRatio that doesn't do some sort of climate/seasonal rebin on the data. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-482) Add non-rebinning version of StdDevRatio
[ https://issues.apache.org/jira/browse/CLIMATE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049990#comment-14049990 ] ASF GitHub Bot commented on CLIMATE-482: GitHub user MJJoyce opened a pull request: https://github.com/apache/climate/pull/84 CLIMATE-482 - Add basic StdDevRatio metric - Add a version of StdDevRatio without an yearly/seasonal rebinning prior to metric calculation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MJJoyce/climate CLIMATE-482 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit b632d48105cd6b662a201ebd8673d31684add3bf Author: Michael Joyce jo...@apache.org Date: 2014-07-02T14:48:22Z CLIMATE-482 - Add basic StdDevRatio metric - Add a version of StdDevRatio without an yearly/seasonal rebinning prior to metric calculation. Add non-rebinning version of StdDevRatio Key: CLIMATE-482 URL: https://issues.apache.org/jira/browse/CLIMATE-482 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 Add a version of StdDevRatio that doesn't do some sort of climate/seasonal rebin on the data. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] climate pull request: CLIMATE-483 - Add basic PatternCorrelation m...
GitHub user MJJoyce opened a pull request: https://github.com/apache/climate/pull/85 CLIMATE-483 - Add basic PatternCorrelation metric - Rename old PatternCorrelation metric to TemporalPatternCorrelation since it does an annual reshaping of the datasets before doing a comparison and that isn't adequately reflected in the metric's name. The new name also falls in line with the functionality of the TemporalStdDevRatio metric which also does such a rebin. - Add basic PatternCorrelation metric that uses scipy.stats.mstats.linregress to return the r_value for the reference and target datasets. Note, the metric no longer returns a tuple of values. It now only returns the r_value. This falls much more in line with the metrics name in my opinion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MJJoyce/climate CLIMATE-483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit 73e05e3598a29ab29c11c830a04c20464c467020 Author: Michael Joyce jo...@apache.org Date: 2014-07-02T15:10:40Z CLIMATE-483 - Add basic PatternCorrelation metric - Rename old PatternCorrelation metric to TemporalPatternCorrelation since it does an annual reshaping of the datasets before doing a comparison and that isn't adequately reflected in the metric's name. The new name also falls in line with the functionality of the TemporalStdDevRatio metric which also does such a rebin. - Add basic PatternCorrelation metric that uses scipy.stats.mstats.linregress to return the r_value for the reference and target datasets. Note, the metric no longer returns a tuple of values. It now only returns the r_value. This falls much more in line with the metrics name in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-483 - Add basic PatternCorrelation m...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47789643 Merged build triggered. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-483 - Add basic PatternCorrelation m...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47789659 Merged build started. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric
[ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050017#comment-14050017 ] ASF GitHub Bot commented on CLIMATE-483: GitHub user MJJoyce opened a pull request: https://github.com/apache/climate/pull/85 CLIMATE-483 - Add basic PatternCorrelation metric - Rename old PatternCorrelation metric to TemporalPatternCorrelation since it does an annual reshaping of the datasets before doing a comparison and that isn't adequately reflected in the metric's name. The new name also falls in line with the functionality of the TemporalStdDevRatio metric which also does such a rebin. - Add basic PatternCorrelation metric that uses scipy.stats.mstats.linregress to return the r_value for the reference and target datasets. Note, the metric no longer returns a tuple of values. It now only returns the r_value. This falls much more in line with the metrics name in my opinion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MJJoyce/climate CLIMATE-483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit 73e05e3598a29ab29c11c830a04c20464c467020 Author: Michael Joyce jo...@apache.org Date: 2014-07-02T15:10:40Z CLIMATE-483 - Add basic PatternCorrelation metric - Rename old PatternCorrelation metric to TemporalPatternCorrelation since it does an annual reshaping of the datasets before doing a comparison and that isn't adequately reflected in the metric's name. The new name also falls in line with the functionality of the TemporalStdDevRatio metric which also does such a rebin. - Add basic PatternCorrelation metric that uses scipy.stats.mstats.linregress to return the r_value for the reference and target datasets. Note, the metric no longer returns a tuple of values. It now only returns the r_value. This falls much more in line with the metrics name in my opinion. Add non-rebinning version of PatternCorrelation metric -- Key: CLIMATE-483 URL: https://issues.apache.org/jira/browse/CLIMATE-483 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] climate pull request: CLIMATE-483 - Add basic PatternCorrelation m...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47789765 Merged build finished. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric
[ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050018#comment-14050018 ] ASF GitHub Bot commented on CLIMATE-483: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47789643 Merged build triggered. Test Failed. Add non-rebinning version of PatternCorrelation metric -- Key: CLIMATE-483 URL: https://issues.apache.org/jira/browse/CLIMATE-483 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-481) StddevRatio and PatternCorr metrics outputting bad values
[
https://issues.apache.org/jira/browse/CLIMATE-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050022#comment-14050022
]
Michael Joyce commented on CLIMATE-481:
---
Update, either of the stats functions that were used are fine, they both give
us the same thing. The one that we're currently using is probably a bit faster
since it doesn't return 5 different values, but I stuck with the one Kyo was
using for CLIMATE-483.
StddevRatio and PatternCorr metrics outputting bad values
-
Key: CLIMATE-481
URL: https://issues.apache.org/jira/browse/CLIMATE-481
Project: Apache Open Climate Workbench
Issue Type: Bug
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Fix For: 0.4
Kyo reported the StdDevRatio and PatternCorr metrics were returning
unexpected results. He provided some example code (below) that demonstrated
expected values.
There seems to be a few problems with the current metrics. First, we don't
have a version of these that doesn't do some sort of rebin on the data first.
That should be changed (in fact, we should probably only have versions that
don't rebin the data, but that's a separate conversation perhaps). Second,
StdDevRatio currently normalizes to the target, instead of the reference
dataset. That's an easy fix. Third, Kyo is using a different stats method to
get what he wants. I will play around a bit and see if I can determine which
we should use and get it changed.
{code}
taylor_data[imodel, 0]=ma.std(model.values)/ma.std(ref_dataset.values)
taylor_data[imodel, 1]=stats.mstats.linregress(ref_dataset.values,
model.values)[2]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric
[ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050023#comment-14050023 ] ASF GitHub Bot commented on CLIMATE-483: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47789765 Merged build finished. Test Failed. Add non-rebinning version of PatternCorrelation metric -- Key: CLIMATE-483 URL: https://issues.apache.org/jira/browse/CLIMATE-483 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric
[ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050264#comment-14050264 ] ASF GitHub Bot commented on CLIMATE-483: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/85#issuecomment-47798437 Merged build finished. Test Passed. Add non-rebinning version of PatternCorrelation metric -- Key: CLIMATE-483 URL: https://issues.apache.org/jira/browse/CLIMATE-483 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CLIMATE-482) Add non-rebinning version of StdDevRatio
[ https://issues.apache.org/jira/browse/CLIMATE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Joyce resolved CLIMATE-482. --- Resolution: Fixed PR Merged Add non-rebinning version of StdDevRatio Key: CLIMATE-482 URL: https://issues.apache.org/jira/browse/CLIMATE-482 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 Add a version of StdDevRatio that doesn't do some sort of climate/seasonal rebin on the data. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric
[ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050280#comment-14050280 ] ASF GitHub Bot commented on CLIMATE-483: Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/85 Add non-rebinning version of PatternCorrelation metric -- Key: CLIMATE-483 URL: https://issues.apache.org/jira/browse/CLIMATE-483 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] climate pull request: CLIMATE-483 - Add basic PatternCorrelation m...
Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-484 - Drop rebinning metrics
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/86#issuecomment-47805106 Merged build triggered. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-484) Remove rebinning metrics
[
https://issues.apache.org/jira/browse/CLIMATE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050322#comment-14050322
]
ASF GitHub Bot commented on CLIMATE-484:
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/86
CLIMATE-484 - Drop rebinning metrics
- Drop rebinning metrics in favor of explicit rebins with the dataset
processor and utils helpers prior to an evaluation run.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-484
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
commit 9102a17cbbadca18bf46ba6039dd66fa71421ab1
Author: Michael Joyce jo...@apache.org
Date: 2014-07-02T16:51:11Z
CLIMATE-484 - Remove rebinning metrics
- Drop SpatialStdDevRation, TemporalPatternCorrelation,
SeasonalSpatialStdDevRation, and SeasonalPatternCorrelation.
commit 71706a9c72e67d96d758eb17e29e3049b4cc4fd5
Author: Michael Joyce jo...@apache.org
Date: 2014-07-02T16:52:54Z
CLIMATE-484 - Remove rebinning metrics from tests
Remove rebinning metrics
Key: CLIMATE-484
URL: https://issues.apache.org/jira/browse/CLIMATE-484
Project: Apache Open Climate Workbench
Issue Type: Task
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Fix For: 0.4
We have a few metrics (Spatial/SeasonalStdDevRatio and similar
PatternCorrelation ones) that do a temporal rebin. We've discussed this
before, but I think it's worth revisiting.
In my opinion, we shouldn't be doing rebins/regrids/manipulations during an
evaluation unless it's 100% necessary for the metric to make sense. In other
words:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
evaluation = Evaluation.evaluation(ds1, [ds2],
[metrics.TemporalStdDevRatio()])
evaluation.run()
{code}
Should really be:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)
evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
evaluation.run()
{code}
That is a more correct usage of the redesigned API in my opinion.
Thoughts? Comments? I'm going to send a PR for this change, but let's discuss
please.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CLIMATE-484) Remove rebinning metrics
[
https://issues.apache.org/jira/browse/CLIMATE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050324#comment-14050324
]
ASF GitHub Bot commented on CLIMATE-484:
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/86#issuecomment-47805106
Merged build triggered. Test Failed.
Remove rebinning metrics
Key: CLIMATE-484
URL: https://issues.apache.org/jira/browse/CLIMATE-484
Project: Apache Open Climate Workbench
Issue Type: Task
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Fix For: 0.4
We have a few metrics (Spatial/SeasonalStdDevRatio and similar
PatternCorrelation ones) that do a temporal rebin. We've discussed this
before, but I think it's worth revisiting.
In my opinion, we shouldn't be doing rebins/regrids/manipulations during an
evaluation unless it's 100% necessary for the metric to make sense. In other
words:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
evaluation = Evaluation.evaluation(ds1, [ds2],
[metrics.TemporalStdDevRatio()])
evaluation.run()
{code}
Should really be:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)
evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
evaluation.run()
{code}
That is a more correct usage of the redesigned API in my opinion.
Thoughts? Comments? I'm going to send a PR for this change, but let's discuss
please.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[GitHub] climate pull request: CLIMATE-484 - Drop rebinning metrics
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/86#issuecomment-47805672 Merged build triggered. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-484) Remove rebinning metrics
[
https://issues.apache.org/jira/browse/CLIMATE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050336#comment-14050336
]
ASF GitHub Bot commented on CLIMATE-484:
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/86#issuecomment-47805672
Merged build triggered. Test Failed.
Remove rebinning metrics
Key: CLIMATE-484
URL: https://issues.apache.org/jira/browse/CLIMATE-484
Project: Apache Open Climate Workbench
Issue Type: Task
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Fix For: 0.4
We have a few metrics (Spatial/SeasonalStdDevRatio and similar
PatternCorrelation ones) that do a temporal rebin. We've discussed this
before, but I think it's worth revisiting.
In my opinion, we shouldn't be doing rebins/regrids/manipulations during an
evaluation unless it's 100% necessary for the metric to make sense. In other
words:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
evaluation = Evaluation.evaluation(ds1, [ds2],
[metrics.TemporalStdDevRatio()])
evaluation.run()
{code}
Should really be:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)
evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
evaluation.run()
{code}
That is a more correct usage of the redesigned API in my opinion.
Thoughts? Comments? I'm going to send a PR for this change, but let's discuss
please.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CLIMATE-485) Ensure all metrics are included in Sphinx build
Michael Joyce created CLIMATE-485: - Summary: Ensure all metrics are included in Sphinx build Key: CLIMATE-485 URL: https://issues.apache.org/jira/browse/CLIMATE-485 Project: Apache Open Climate Workbench Issue Type: Task Components: documentation Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Fix For: 0.4 A number of the metrics are missing in the Sphinx build. Let's fix that!! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CLIMATE-368) Add JIRA labels for issue difficulty estimation
[ https://issues.apache.org/jira/browse/CLIMATE-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Joyce resolved CLIMATE-368. --- Resolution: Fixed Add JIRA labels for issue difficulty estimation --- Key: CLIMATE-368 URL: https://issues.apache.org/jira/browse/CLIMATE-368 Project: Apache Open Climate Workbench Issue Type: Task Components: general Affects Versions: 0.3-incubating Reporter: Michael Joyce Fix For: 0.4 We had discussed adding labels to help contributors with our project here [1] but these were never implemented. The propsed labels were: Don't Know Newcomer (Easy) - Everyone can do this level Committer (Medium) - This is for regular contributors/committers. Where the vast majority of issues would fall. Expert (Hard) - Used sparingly when an issue requires expert component knowledge [1] http://s.apache.org/xNm -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CLIMATE-484) Remove rebinning metrics
[
https://issues.apache.org/jira/browse/CLIMATE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Joyce updated CLIMATE-484:
--
Labels: Newcomer (was: )
Remove rebinning metrics
Key: CLIMATE-484
URL: https://issues.apache.org/jira/browse/CLIMATE-484
Project: Apache Open Climate Workbench
Issue Type: Task
Components: metrics
Affects Versions: 0.3-incubating
Reporter: Michael Joyce
Assignee: Michael Joyce
Labels: Newcomer
Fix For: 0.4
We have a few metrics (Spatial/SeasonalStdDevRatio and similar
PatternCorrelation ones) that do a temporal rebin. We've discussed this
before, but I think it's worth revisiting.
In my opinion, we shouldn't be doing rebins/regrids/manipulations during an
evaluation unless it's 100% necessary for the metric to make sense. In other
words:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
evaluation = Evaluation.evaluation(ds1, [ds2],
[metrics.TemporalStdDevRatio()])
evaluation.run()
{code}
Should really be:
{code}
ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)
ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)
evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
evaluation.run()
{code}
That is a more correct usage of the redesigned API in my opinion.
Thoughts? Comments? I'm going to send a PR for this change, but let's discuss
please.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CLIMATE-485) Ensure all metrics are included in Sphinx build
[ https://issues.apache.org/jira/browse/CLIMATE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Joyce updated CLIMATE-485: -- Labels: Newcomer (was: ) Ensure all metrics are included in Sphinx build --- Key: CLIMATE-485 URL: https://issues.apache.org/jira/browse/CLIMATE-485 Project: Apache Open Climate Workbench Issue Type: Task Components: documentation Affects Versions: 0.3-incubating Reporter: Michael Joyce Assignee: Michael Joyce Labels: Newcomer Fix For: 0.4 A number of the metrics are missing in the Sphinx build. Let's fix that!! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLIMATE-262) Develop simple examples of an End to End Evaluation using OCW API
[ https://issues.apache.org/jira/browse/CLIMATE-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050382#comment-14050382 ] Michael Joyce commented on CLIMATE-262: --- [~cgoodale], Unless you have any objections, I'm going to split the ensemble generation example out into its own issue so we can close this. Stuff is labeled as in-progress but it hasn't been updated since September of 2013. If you have an code that you were working on that you think will be useful can you please attach it to CLIMATE-265 so it can be used. Cheers Develop simple examples of an End to End Evaluation using OCW API - Key: CLIMATE-262 URL: https://issues.apache.org/jira/browse/CLIMATE-262 Project: Apache Open Climate Workbench Issue Type: Improvement Components: analysis Affects Versions: 0.2-incubating Environment: *nix Reporter: Cameron Goodale Assignee: Cameron Goodale Fix For: 0.4 This issue will be two fold. 1) Provide a running example demonstrating how to use the OCW APIs. 2) Provide an end-to-end Test (integration, regression, whatever test) but less format since it will not be running within a UnitTest framework Before work can start, the Refactor Branch needs to be merged back into the trunk so this work will be done in the trunk. Examples To Be Developed: = 1. Local Model to Local Model Evaluation (simplest, minimal data processing) 2. Local Model to RCMED Evaluation (temporal and spatial resampling of the data) 3. Model Ensemble to RCMED Evaluation (ensemble + all other functions before) Any bugs or issues that are uncovered in this process will be logged as JIRA sub-Tasks to this issue. Once those are resolved and the 3 examples are developed then we can resolve this issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CLIMATE-54) Updating the docstrings in metrics.py
[ https://issues.apache.org/jira/browse/CLIMATE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050476#comment-14050476 ] Michael Joyce edited comment on CLIMATE-54 at 7/2/14 5:47 PM: -- Hay [~kwhitehall], You still working on this or is it alright if I close it? I noticed it's been a while since it was updated. Cheers! was (Author: mjoyce): Hay [~kwhitehall], You still working on this or is it alright if I close it? I noticed it's been a while since its' been updated. Cheers! Updating the docstrings in metrics.py - Key: CLIMATE-54 URL: https://issues.apache.org/jira/browse/CLIMATE-54 Project: Apache Open Climate Workbench Issue Type: Documentation Components: metrics Affects Versions: 0.2-incubating Reporter: Kim Whitehall Assignee: Kim Whitehall Priority: Trivial Fix For: 0.4 Completing the unfinished docstrings in metrics.py -- This message was sent by Atlassian JIRA (v6.2#6252)
