[jira] [Commented] (CLIMATE-855) Fix test_local and test_dataset_processor

2016-08-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425175#comment-15425175
 ] 

ASF GitHub Bot commented on CLIMATE-855:


Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/394


> Fix test_local and test_dataset_processor
> -
>
> Key: CLIMATE-855
> URL: https://issues.apache.org/jira/browse/CLIMATE-855
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
>Priority: Critical
>
> The recent updates in ocw.data_source.local and ocw.dataset_processor cause 
> errors in nosetests. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate pull request #394: CLIMATE-855 - Fix test_local and test_dataset_pro...

2016-08-17 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-853) Broken documentation in dap.py

2016-08-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424960#comment-15424960
 ] 

ASF GitHub Bot commented on CLIMATE-853:


GitHub user Omkar20895 opened a pull request:

https://github.com/apache/climate/pull/395

CLIMATE-853 Fixing broken documentation in dap.py and making it PEP8 …

…compliant

- This PR addresses issue CLIMATE-853.
- I have removed '_' in the function '_current_times_to_date', I have 
removed this because sphinx does not load any function that starts with 
underscore in its automodule docstrings, hopefully this should fix it. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Omkar20895/climate master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395


commit 83c19de75b0976e0b06a0a6c8b171ea4bb901ce9
Author: Omkar20895 
Date:   2016-08-17T17:20:22Z

CLIMATE-853 Fixing broken documentation in dap.py and making it PEP8 
compliant




> Broken documentation in dap.py
> --
>
> Key: CLIMATE-853
> URL: https://issues.apache.org/jira/browse/CLIMATE-853
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Omkar Reddy
>Priority: Minor
> Fix For: 1.2.0
>
>
> When we build the documentation we can observe that sphinx drops the function 
> _convert_times_to_datetime() while building the documentation and this 
> function does not appear in the documentation. 
> The reason for the failure according to me could be that sphinx does not load 
> any function that starts with underscore in its automodule docstrings. I will 
> send a patch for this.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLIMATE-853) Broken documentation in dap.py

2016-08-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424961#comment-15424961
 ] 

ASF GitHub Bot commented on CLIMATE-853:


Github user OCWJenkins commented on the issue:

https://github.com/apache/climate/pull/395
  
 Merged build triggered. Test Failed.


> Broken documentation in dap.py
> --
>
> Key: CLIMATE-853
> URL: https://issues.apache.org/jira/browse/CLIMATE-853
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Omkar Reddy
>Priority: Minor
> Fix For: 1.2.0
>
>
> When we build the documentation we can observe that sphinx drops the function 
> _convert_times_to_datetime() while building the documentation and this 
> function does not appear in the documentation. 
> The reason for the failure according to me could be that sphinx does not load 
> any function that starts with underscore in its automodule docstrings. I will 
> send a patch for this.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate issue #395: CLIMATE-853 Fixing broken documentation in dap.py and ma...

2016-08-17 Thread OCWJenkins 
Github user OCWJenkins commented on the issue:

https://github.com/apache/climate/pull/395
  
 Merged build triggered. Test Failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #395: CLIMATE-853 Fixing broken documentation in dap.py...

2016-08-17 Thread Omkar20895 
GitHub user Omkar20895 opened a pull request:

https://github.com/apache/climate/pull/395

CLIMATE-853 Fixing broken documentation in dap.py and making it PEP8 …

…compliant

- This PR addresses issue CLIMATE-853.
- I have removed '_' in the function '_current_times_to_date', I have 
removed this because sphinx does not load any function that starts with 
underscore in its automodule docstrings, hopefully this should fix it. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Omkar20895/climate master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395


commit 83c19de75b0976e0b06a0a6c8b171ea4bb901ce9
Author: Omkar20895 
Date:   2016-08-17T17:20:22Z

CLIMATE-853 Fixing broken documentation in dap.py and making it PEP8 
compliant




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---