[GitHub] climate pull request #447: CLIMATE-920 Make examples Python 3 compatible

2017-08-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (CLIMATE-920) Make examples Python 3 compatible

2017-08-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLIMATE-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115442#comment-16115442
 ] 

ASF GitHub Bot commented on CLIMATE-920:


Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/447


> Make examples Python 3 compatible
> -
>
> Key: CLIMATE-920
> URL: https://issues.apache.org/jira/browse/CLIMATE-920
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: examples
>Affects Versions: 1.2.0
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 1.3.0
>
>
> Right now several of the example do not rn with Python 3... this is not good 
> and we should fix it. PR coming up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (CLIMATE-920) Make examples Python 3 compatible

2017-08-05 Thread Lewis John McGibbney (JIRA)

 [ 
https://issues.apache.org/jira/browse/CLIMATE-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney resolved CLIMATE-920.
--
Resolution: Fixed

> Make examples Python 3 compatible
> -
>
> Key: CLIMATE-920
> URL: https://issues.apache.org/jira/browse/CLIMATE-920
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: examples
>Affects Versions: 1.2.0
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 1.3.0
>
>
> Right now several of the example do not rn with Python 3... this is not good 
> and we should fix it. PR coming up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] climate issue #448: import os

2017-08-05 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/448
  
Thank you @cclauss 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate pull request #448: import os

2017-08-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/448


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate issue #448: import os

2017-08-05 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/448
  
In the future could you please open an issue at our issue tracker 
https://issues.apache.org/jira/browse/CLIMATE
It erely helps us to track project development.
Thank you very much @cclauss 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3

2017-08-05 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/439
  
Hi @kwhitehall I am sorry I didn't get back to you on this.
We need to update the PR to resolve conflicts. I will take a wee look on 
Monday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (CLIMATE-912) Upgrade mccSearch code from Python2 > 3

2017-08-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLIMATE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115445#comment-16115445
 ] 

ASF GitHub Bot commented on CLIMATE-912:


Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/439
  
Hi @kwhitehall I am sorry I didn't get back to you on this.
We need to update the PR to resolve conflicts. I will take a wee look on 
Monday.


> Upgrade mccSearch code from Python2 > 3
> ---
>
> Key: CLIMATE-912
> URL: https://issues.apache.org/jira/browse/CLIMATE-912
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: mcc search
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Fix For: 1.3.0
>
>
> I recently attempted to run the MCC Search code without any luck. Thsi issue 
> will simply upgrade the code such that it runs with Python 3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] climate pull request #444: optimizing code

2017-08-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/444


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate issue #444: optimizing code

2017-08-05 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/444
  
Thank you @Kejia in the future, if you could open an issue at our JIRA 
instance it would be greatly appreciated.
Thank you very much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate issue #445: optimizing traversing

2017-08-05 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/445
  
@Kejia can you please update this PR to resolve conflict? Thank you in 
advance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...

2017-08-05 Thread cclauss
Github user cclauss commented on a diff in the pull request:

https://github.com/apache/climate/pull/439#discussion_r131525549
  
--- Diff: mccsearch/code/mainProg.py ---
@@ -55,35 +55,35 @@ def main():
 # 
-
 
 # let's go!
-print "\n -- Read MERG Data --"
+print("\n -- Read MERG Data --")
 mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
-print ("-" * 80)
+print(("-" * 80))
--- End diff --

Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight 
places.  The double nested parens `(( ))` are not needed and only slow down 
your reader.  Repeated on lines: 60, 71, 73, 76, 78, 81, 84, 107.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...

2017-08-05 Thread cclauss
Github user cclauss commented on a diff in the pull request:

https://github.com/apache/climate/pull/439#discussion_r131525571
  
--- Diff: mccsearch/code/mainProgTemplate.py ---
@@ -59,36 +59,36 @@ def main():
 # 
-
 
 # let's go!
-print "\n -- Read MERG Data --"
+print("\n -- Read MERG Data --")
 mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
-print ("-" * 80)
+print(("-" * 80))
--- End diff --

Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight 
places.  The double nested parens `(( ))` are not needed and only slow down 
your reader.  Repeated on lines: 64, 75, 77, 80, 82, 86, 89, 112.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (CLIMATE-912) Upgrade mccSearch code from Python2 > 3

2017-08-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLIMATE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115450#comment-16115450
 ] 

ASF GitHub Bot commented on CLIMATE-912:


Github user cclauss commented on a diff in the pull request:

https://github.com/apache/climate/pull/439#discussion_r131525549
  
--- Diff: mccsearch/code/mainProg.py ---
@@ -55,35 +55,35 @@ def main():
 # 
-
 
 # let's go!
-print "\n -- Read MERG Data --"
+print("\n -- Read MERG Data --")
 mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
-print ("-" * 80)
+print(("-" * 80))
--- End diff --

Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight 
places.  The double nested parens `(( ))` are not needed and only slow down 
your reader.  Repeated on lines: 60, 71, 73, 76, 78, 81, 84, 107.


> Upgrade mccSearch code from Python2 > 3
> ---
>
> Key: CLIMATE-912
> URL: https://issues.apache.org/jira/browse/CLIMATE-912
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: mcc search
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Fix For: 1.3.0
>
>
> I recently attempted to run the MCC Search code without any luck. Thsi issue 
> will simply upgrade the code such that it runs with Python 3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CLIMATE-912) Upgrade mccSearch code from Python2 > 3

2017-08-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLIMATE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115451#comment-16115451
 ] 

ASF GitHub Bot commented on CLIMATE-912:


Github user cclauss commented on a diff in the pull request:

https://github.com/apache/climate/pull/439#discussion_r131525571
  
--- Diff: mccsearch/code/mainProgTemplate.py ---
@@ -59,36 +59,36 @@ def main():
 # 
-
 
 # let's go!
-print "\n -- Read MERG Data --"
+print("\n -- Read MERG Data --")
 mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
-print ("-" * 80)
+print(("-" * 80))
--- End diff --

Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight 
places.  The double nested parens `(( ))` are not needed and only slow down 
your reader.  Repeated on lines: 64, 75, 77, 80, 82, 86, 89, 112.


> Upgrade mccSearch code from Python2 > 3
> ---
>
> Key: CLIMATE-912
> URL: https://issues.apache.org/jira/browse/CLIMATE-912
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: mcc search
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Fix For: 1.3.0
>
>
> I recently attempted to run the MCC Search code without any luck. Thsi issue 
> will simply upgrade the code such that it runs with Python 3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)