[jira] [Created] (CLIMATE-845) Add vertices attribute to Bounds objects

2016-08-03 Thread Alex Goodman (JIRA) 
Alex Goodman created CLIMATE-845:


 Summary: Add vertices attribute to Bounds objects
 Key: CLIMATE-845
 URL: https://issues.apache.org/jira/browse/CLIMATE-845
 Project: Apache Open Climate Workbench
  Issue Type: Improvement
  Components: regridding/data processing
Affects Versions: 1.1.0
Reporter: Alex Goodman
Assignee: Huikyo Lee
 Fix For: 1.2.0


Bounds objects can now take on general shapes thanks to compatibility with 
shapefiles. In order to make the functionality of Bounds more general, we 
should be treating them as continuous paths with a set of vertices. Therefore, 
a new attribute called {{vertices}} containing the x, y coordinates of each 
vertex should be defined for each Bounds object, regardless of the boundary 
type (eg. 'user', 'countries', 'us_states', and 'rectangular'). The vertices 
should also form a continuous path (eg a single closed boundary containing the 
entire subregion). This change would make it easy to generalize the process of 
masking, subsetting, and plotting subregions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CLIMATE-842) Add shape files to package installation

2016-08-03 Thread Alex Goodman (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CLIMATE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Goodman resolved CLIMATE-842.
--
Resolution: Fixed

> Add shape files to package installation
> ---
>
> Key: CLIMATE-842
> URL: https://issues.apache.org/jira/browse/CLIMATE-842
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>  Components: build process, conda
>Affects Versions: 1.2.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> The new options for Bounds objects that involve shapefiles (via CLIMATE-827) 
> will not work if ocw is installed into the user's environment via 
> {{setup.py}} (ie via pip or conda). I will update this file and 
> {{MANIFEST.in}} to ensure that the shapefiles are included in our 
> installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate pull request #382: CLIMATE-842 - Add shape files to package installa...

2016-08-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/382


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-842) Add shape files to package installation

2016-08-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406763#comment-15406763
 ] 

ASF GitHub Bot commented on CLIMATE-842:


Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/382


> Add shape files to package installation
> ---
>
> Key: CLIMATE-842
> URL: https://issues.apache.org/jira/browse/CLIMATE-842
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>  Components: build process, conda
>Affects Versions: 1.2.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> The new options for Bounds objects that involve shapefiles (via CLIMATE-827) 
> will not work if ocw is installed into the user's environment via 
> {{setup.py}} (ie via pip or conda). I will update this file and 
> {{MANIFEST.in}} to ensure that the shapefiles are included in our 
> installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLIMATE-842) Add shape files to package installation

2016-08-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406606#comment-15406606
 ] 

ASF GitHub Bot commented on CLIMATE-842:


Github user OCWJenkins commented on the issue:

https://github.com/apache/climate/pull/382
  
Can one of the admins verify this patch?


> Add shape files to package installation
> ---
>
> Key: CLIMATE-842
> URL: https://issues.apache.org/jira/browse/CLIMATE-842
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>  Components: build process, conda
>Affects Versions: 1.2.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> The new options for Bounds objects that involve shapefiles (via CLIMATE-827) 
> will not work if ocw is installed into the user's environment via 
> {{setup.py}} (ie via pip or conda). I will update this file and 
> {{MANIFEST.in}} to ensure that the shapefiles are included in our 
> installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate issue #382: CLIMATE-842 - Add shape files to package installation

2016-08-03 Thread OCWJenkins 
Github user OCWJenkins commented on the issue:

https://github.com/apache/climate/pull/382
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-842) Add shape files to package installation

2016-08-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLIMATE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406603#comment-15406603
 ] 

ASF GitHub Bot commented on CLIMATE-842:


GitHub user agoodm opened a pull request:

https://github.com/apache/climate/pull/382

CLIMATE-842 - Add shape files to package installation

This PR makes the following changes:

- Added the `ocw/shape` directory to the package build.
- Set `zip_safe` to `False` in the setup script. This means and builds via 
conda or pip will maintain the original directory structure of the `ocw` 
directory instead of bundling everything into a binary .egg file. This will 
make imports a tad slower, but it is necessary in order to ensure that the 
shapefiles can be found. It also allows users to more easily check the source 
code on their machines.
- Renamed usa_states shapefiles to "us_states", so that `boundary_type` 
always has the same name as the shapefile.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agoodm/climate CLIMATE-842

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #382


commit 27c1c94b7177a234f23fed5c7bbd63e533de2223
Author: Alex Goodman 
Date:   2016-08-03T20:48:14Z

CLIMATE-842 - Add shape files to package installation




> Add shape files to package installation
> ---
>
> Key: CLIMATE-842
> URL: https://issues.apache.org/jira/browse/CLIMATE-842
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>  Components: build process, conda
>Affects Versions: 1.2.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> The new options for Bounds objects that involve shapefiles (via CLIMATE-827) 
> will not work if ocw is installed into the user's environment via 
> {{setup.py}} (ie via pip or conda). I will update this file and 
> {{MANIFEST.in}} to ensure that the shapefiles are included in our 
> installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate pull request #382: CLIMATE-842 - Add shape files to package installa...

2016-08-03 Thread agoodm 
GitHub user agoodm opened a pull request:

https://github.com/apache/climate/pull/382

CLIMATE-842 - Add shape files to package installation

This PR makes the following changes:

- Added the `ocw/shape` directory to the package build.
- Set `zip_safe` to `False` in the setup script. This means and builds via 
conda or pip will maintain the original directory structure of the `ocw` 
directory instead of bundling everything into a binary .egg file. This will 
make imports a tad slower, but it is necessary in order to ensure that the 
shapefiles can be found. It also allows users to more easily check the source 
code on their machines.
- Renamed usa_states shapefiles to "us_states", so that `boundary_type` 
always has the same name as the shapefile.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agoodm/climate CLIMATE-842

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #382


commit 27c1c94b7177a234f23fed5c7bbd63e533de2223
Author: Alex Goodman 
Date:   2016-08-03T20:48:14Z

CLIMATE-842 - Add shape files to package installation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (CLIMATE-844) Attribute Error in test_smoke.py

2016-08-03 Thread Ibrahim Jarif (JIRA) 
Ibrahim Jarif created CLIMATE-844:
-

 Summary: Attribute Error in test_smoke.py
 Key: CLIMATE-844
 URL: https://issues.apache.org/jira/browse/CLIMATE-844
 Project: Apache Open Climate Workbench
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Ibrahim Jarif
Assignee: Ibrahim Jarif
Priority: Trivial
 Fix For: 1.2.0


Rename time_range in test_smoke.py to temporal_boundaries. The bug was induced 
due to CLIMATE-488



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLIMATE-842) Add shape files to package installation

2016-08-03 Thread Alex Goodman (JIRA) 
Alex Goodman created CLIMATE-842:


 Summary: Add shape files to package installation
 Key: CLIMATE-842
 URL: https://issues.apache.org/jira/browse/CLIMATE-842
 Project: Apache Open Climate Workbench
  Issue Type: Bug
  Components: build process, conda
Affects Versions: 1.2.0
Reporter: Alex Goodman
Assignee: Alex Goodman
 Fix For: 1.2.0


The new options for Bounds objects that involve shapefiles (via CLIMATE-827) 
will not work if ocw is installed into the user's environment via {{setup.py}} 
(ie via pip or conda). I will update this file and {{MANIFEST.in}} to ensure 
that the shapefiles are included in our installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLIMATE-843) Update draw_subregions for Bounds derived from shapefiles

2016-08-03 Thread Alex Goodman (JIRA) 
Alex Goodman created CLIMATE-843:


 Summary: Update draw_subregions for Bounds derived from shapefiles
 Key: CLIMATE-843
 URL: https://issues.apache.org/jira/browse/CLIMATE-843
 Project: Apache Open Climate Workbench
  Issue Type: Improvement
  Components: visualization
Affects Versions: 1.1.0
Reporter: Alex Goodman
Assignee: Alex Goodman
 Fix For: 1.2.0


Thanks to the changes introduced in CLIMATE-827, we can now define subregion 
boundaries via included shapefiles. The old {{plotter.draw_subregions()}} (and 
its counterpart used in the RCMES examples) still assume rectangular Bounds. 
This proposed change will treat every Bounds object as a generic polygon with a 
list of vertices for the purposes of drawing them correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CLIMATE-841) ocw.dataset_processor.subset

2016-08-03 Thread Huikyo Lee (JIRA) 
Huikyo Lee created CLIMATE-841:
--

 Summary: ocw.dataset_processor.subset
 Key: CLIMATE-841
 URL: https://issues.apache.org/jira/browse/CLIMATE-841
 Project: Apache Open Climate Workbench
  Issue Type: Improvement
Reporter: Huikyo Lee
Assignee: Huikyo Lee
 Fix For: 1.2.0


CLIMATE-827 has added more options to ocw.Bounds for spatial data masking. Now 
the dataset_processor.subset module will be updated to fully utilize the 
updated Bounds object. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (CLIMATE-827) Adding spatial masking options

2016-08-03 Thread Huikyo Lee (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CLIMATE-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huikyo Lee closed CLIMATE-827.
--
Resolution: Fixed

> Adding spatial masking options
> --
>
> Key: CLIMATE-827
> URL: https://issues.apache.org/jira/browse/CLIMATE-827
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> With this patch, users can use an array of country or US state names to 
> extract or mask OCW datasets. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] climate pull request #376: CLIMATE-830 Broken tests in dap.py

2016-08-03 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/376


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---