[GitHub] climate pull request #449: CLIMATE-887 - test_local.py speed and style guide...

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] climate pull request #449: CLIMATE-887 - test_local.py speed and style guide...

2017-08-09 Thread justinlulejian
GitHub user justinlulejian opened a pull request:

https://github.com/apache/climate/pull/449

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinlulejian/climate master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #449


commit 56989f5788bc6ef9e8b2a68bad62d7ed98b1e629
Author: Justin L 
Date:   2017-08-09T08:28:31Z

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---