Re: Review Request: Cleaning up the metrics.py file

2013-06-07 Thread Kyo Lee
> On June 7, 2013, 5:58 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py, > > line 1589 > > > > > > consider deleting this since i

Re: Review Request: Cleaning up the metrics.py file

2013-06-06 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21563 --- Ship it! Ship It! - Chris Mattmann On June 6, 2013, 12:15 a.m.,

Re: Review Request: Cleaning up the metrics.py file

2013-06-06 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21562 --- http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/m

Re: Review Request: Cleaning up the metrics.py file

2013-06-05 Thread Kyo Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/ --- (Updated June 6, 2013, 12:15 a.m.) Review request for Apache Open Climate. Ch

Re: Review Request: Cleaning up the metrics.py file

2013-06-05 Thread Kyo Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/ --- (Updated June 5, 2013, 10:17 p.m.) Review request for Apache Open Climate. Ch

Re: Review Request: Cleaning up the metrics.py file

2013-06-04 Thread Cameron Goodale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21466 --- Kyo, I know there are a lot of comments on this review. I think thi

Re: Review Request: Cleaning up the metrics.py file

2013-06-04 Thread Cameron Goodale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21464 --- http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/m

Re: Review Request: Cleaning up the metrics.py file

2013-06-04 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21457 --- http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/m

Re: Review Request: Cleaning up the metrics.py file

2013-06-04 Thread Kyo Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/ --- (Updated June 4, 2013, 10:25 p.m.) Review request for Apache Open Climate. De