The 'cleanest cleanest' way is to use rebase as Sheng recommends but I
know people who've used git successfully with just doing merge. It's
(rebase) one of those features of git you discover only after
using-abusing it for long enough. But if you're adventurous .. :)
Do NOT do a rebase if you've
If nobody object, I will merge into master today.
-Wei
2013/6/11 John Burwell jburw...@basho.com
Mike,
From a CloudStack perspective, it will keep implementation specific
concepts from the base data model, and provide a great test case to develop
a mechanism to capture this information in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11856/#review21845
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 13, 2013, 8:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11803/#review21846
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 12, 2013, 9:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/
---
Review request for cloudstack, Murali Reddy and Ram Ganesh.
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/
---
(Updated June 13, 2013, 10:30 a.m.)
Review request for cloudstack, Prasanna
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/
---
Review request for cloudstack and Nitin Mehta.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/#review21848
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 13, 2013, 10:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/#review21850
---
Commit b83b8eb838546197151d96e99ab3b9ee68db7df8 in branch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/
---
Review request for cloudstack.
Description
---
double slash breaks
H,
Can someone look at Review Request #11861https://reviews.apache.org/r/11861/
for me please?
Thanks,
Daan Hoogland
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11862/
---
Review request for cloudstack.
Description
---
In the new system vm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
---
(Updated June 13, 2013, 1:09 p.m.)
Review request for cloudstack, Murali
Daan,
Has this been tested on linux NFS?
On 6/13/13 8:15 AM, Daan Hoogland dhoogl...@schubergphilis.com wrote:
H,
Can someone look at Review Request
#11861https://reviews.apache.org/r/11861/ for me please?
Thanks,
Daan Hoogland
It has been tested on nexenta (sunos). I have no linux on my hands for this.
-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: donderdag 13 juni 2013 15:27
To: dev@cloudstack.apache.org
Subject: Re: committer wanted for review
Daan,
Has this been tested on linux
Looking at this in more detail, that's not going to do it. If we have to
create a template and call deployVirtualMachine, that will
do--intentionally--what it was intended to do: spin up a new VM in the
hypervisor and allocate a chunk of disk out of primary storage.
What we are looking to do,
Ilya,
Why do you ask? It only touches the database, not the nfs server itself!
Regards,
Daan Hoogland
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: donderdag 13 juni 2013 15:32
To: 'dev@cloudstack.apache.org'
Subject: RE: committer wanted for review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11863/
---
Review request for cloudstack.
Summary (updated)
-
Change
Wei,
There are open questions on the thread regarding mutual exclusion of
hypervisor throttled I/O and storage provisioned IOPS. We need to
understand how and where it will be implemented in both the UI and
service layers. Also, can you resend the Review Board review? My
email search skills
Hi everyone, first time poster here…
I've started working on a UI Plugin and have come across a few things I'd like
to inquire about and run by some of you:
-Internationalization: I see that the UI has a system for internationalization,
but I don't see a way for UI plugins to contribute
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/#review21859
---
Ship it!
ed1980c7417216efa541c978d4233391d1659b79
- Prasanna
John,
Please review the code on https://reviews.apache.org/r/11782
The storage provisioned IOPS does not affect hypervisor throttled I/O, I
think.
Mike may change UI and java code for storage provisioned IOPS after the
merge.
-Wei
2013/6/13 John Burwell jburw...@basho.com
Wei,
There are
CreateCommand in the agent code is responsible for making a template
into a new volume. With Xen and VMware, you're limited to what the
hypervisor is capable of as far as storage cloning to create a new
copy from an existing template on your primary storage. With KVM, you
can create your own
Yeah, I think it's fine for Wei to merge in his changes. I can then fetch
and merge into my branch and add the additional GUI and API code for mutual
exclusion.
On Thu, Jun 13, 2013 at 9:34 AM, Wei ZHOU ustcweiz...@gmail.com wrote:
John,
Please review the code on
Cool, we'll take a look at CreateCommand. I like your suggestion to tweak the
execute method to accomplish this.
We are literally getting our feet wet at this point, and have some ideas that
we are looking to implement in a NetApp plugin to CS.
Hopefully we'll get to meet some of you at the
Hi all,
I'm attempting to run the following:
mvn -Pdeveloper,marvin.test -Dmarvin.config=setup/dev/advanced.cfg -pl
:cloud-marvin integration-test
from instructions [1]. It seems all tests involving deploying a VM fail for me
[2]. I've also tried running the /smoke/test_deploy_vm.py test in
All,
Edison Su, Min Chen, Animesh Chaturvedi, and myself met via teleconference on
11 June 2013 @ 1:30 PM EDT. The goal of the meeting was determine the path
forward for merging the object_store branch by the 4.2 freeze date, 30 June
2013. The conversation focused on the following topics:
Thanks, everyone!
Once I finish up implementing review suggestions, I can try again with
building a squashed patch file.
On Thu, Jun 13, 2013 at 8:41 AM, John Burwell jburw...@basho.com wrote:
Prasanna,
+1 to using rebase on feature branches.
At least as I understand things and have
Thanks John for summary. From QA stand point it would make sense to merge once
- assigned test cases are executed and pass rate is on par with release
criteria ( test plans published and execution results are being posted)
- automation runs are successful and shows same pass rate as Master
-
Please see comments inline -
Thanks,
Pranav
-Original Message-
From: SuichII, Christopher [mailto:chris.su...@netapp.com]
Sent: Thursday, June 13, 2013 8:11 PM
To: dev@cloudstack.apache.org
Subject: UI Plugin Questions
Hi everyone, first time poster here...
I've started working on a
Hi All,
While fixing an issue ( https://reviews.apache.org/r/11862/ )in ssvm-check
script I figured out some issues.
1.There are two ssvm_check scripts(duplicates).
./services/console-proxy/server/scripts/ssvm-check.sh
./services/secondary-storage/scripts/ssvm-check.sh
When building the code,
Sudha,
The current plan is to merge once. We explored the feasibility of decomposing
it into independent, testable chunks, and determined it was not possible.
Thanks,
-John
On Jun 13, 2013, at 12:54 PM, Sudha Ponnaganti sudha.ponnaga...@citrix.com
wrote:
Thanks John for summary. From QA
Sure John!
I am referring to the point that even for one time merge, let us go through the
planned QA cycle.
Thanks
/sudha
-Original Message-
From: John Burwell [mailto:jburw...@basho.com]
Sent: Thursday, June 13, 2013 10:14 AM
To: dev@cloudstack.apache.org
Subject: Re: Object_Store
First, thanks for bringing this back to the list. I'm +1 on the technical
approach.
A couple of thoughts though, just so that we make sure that we keep
operating in the right manner as an Apache project:
Let's be careful about declaring something a decision or that
something was determined when
On Thu, Jun 13, 2013 at 05:10:06PM +, Rajesh Battala wrote:
Hi All,
While fixing an issue ( https://reviews.apache.org/r/11862/ )in ssvm-check
script I figured out some issues.
1.There are two ssvm_check scripts(duplicates).
./services/console-proxy/server/scripts/ssvm-check.sh
-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Thursday, June 13, 2013 10:43 AM
To: dev@cloudstack.apache.org
Subject: Re: Object_Store storage refactor Meeting Notes
First, thanks for bringing this back to the list. I'm +1 on the
technical
I know the infrastructure code is too huge to handle and that is why all new
features which would be developed would be developed in the form of UI
modules (Eg - CISCO asa 100 support / vnmcNetworkProvider / VPC) .
That is correct -- the infrastructure section handles a lot of central parts
On Thu, Jun 13, 2013 at 05:52:01PM +, Animesh Chaturvedi wrote:
-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Thursday, June 13, 2013 10:43 AM
To: dev@cloudstack.apache.org
Subject: Re: Object_Store storage refactor Meeting Notes
On Thu, Jun 13, 2013 at 04:17:10PM +, La Motta, David wrote:
Cool, we'll take a look at CreateCommand. I like your suggestion to tweak
the execute method to accomplish this.
We are literally getting our feet wet at this point, and have some ideas that
we are looking to implement in a
Shane,
Can you share the management server log file?
Prachi
-Original Message-
From: Shane Witbeck [mailto:sh...@digitalsanctum.com]
Sent: Thursday, June 13, 2013 9:18 AM
To: dev@cloudstack.apache.org
Subject: tests involving deploying a vm fail
Hi all,
I'm attempting to run the
On Thu, Jun 13, 2013 at 1:55 PM, Chip Childers
chip.child...@sungard.com wrote:
On Thu, Jun 13, 2013 at 05:52:01PM +, Animesh Chaturvedi wrote:
-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Thursday, June 13, 2013 10:43 AM
To:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11782/#review21865
---
api/src/com/cloud/agent/api/to/VolumeTO.java
Hey David, not sure if I mentioned this, but there are some guys at NetApp in
Calgary that are interested in CloudStack development as well
- Original Message -
From: Chip Childers chip.child...@sungard.com
To: dev@cloudstack.apache.org
Sent: Thursday, June 13, 2013 10:56:51 AM
Subject:
Hey Kelcey, you'd mentioned there was somebody, but never got any specifics.
You can share names outside of this thread if you'd like, and I'll reach out to
them internally. If not I'll have to go on a witch hunt :-)
David La Motta
Technical Marketing Engineer
Citrix Solutions
NetApp
Wei,
I published my review. I didn't see any code to validating the rate values
(e.g. values greater than 0, values less than an maximum value). Did I miss it?
I also noticed that 0 is being used when no value has been specified. I
recommend using the Long type rather primitive long in
David and Chip,
There was no intention to side step to the list. I will be more careful in my
phrasing in the future.
I apologize for the lack of clarity,
-John
On Jun 13, 2013, at 1:58 PM, David Nalley da...@gnsa.us wrote:
On Thu, Jun 13, 2013 at 1:55 PM, Chip Childers
I'm using require.js to get some custom strings into the dictionary now,
so I'll look into extending the plugin api to add internationalized string
js files for plugins while I'm in there.
Some helpers with the Infrastructure would be great, but maybe what I
meant wasn't clear. We don't want to
Hey all,
As you know, the conference is coming up in less than two weeks. The
first day is going to be a hack day using an un-conference/BarCamp
type structure where we ask attendees to set the agenda and have spaces
set aside to work on things or have more interactive sessions to hammer
out
I was tipped off by one of the Vancouver guys by the name of Dave Dye. He never
told me who specifically or which team, so I'm afraid it's a witch hunt, or
maybe get in touch with Dave, he might know who to connect you to.
- Original Message -
From: David La Motta
Hi Edison,
I notice after I updated from master that Hypervisor Type is now a required
parameter for creating a storage pool.
Should I just use HypervisorType.Any?
Thanks!
On Thu, Jun 13, 2013 at 12:21 PM, John Burwell jburw...@basho.com wrote:
Wei,
I published my review. I didn't see
On June 13, 2013, 6:01 p.m., John Burwell wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) || (bytesReadRate 0) ? 0 :
bytesReadRate;
}
It
Hi,
Has anyone else noticed in the Mac OS X Terminal that CTRL-Cing out of the
CS MS sometimes puts you back to a prompt that works, but does not show you
the text you're typing?
If so, do you know how to fix this issue?
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire
Cool. I'll circle around internally. Thanks.
David La Motta
Technical Marketing Engineer
Citrix Solutions
NetApp
919.476.5042
dlamo...@netapp.commailto:dlamo...@netapp.com
On Jun 13, 2013, at 2:38 PM, Kelcey Jamison Damage
kel...@bbits.camailto:kel...@bbits.ca
wrote:
I was tipped off by
On Thu, Jun 13, 2013, at 02:21 PM, Mike Tutkowski wrote:
If so, do you know how to fix this issue?
I have not noticed it there, but other programs do this. If you get
this, try typing reset and hitting enter, that will sometimes help
reset the terminal.
Best,
jzb
--
Joe Brockmeier
Widgetizing the various wizards won't be targeted for 4.2 for sure . It would
mostly be for some future release ..may be 4.3 or later since it would require
pretty good amount of refactoring apart from a brand new implementation .
Thanks,
Pranav
-Original Message-
From: SuichII,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11866/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
On June 13, 2013, 6:01 p.m., John Burwell wrote:
Wei Zhou wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) ||
On June 13, 2013, 6:01 p.m., John Burwell wrote:
Wei Zhou wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) ||
On June 13, 2013, 6:01 p.m., John Burwell wrote:
Wei Zhou wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) ||
On June 13, 2013, 6:01 p.m., John Burwell wrote:
Wei Zhou wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) ||
On June 13, 2013, 6:01 p.m., John Burwell wrote:
Wei Zhou wrote:
John,
The validation of input fields is in CreateDiskOfferingCmd.java and
CreateServiceOfferingCmd.java, like:
public long getBytesReadRate() {
return (bytesReadRate == null) ||
Actually, I am noticing some new behavior around picking a storage pool for
zone-wide storage.
The current implementation that I've brought down from master no longer
finds storage for me because my plug-in is zone wide and not associated
with a hypervisor.
Edison?
On Thu, Jun 13, 2013 at 1:13
Thanks, guys
Unfortunately it didn't respond properly with either option. :(
On Thu, Jun 13, 2013 at 1:43 PM, Chip Childers chip.child...@sungard.comwrote:
On Thu, Jun 13, 2013 at 02:41:35PM -0500, Joe Brockmeier wrote:
On Thu, Jun 13, 2013, at 02:21 PM, Mike Tutkowski wrote:
If so, do
Not that this is a long-term solution or anything, but I just commented out
the test. :)
On Wed, Jun 12, 2013 at 3:57 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
This is what nslookup 127.0.0.1 brings up for me:
Server: 172.16.1.2
Address: 172.16.1.2#53
1.0.0.127.in-addr.arpa
Mike,
Please see my comment in-line below.
Thanks,
-John
On Jun 13, 2013, at 1:22 AM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
Hi John,
I've put comments below in red.
Thanks!
On Wed, Jun 12, 2013 at 10:51 PM, John Burwell jburw...@basho.com wrote:
Mike,
First and
Hi,
I was wondering if we have the following documentation (below). If not, I
was thinking it might be a good session to discuss and start in (at a high
level) on developing such documentation.
1) Class diagrams highlighting the main classes that make up the Compute,
Networking, and Storage
There is not a use case, but from the UI Plugin design description, looks like
it is aimed at extending the CS UI after it is in production. I was thinking
that there might be a requirement for having some Server side code running in
CS to support this UI Plugin.
The current CS Plugins are
So, open features are theoretically in progress but simply not updated
in Jira?
On 6/12/13 4:46 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com
wrote:
Folks
The status for features or improvement is depicted in table below
|-+---+---|
| New
Comments below in red.
Thanks
On Thu, Jun 13, 2013 at 2:54 PM, John Burwell jburw...@basho.com wrote:
Mike,
Please see my comment in-line below.
Thanks,
-John
On Jun 13, 2013, at 1:22 AM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
Hi John,
I've put comments below in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11782/
---
(Updated June 13, 2013, 9:25 p.m.)
Review request for cloudstack, Wido den
My thinking is, for 4.2, while not ideal, we will need to put some burden
on the admin to configure a Disk Offering in a way that makes sense. For
example, if he wants to use storage QoS with supported Min and Max values,
he'll have to put in a storage tag that references the SolidFire primary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/#review21882
---
Ship it!
Ship It!
- edison su
On May 13, 2013, 10:32 p.m., Fang
So, here's my suggestion for 4.2:
Accept the values as they are currently required (four new fields for Wei's
feature or two new fields for mine).
The Add Disk Offering dialog needs three new radio buttons:
1) No QoS
2) Hypervisor QoS
3) Storage Qos
The admin needs to specify storage tags
How about set hypervisorType to Any? Haven't take a look at the master change
yet.
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Thursday, June 13, 2013 1:41 PM
To: dev@cloudstack.apache.org
Cc: Edison Su
Subject: Re: [MERGE] disk_io_throttling to MASTER (Second Round)
Yeah, I did that. :)
I had to change some allocator code, too, because it didn't like zone-wide
storage being set to hypervisor any.
On Thu, Jun 13, 2013 at 3:45 PM, Edison Su edison...@citrix.com wrote:
How about set hypervisorType to Any? Haven’t take a look at the master
change yet.
Mike,
See my comments in-line below.
Thanks,
-John
On Jun 13, 2013, at 5:31 PM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
My thinking is, for 4.2, while not ideal, we will need to put some burden
on the admin to configure a Disk Offering in a way that makes sense. For
example, if
Ian,
Hope all is well,
Please consider a case when you get a very large userbase - i.e. what would
happen when you have 1000+ users in ldap/active directory?
In past I've seen other products crash because the logic could not handle a
where large user base.
Regards
ilya
-Original
Mike,
Overall, I agree with the steps to below for 4.2. However, we may want to
throw an exception if we can not fulfill a requested QoS. If the user is
expecting that the hypervisor will provide a particular QoS, and that is not
possible, it seems like we should inform them rather than
Hi,
As far as I'm aware listAll being passed to LDAPConfigCmd only returns
the LDAP configuration stored within the cloudstack database, not user
accounts so it shouldn't affect it.
I am looking at adding an LDAPUserListCmd with my GSoC project(Ldap
user provisioning) in order to enable AJAX
Comments below in red.
Thanks
On Thu, Jun 13, 2013 at 3:58 PM, John Burwell jburw...@basho.com wrote:
Mike,
Overall, I agree with the steps to below for 4.2. However, we may want to
throw an exception if we can not fulfill a requested QoS. If the user is
expecting that the hypervisor
On June 12, 2013, 11:15 p.m., John Burwell wrote:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java,
line 6494
https://reviews.apache.org/r/11479/diff/1/?file=297882#file297882line6494
To reduce the conditional nesting, check if (!created[0]),
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/#review21883
---
Commit 4612656de86a4a0258852c3fb89724bda6b612b3 in branch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11052/
---
(Updated June 13, 2013, 10:55 p.m.)
Review request for cloudstack, edison su
Overall, I agree with the steps to below for 4.2. However, we may want to
throw an exception if we can not fulfill a requested QoS. If the user is
expecting that the hypervisor will provide a particular QoS, and that is
not possible, it seems like we should inform them rather than silently
Alternatively, we could always add a new table, storage_features. It could
contain three columns: Our typical ID column, a foreign key that maps back
to the storage_pool table, and a column for the feature's name (this string
would map to an enumeration in the codebase).
Ex.
storage_pool
ID
Mike,
Please see my comments in-line below.
Thanks,
-John
On Jun 13, 2013, at 6:09 PM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
Comments below in red.
Thanks
On Thu, Jun 13, 2013 at 3:58 PM, John Burwell jburw...@basho.com wrote:
Mike,
Overall, I agree with the steps
Folks
It seems that we do not use In Progress status in JIRA as often as we should.
Issues seem to change from Open to Resolved directly. IMHO marking an issue
In Progress provides much better visibility and helps communicate to
community that you are working on that item.
If for whatever
How about CLOUDSTACK-2337: [UI] Resize Volume option is enabled only for
ROOT Admin?
The affected version says 4.2.0, but I experienced the same UI bug in the
4.1.0 release, as well.
According to Pranav's comments, I have made a fix from the UI side the
better fix would be to fix it in the API as
-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Thursday, June 13, 2013 10:55 AM
To: dev@cloudstack.apache.org
Subject: Re: Object_Store storage refactor Meeting Notes
On Thu, Jun 13, 2013 at 05:52:01PM +, Animesh Chaturvedi wrote:
Yeah, I'm not sure I could come up with anything near an accurate
assessment of how many IOPS are currently available on the SAN (or even a
total number that are available for volumes). Not sure if there's yet an
API call for that.
If I did know this number (total number of IOPS supported by the
I will be off next week and will have very limited access to email.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11650/#review21897
---
Commit 18163eaa4d3f3eac0a8de9fc6b87224e22c84914 in branch
I had submitted the patch to the script which is making into systemvm.iso.
If the other script is not used, we can delete it to avoid confusion in future.
-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Thursday, June 13, 2013 11:16 PM
To:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11052/#review21898
---
server/src/com/cloud/template/HypervisorTemplateAdapter.java
94 matches
Mail list logo
