Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

2013-07-27 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/ --- Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs:

Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: 3874 Repository:

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/#review24014 --- Review 12993 PASSED the build test The url of build

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

2013-07-27 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/#review24015 --- Ship it! Ship It! - Abhinandan Prateek On July 27, 2013, 8:48

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/#review24016 --- Commit 65e12e1dadde0512ea1ebf51549bf6ab73c78818 in branch

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/#review24017 --- Commit f33c887b0327f820429230654c040e45af2c651a in branch

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/#review24018 --- Ship it! Ship It! - Abhinandan Prateek On July 27, 2013, 8:55

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/#review24019 --- Commit a10861a57b1a0df11c80dbd04bd02cc2772de2f4 in branch

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/#review24020 --- Commit 6403bb339d45b0a5fd0b2aa7aa59ec312c6ba2dd in branch

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/#review24021 --- Review 12992 PASSED the build test The url of build

Re: [DISCUSS] maven dependencies...

2013-07-27 Thread Daan Hoogland
ship it;) On Sat, Jul 27, 2013 at 12:09 AM, Alex Huang alex.hu...@citrix.com wrote: Everyone, After looking around in the maven documentation, I realized the way we are specifying dependencies is not quite right for a large project such as ours. Currently, almost every project declare

RE: [DISCUSS] vlan uri format change

2013-07-27 Thread Koushik Das
I raised this in a separate thread. Daan created a new patch https://reviews.apache.org/r/12849/ to address backward compat. -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Saturday, July 27, 2013 11:12 AM To: dev@cloudstack.apache.org Subject: Re:

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-07-27 Thread daan Hoogland
On July 23, 2013, 12:30 p.m., Koushik Das wrote: api/src/com/cloud/network/Networks.java, line 225 https://reviews.apache.org/r/12849/diff/1/?file=325398#file325398line225 Why only Vlan in case of IsolationType and Vlan, Storage and Mido in the case of BroadcastDomainType?

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-27 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/#review24022 --- Patch failed to apply on 4.2. Please update the patch - Jayapal

Re: Review Request 12928: update midterm review

2013-07-27 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/ --- (Updated July 27, 2013, 10:57 a.m.) Review request for cloudstack, Abhinandan

Re: [DISCUSS] Compatibility issue between network plugins and hypervisors

2013-07-27 Thread Daan Hoogland
H, isn't it the responsibility of the administrator to setup the cloud in a proper way? hypervisor and network implementations may enhance their capabilities at minor upgrades so it will not be easy to keep checks on this up to date in cloudstack. Am I missing the point here? regards, Daan On

Re: Review Request 12985: CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM

2013-07-27 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12985/#review24023 --- this is a duplicate of https://reviews.apache.org/r/12849/ please

rejected mail by dev.apache.org

2013-07-27 Thread Daan Hoogland
Hello, I replied to a message a minute ago and got quote Delivery to the following recipient failed permanently: dev@cloudstack.apache.org Technical details of permanent failure: Google tried to deliver your message, but it was rejected by the server for the recipient domain

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
On July 26, 2013, 5:38 p.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230 https://reviews.apache.org/r/12968/diff/1/?file=328266#file328266line230 I don't understand why you need to do a bunch of search here. This method is invoked when a

Re: Unable to get the management server node id

2013-07-27 Thread Ian Duffy
Great thanks Alax. Much neater than my work around of commenting out code. On 27 July 2013 03:53, Alex Huang alex.hu...@citrix.com wrote: Ian, Assuming you're on master, I just checked in a bunch of changes yesterday that included this one item. Every code now retrieves the management

Re: rejected mail by dev.apache.org

2013-07-27 Thread Daan Hoogland
thanks, i cp'd a link from another mail, big sin of course. On Sat, Jul 27, 2013 at 1:23 PM, Ian Duffy i...@ianduffy.ie wrote: Just check your not sending emails in HTML. They get rejected unless they are plain text :-) On 27 July 2013 12:21, Daan Hoogland daan.hoogl...@gmail.com wrote:

Re: [DISCUSS] vlan uri format change

2013-07-27 Thread Daan Hoogland
The original patch was committed under Alex' account. Work on the networks enums is far from done with https://reviews.apache.org/r/12849/. I commented on the one you are mentioning, Prasanna. regards, Daan On Sat, Jul 27, 2013 at 12:41 PM, Koushik Das koushik@citrix.com wrote: I raised

Re: Review Request 12928: update midterm review

2013-07-27 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/#review24025 --- Put the xml as patch. Mail me the images. I am still getting some

Re: Review Request 12928: update midterm review

2013-07-27 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/ --- (Updated July 27, 2013, 11:56 a.m.) Review request for cloudstack, Abhinandan

Do we delete an account after all users are deleted?

2013-07-27 Thread Sowmya Krishnan
Do we perform any cleanup of an account if all users in that account are deleted? I don't find that is the current behavior. I was going through test_accounts.py and figured that's one of the tests. Here's the description of that test: # Validate the following # 1. Remove both the

Review Request 12995: [GSoC] Add midterm report to docs

2013-07-27 Thread Shiva Teja Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12995/ --- Review request for cloudstack and Sebastien Goasguen. Repository:

Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated

2013-07-27 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/ --- Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo

Re: Review Request 12995: [GSoC] Add midterm report to docs

2013-07-27 Thread Shiva Teja Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12995/ --- (Updated July 27, 2013, 1:11 p.m.) Review request for cloudstack and Sebastien

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

2013-07-27 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/#review24026 --- Ship it! Here's how I tested this: Reverted Sheng's revert which

Re: Review Request 11626: Automation: Memory limits tests from Resource Limits Tests

2013-07-27 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/ --- (Updated July 27, 2013, 1:21 p.m.) Review request for cloudstack, sailaja

Re: Do we delete an account after all users are deleted?

2013-07-27 Thread Prasanna Santhanam
On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote: Do we perform any cleanup of an account if all users in that account are deleted? I don't find that is the current behavior. I was going through test_accounts.py and figured that's one of the tests. Here's the description of

RE: Do we delete an account after all users are deleted?

2013-07-27 Thread Sowmya Krishnan
-Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Saturday, July 27, 2013 6:55 PM To: dev@cloudstack.apache.org Subject: Re: Do we delete an account after all users are deleted? On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote: Do we

RE: Do we delete an account after all users are deleted?

2013-07-27 Thread Sowmya Krishnan
-Original Message- From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com] Sent: Saturday, July 27, 2013 7:05 PM To: dev@cloudstack.apache.org Subject: RE: Do we delete an account after all users are deleted? -Original Message- From: Prasanna Santhanam

Re: Do we delete an account after all users are deleted?

2013-07-27 Thread Prasanna Santhanam
On Sat, Jul 27, 2013 at 01:34:25PM +, Sowmya Krishnan wrote: -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Saturday, July 27, 2013 6:55 PM To: dev@cloudstack.apache.org Subject: Re: Do we delete an account after all users are deleted? On

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/#review24027 --- Commit a8ad908666b963bfd152b508fcec7259cf3a545f in branch

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-27 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/#review24029 --- Ship it! commit b21de4006abd61512b027af2dd9e8b07df1dd06f - Kishan

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/#review24028 --- Commit b21de4006abd61512b027af2dd9e8b07df1dd06f in branch

Review Request 12997: usage event is not generated for volume resize

2013-07-27 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12997/ --- Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.

RE: Do we delete an account after all users are deleted?

2013-07-27 Thread Sowmya Krishnan
That's the behavior right now - we don't delete the account if users are all deleted. So we just need the test script to be removed/altered which is testing the other way. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Saturday, July 27, 2013 8:38 PM To:

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Min Chen
On July 26, 2013, 5:38 p.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230 https://reviews.apache.org/r/12968/diff/1/?file=328266#file328266line230 I don't understand why you need to do a bunch of search here. This method is invoked when a

RE: Dev Help: How to create scheduled tasks in ACS

2013-07-27 Thread Alex Huang
Hi Ian, You might want to develop against vmsync branch for now, if you don't mind. We intend to bring the job queue work there over to master. I've been bringing vmsync over piece meal to master but haven't gotten to the job part yet. In the vmsync branch, what you'll find is that we've

[GSOC][Urgent] Build docbook failed

2013-07-27 Thread Nguyen Anh Tu
Hi guys, I build my GSoC mid-term review and get an error here: Validation failed: CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist content does not follow the DTD, expecting (blockinfo? , (title , titleabbrev?)? , (caution | important | note | tip | warning | literallayout |

Re: [GSOC][Urgent] Build docbook failed

2013-07-27 Thread Shiva Teja
Hi, Can you send the paste it somewhere and give a link? I can try. On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: Hi guys, I build my GSoC mid-term review and get an error here: Validation failed: CloudStack_GSoC_Guide.xml:67: validity error : Element

Re: [GSOC][Urgent] Build docbook failed

2013-07-27 Thread Shiva Teja
Oops, *paste it somewhere On Sat, Jul 27, 2013 at 10:06 PM, Shiva Teja shivate...@gmail.com wrote: Hi, Can you send the paste it somewhere and give a link? I can try. On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: Hi guys, I build my GSoC mid-term review and

Re: [GSOC][Urgent] Build docbook failed

2013-07-27 Thread Nguyen Anh Tu
Hi Shiva, I send to you my report. Please try build it. Thanks 2013/7/27 Shiva Teja shivate...@gmail.com Oops, *paste it somewhere On Sat, Jul 27, 2013 at 10:06 PM, Shiva Teja shivate...@gmail.com wrote: Hi, Can you send the paste it somewhere and give a link? I can try. On

Re: Review Request 12997: usage event is not generated for volume resize

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12997/#review24031 --- Review 12997 failed the build test : FAILURE The url of build

Re: [GSOC][Urgent] Build docbook failed

2013-07-27 Thread Nguyen Anh Tu
Yeah it worked. Thanks Shiva! 2013/7/28 Shiva Teja shivate...@gmail.com Change the itemizedlist in the id=Spring to this itemizedlist listitem paracomponents are declared as beans in componentcontext.xml and applicationcontext.xml/para mediaobject

Re: Review Request 12996: Unable to Resize Volume (kvm, vmware)

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12996/#review24034 --- Review 12996 PASSED the build test The url of build

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

2013-07-27 Thread Wido den Hollander
+1 (binding) I've upgraded a couple of internal systems and even production systems to 4.1.1 We were facing a couple of bugs in production which lead me to deploy a homebrew version of 4.1.1 in our company. The only change is a very small change in the security groups script for something

Re: Review Request 12658: Corrected typos in log messages

2013-07-27 Thread Wido den Hollander
On 07/26/2013 11:41 PM, Animesh Chaturvedi wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12658/ On July 18th, 2013, 9:48 a.m. UTC, *Wido den Hollander* wrote: Ship It! Wido did you commit the patch? If so this needs to be closed

Re: Dev Help: How to create scheduled tasks in ACS

2013-07-27 Thread Ian Duffy
Hi Alex, Will definitely look into it. These messages were just for research purposes, not looking to implement it for another month. Thanks, Ian On 27 July 2013 16:30, Alex Huang alex.hu...@citrix.com wrote: Hi Ian, You might want to develop against vmsync branch for now, if you don't mind.

RE: Review Request 12658: Corrected typos in log messages

2013-07-27 Thread Animesh Chaturvedi
The submitter should close it out once the patch is approved and checked-in. The reviewer cannot close the patch unless they have admin privileges. If you want admin privileges you can open a ticket with Infra. -Original Message- From: Wido den Hollander [mailto:w...@widodh.nl] Sent:

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

2013-07-27 Thread Ove Ewerlid
-1 Details; https://issues.apache.org/jira/browse/CLOUDSTACK-3880 RHEL6 specific; risk for database corruption if MGR is shutdown via anything that changes runlevel resulting in use of cloudstack-management, cloudstack-usage stop() targets (e.g., /sbin/shutdown, telinit 1, ACPID initiated

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24036 --- server/src/com/cloud/template/HypervisorTemplateAdapter.java

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- (Updated July 27, 2013, 6:58 p.m.) Review request for cloudstack and Min Chen.

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
On July 26, 2013, 11:51 p.m., Alena Prokharchyk wrote: We can't just remove the row w/o making sure its not being referenced by existing resources. So putting DELETE IGNORE FROM `cloud`.`guest_os` where id=206 is not enough. You can go 2 ways: #1 - don't insert the record to the DB

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated July 27, 2013, 7:21 p.m.) Review request for cloudstack, Alena

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated July 27, 2013, 7:22 p.m.) Review request for cloudstack, Alena

Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

2013-07-27 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/ --- Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.

Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review24039 --- Review 13001 PASSED the build test The url of build

Review Request 13003: Adding packaging support for RHEL 5 and 6.2

2013-07-27 Thread Rayees Namathponnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13003/ --- Review request for cloudstack, edison su, Frank Zhang, Hugo Trippaers, and Wido

RE: CloudStack 4.2 – Build and Packaging on RHEL 5.4

2013-07-27 Thread Rayees Namathponnan
Submitted patch to support RHEL 5 and 6.2 packaging; someone please review this ? https://reviews.apache.org/r/13003/ Also I think we can change the packaging folder name form cloudstack/packaging/centos63 to cloudstack/packaging/centos; after the merge. Regards, Rayees -Original

Re: Review Request 13003: Adding packaging support for RHEL 5 and 6.2

2013-07-27 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13003/#review24047 --- Review 13003 PASSED the build test The url of build

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24049 --- server/src/com/cloud/template/HypervisorTemplateAdapter.java

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

2013-07-27 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/ --- (Updated July 28, 2013, 4:39 a.m.) Review request for cloudstack, Prasanna

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command

2013-07-27 Thread Abhinandan Prateek
On July 24, 2013, 10:56 p.m., Alena Prokharchyk wrote: 1) Bharat, can you please check if your API allows you to set the vnet range with the multiple ranges. The command syntax should be like this - vnets should be specified and separated by comma: