Re: [VOTE] Apache CloudStack 4.3.0 (third round)

2014-02-07 Thread Srikanteswararao Talluri
Sure Hugo, I will enable assertions for the next run. Thanks, ~Talluri On 06/02/14 12:55 am, Hugo Trippaers trip...@gmail.com wrote: Talluri, Is it possible to enable assertions in the functional tests (-ae flag on the jvm). That way we get some feedback on the internal issues. I'm seeing some

Re: User UI, ACL configuration

2014-02-07 Thread sebgoa
On Feb 6, 2014, at 11:53 PM, d...@soleks.com wrote: it's 4.2.1 bug ? Dan, definitely. It may also apply to 4.3, so please tag both thanks On Feb 6, 2014, at 3:31 PM, d...@soleks.com wrote: Hi @dev, There is some minor issue with UI, i think it's controlled by some

RE: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Animesh Chaturvedi
-Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, February 06, 2014 9:56 PM To: Alena Prokharchyk Cc: dev@cloudstack.apache.org; eiz...@infoblox.com Subject: Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal second

Re: Code quality, QA, etc

2014-02-07 Thread Hugo Trippaers
Hey David, I would make a distinction between code issues and functional issues. Occasionally somebody just plainly breaks the build, i’m guilty of that myself actually, and thats just plain stupid. Luckily we have Jenkins to catch these errors quickly. I’m in a continuous struggle with

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread murali reddy
On Fri, Feb 7, 2014 at 11:34 AM, Daan Hoogland daan.hoogl...@gmail.comwrote: Alena, The revert didn't apply. Would the folowing do the trick? if (vm.getType() == Type.User network.getTrafficType() == TrafficType.Guest network.getGuestType() ==

Re: Removing deploy\load options from marvinplugin

2014-02-07 Thread Prasanna Santhanam
On Fri, Feb 07, 2014 at 07:25:03AM +, Santhosh Edukulla wrote: 1. code restructuring ,definitely yes, it makes little neat and plugin does not worry much about deploy altogether. Take an example of load option, it is little redundant i believe, if user passes the deploy flag, deploy

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-07 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review33921 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-07 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- (Updated Feb. 7, 2014, 9:26 a.m.) Review request for cloudstack, John Burwell

Re: Review Request 15932: Add support for Primary Storage on Gluster using the libvirt backend

2014-02-07 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15932/#review33922 --- My sincere apologies Niels! I completely missed the second version

RE: Removing deploy\load options from marvinplugin

2014-02-07 Thread Santhosh Edukulla
CIL From: Prasanna Santhanam [t...@apache.org] Sent: Friday, February 07, 2014 4:18 AM To: dev@cloudstack.apache.org Subject: Re: Removing deploy\load options from marvinplugin On Fri, Feb 07, 2014 at 07:25:03AM +, Santhosh Edukulla wrote: 1. code

Review Request 17840: Patch [master] CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-07 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17840/ --- Review request for cloudstack, John Burwell and Murali Reddy. Bugs:

Re: Removing deploy\load options from marvinplugin

2014-02-07 Thread Prasanna Santhanam
On Fri, Feb 07, 2014 at 09:36:49AM +, Santhosh Edukulla wrote: From: Prasanna Santhanam [t...@apache.org] Sent: Friday, February 07, 2014 4:18 AM To: dev@cloudstack.apache.org Subject: Re: Removing deploy\load options from marvinplugin On Fri, Feb 07, 2014 at 07:25:03AM +, Santhosh

Re: Review Request 15932: Add support for Primary Storage on Gluster using the libvirt backend

2014-02-07 Thread Niels de Vos
On Feb. 7, 2014, 10:33 a.m., Wido den Hollander wrote: My sincere apologies Niels! I completely missed the second version of your patch! I just took a look at it again and it seems pretty straight forward. Most of the RBD code did a lot of work for you, so it's fairly easy to have

Re: Review Request 16385: Fix for CloudStack JIRA 4406

2014-02-07 Thread Mandar Barve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16385/ --- (Updated Feb. 7, 2014, 10:30 a.m.) Review request for cloudstack and daan

[DISCUSS]null pointer returned from daoimpl

2014-02-07 Thread Daan Hoogland
LS, in PrivateIpDaoImpl a null pointer is returned when no db object can be found: @Override public PrivateIpVO allocateIpAddress(long dcId, long networkId, String requestedIp) { ... PrivateIpVO vo = lockOneRandomRow(sc, true); if (vo == null) {

Re: Review Request 16385: Fix for CloudStack JIRA 4406

2014-02-07 Thread Mandar Barve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16385/ --- (Updated Feb. 7, 2014, 10:30 a.m.) Review request for cloudstack and daan

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Daan Hoogland
thanks Murali, will do On Fri, Feb 7, 2014 at 9:58 AM, murali reddy muralimmre...@gmail.com wrote: On Fri, Feb 7, 2014 at 11:34 AM, Daan Hoogland daan.hoogl...@gmail.comwrote: Alena, The revert didn't apply. Would the folowing do the trick? if (vm.getType() == Type.User

Review Request 17841: CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases

2014-02-07 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17841/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5959

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Daan Hoogland
I discussed with Antonio internally; we are in diagreement. I would like to see some kind of context diagram inside java class javadocs. Antonio would go for a seperate file (on package level, Antonio?) any others have brain waves on this? On Thu, Feb 6, 2014 at 2:11 PM, Jayapal Reddy Uradi

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Daan Hoogland
ignore, i will resend in the right thread On Fri, Feb 7, 2014 at 11:58 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: I discussed with Antonio internally; we are in diagreement. I would like to see some kind of context diagram inside java class javadocs. Antonio would go for a seperate file

Re: PlantUML

2014-02-07 Thread Daan Hoogland
I discussed with Antonio internally; we are in diagreement. I would like to see some kind of context diagram inside java class javadocs. Antonio would go for a seperate file (on package level, Antonio?) any others have brain waves on this? On Thu, Feb 6, 2014 at 2:03 PM, Antonio Fornié

systemvm-4.3.0.iso

2014-02-07 Thread Paul Angus
Have any changes been made to the deployment of the systemvm-4.3.0.iso between RC2 and RC3 ?? I can't get a system VMs to fully start in hyperv or xenserver - all issues seem to relate to the systemvm-4.3.0.iso - which doesn't seem to be making across to primary storage in hyper-v or properly

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Daan Hoogland
Hope this is not blocking at the moment so I can take the time to add a unit test. If not I have the code ready to ship. please bug me. On Fri, Feb 7, 2014 at 11:32 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: thanks Murali, will do On Fri, Feb 7, 2014 at 9:58 AM, murali reddy

RE: systemvm-4.3.0.iso

2014-02-07 Thread Devdeep Singh
Hi Paul, For hyper-v, if older systemvm iso is present with the same name then it'll not get updated. You can remove the systemvm directory from secondary storage. Also on you hyper-v host, systemvm.iso gets put on RootDrive:\Users\Public\Documents\Hyper-V directory. You can delete it. When a

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/ --- (Updated Feb. 7, 2014, 11:19 a.m.) Review request for cloudstack, Abhinandan

Review Request 17842: fixed vmsync for hyperv

2014-02-07 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17842/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs:

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33924 --- Ship it! Ship It! - Kishan Kavala On Feb. 7, 2014, 4:49 p.m.,

RE: systemvm-4.3.0.iso

2014-02-07 Thread Paul Angus
Thanks for the info Devdeep, so yes the systemvm iso is getting copied to the local disk, but I'm getting the following error: ERROR HypervResource.HypervResourceController [6b05182a-efa1-4105-bc5c-0a49c55674f0] - com.cloud.agent.api.StartCommand fail on exceptionObject reference not set to

Portable IP - Network rules failure

2014-02-07 Thread Gaurav Aradhye
Hi all, Firewall rule creation and Enabling static NAT rule for Portable public IP are failing, and is observed in daily build too. It was masked by other cascading failures for which I have already added patch ( https://reviews.apache.org/r/17841/). I have observed these issues on VMware yet

RE: Removing deploy\load options from marvinplugin

2014-02-07 Thread Santhosh Edukulla
I believe we are deviating with too many notes here. Lets put things in perspective. 1. Initial point was to understand and take inputs to have and work with marvinplugin using less options for running, minimize options we have currently and can we remove few and work with them? and i believe

RE: Not able to add primary Storage Cloudstack 4.3

2014-02-07 Thread Paul Angus
Tejas, Check out the dev list I've just posted an issue with the system vms not starting - you might be having the same issue. check the agent log for: ERROR HypervResource.HypervResourceController [6b05182a-efa1-4105-bc5c-0a49c55674f0] - com.cloud.agent.api.StartCommand fail on

Source build failing in DevCloud

2014-02-07 Thread CK
Hi, This is my first attempt at building CloudStack from the source code and decided on using DevCloud. I followed the wiki for using DevCloud https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud. I want to build the 4.3 release and used the updated DevCloud 2.0 appliance and as per

Re: Removing deploy\load options from marvinplugin

2014-02-07 Thread Prasanna Santhanam
tl;dr i think your point 4 clarifies your change. remove --load and only run tests unless --deploy is given. in the latter - do a deploy. On Fri, Feb 07, 2014 at 11:30:19AM +, Santhosh Edukulla wrote: I believe we are deviating with too many notes here. Lets put things in perspective.

RE: Source build failing in DevCloud

2014-02-07 Thread Alex Hitchins
I've had a quick look at the error statements - what version of Java is on the devcloud vm? Also, if you checkout the 4.3 branch, git pull then compile you should get the 4.3 current build. Regards Alex Hitchins D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

RE: Code quality, QA, etc

2014-02-07 Thread Sudha Ponnaganti
+1 for pre- commit testing. Whichever tool enforces it would be good choice. For feature check in, we ( community) require sanity tests to be submitted by feature owners and this was followed well in 4.0 release but there is lapse in this practice now. This would be a great if RM can enforce

RE: Source build failing in DevCloud

2014-02-07 Thread Suresh Sadhu
What is the output of java -version . Try after installing Java c 1.7 .It might resolve this issue. Regards Sadhu -Original Message- From: CK [mailto:cloudw...@gmail.com] Sent: 07 February 2014 17:11 To: dev@cloudstack.apache.org Subject: Source build failing in DevCloud Hi,

Re: Not able to add primary Storage Cloudstack 4.3

2014-02-07 Thread Tejas Gadaria
Hi Rajesh, Thanks for providing API. I have successfully attached primary storage to cloudstack. I am facing problem with SSVM and CPVM also, probably I will initiate new mail-trail ssytem vm issues. Reards, Tejas On Thu, Feb 6, 2014 at 12:27 PM, Rajesh Battala

Re: Source build failing in DevCloud

2014-02-07 Thread CK
Java version is: javac 1.6.0_24 I'm new to 'git', how do I ...checkout the 4.3 branch, git pull then compile you should get the 4.3 current build., can you provide the commands? Thanks On 7 February 2014 12:00, Alex Hitchins alex.hitch...@shapeblue.com wrote: I've had a quick look at the

RE: systemvm-4.3.0.iso

2014-02-07 Thread Devdeep Singh
Hi Paul, Looks like you are using untagged vlan in your setup. There was a bug in agent code with respect to that. Rajesh made a fix for it in commit-id 7df148c762510f669b60edff9d8d690c800b1f95 few days back. This fix should address the problem. Regards, Devdeep -Original Message-

RE: Source build failing in DevCloud

2014-02-07 Thread Alex Hitchins
I haven't used devcloud in a while - this link might prove useful to you. http://cloudstack.apache.org/developers.html After the clone is complete, you can git checkout 4.3 then git pull to ensure it's updated. The link gives you the steps to get your first commit done. Welcome to the group!

RE: Source build failing in DevCloud

2014-02-07 Thread Alex Hitchins
Also, I think that Java version might be old - where did you get the devcloud image from? Regards Alex Hitchins D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969 alex.hitch...@shapeblue.com -Original Message- From: CK [mailto:cloudw...@gmail.com] Sent: 07 February 2014

[DISCUSS]atomic unit tests

2014-02-07 Thread Daan Hoogland
LS, I had a discussion on uniq paths and unit tests yesterday night with our new colleague Miguel about the unit tests that we have in Cloudstack at the moment. He pointed me to a common smell that I overlooked so far in Cloudstack. A lot of times unit tests are organised as folows: class test{

Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

2014-02-07 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17843/ --- Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.

Review Request 17844: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1.

2014-02-07 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17844/ --- Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.

Re: Not able to add primary Storage Cloudstack 4.3

2014-02-07 Thread Tejas Gadaria
Hi Paul, I have just join dev-list. So didn't received your mail but I show your mail in mail-archive. I think I am not using latest system templete iso. I have downloaded system vm template from http://download.cloud.com/templates/4.3/systemvm64template-2013-12-23-hyperv.vhd.bz2 please suggest

RE: systemvm-4.3.0.iso

2014-02-07 Thread Paul Angus
Thanks Devdeep, @Animesh, can we make sure the patch gets into the next RC please. Many thanks Paul. Regards, Paul Angus Cloud Architect S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Devdeep Singh

Review Request 17847: CLOUDSTACK-5978: Changes in get_template function to make it independent of ostype passed through test case

2014-02-07 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17847/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5978

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33928 ---

Re: Code quality, QA, etc

2014-02-07 Thread Mike Tutkowski
I would love to see pre-commit testing such as what Hugo described. At the time being, I tend to mvn -P developer,systemvm clean install to make sure I have a clean build and run whatever tests it runs, then I run my own suite of tests manually (I'd like to automated these when I have time), then

BUG report: Excessive use of LVM snapshots on XenServer, that leads to snapshot failure and unnecessary disk usage.

2014-02-07 Thread France
Hi guys, is there a chance that someone looks at my bug report, to check if it does make sense? https://issues.apache.org/jira/browse/CLOUDSTACK-6060 I've also noticed that my older bug reports form half a year ago, have had no status update. Is this normal and expected? Is it possible that

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Chiradeep Vittal
+1. Any UI changes? On 2/6/14 5:11 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Hi, Multiple ips per nic feature allows user to acquire more ip address on vm nic. On these ip addresses user able to configure PF and static NAT. With this feature user can also configure the

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Min Chen
Hi Koushik, I agree with the idea of supporting multiple IDs. But I may not like the idea of introducing another different query parameter ids for this purpose. Why cannot we just change current id parameter to take a list of values? This way, user will not need to use two different

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Alena Prokharchyk
Daan, 1) What is the reason you execute this code snippet just for Shared networks? 2) As I suggested in my prev email, before retrieving Dhcpprovider, you should check if dhcp service is enabled on the network. Use method areServicesSupportedInNetwork From NetworkModel to check that. -Alena.

DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Nux!
Just tested this today, it happens consistently in my setup. Opened https://issues.apache.org/jira/browse/CLOUDSTACK-6061 with plenty of details. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Daan Hoogland
H Alena, I am just trying to fix an old contribution that I applied as it seemed not to harm in a basic test. revert didn't work so I am looking for a quick remedy. The original patch does it for shared only. I don't care either way. Lets do the best thing. the code now if (vm.getType()

RE: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Alex Huang
+1 It's confusing to have id and ids all over the place. We should just say all ids can come in arrays by default. --Alex -Original Message- From: Min Chen [mailto:min.c...@citrix.com] Sent: Friday, February 7, 2014 9:56 AM To: dev@cloudstack.apache.org Subject: Re: [PROPOSAL]

Re: Source build failing in DevCloud

2014-02-07 Thread chris snow
Hi Suresh, If you struggle to make progress, you could take a look at https://github.com/snowch/devcloud I'm hoping that this environment will be a replacement for devcloud2. It also checks out 4.3 and builds it. Please report any bugs on the github issue tracker. Many thanks, Chris On

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Alena Prokharchyk
Daan, Here is how it should look: //1) Make all the checks that used to exist in original code + if DHCP service is enabled on the network if (vm.getType() == Type.User network.getTrafficType() == TrafficType.Guest isLastNicInSubnet(nic) network.getGuestType() == GuestType.Shared

RE: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Prachi Damle
Yes, agree to this as well. Accordingly we need to handle the getEntityOwnerId() dependency. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Friday, February 07, 2014 10:06 AM To: dev@cloudstack.apache.org Subject: RE: [PROPOSAL] List VM API enhancement +1 It's

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Animesh Chaturvedi
Alena do you mind checking into this issue? Animesh -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Friday, February 07, 2014 10:00 AM To: dev@cloudstack.apache.org Subject: DB upgrade 4.2.1 - 4.3 fails Just tested this today, it happens consistently in my setup.

Re: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Alena Prokharchyk
Updated the bug. Most likely happened because the upgrade was performed twice (failed the first time, and the person doing the upgrade,didn¹t do the rollback). See more details in the bug. -Alena. On 2/7/14, 10:48 AM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Alena do you mind

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Animesh Chaturvedi
Nux you had a similar issue for previous RC https://issues.apache.org/jira/browse/CLOUDSTACK-5902 which was resolved as not a problem -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, February 07, 2014 10:49 AM To:

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Koushik Das
Good point Min. I also thought about it but looking at some of the existing APIs thought of keeping both. For e.g. in deploy VM api there is a parameter called 'networkids' which can take an array of network IDs. Note that the naming convention of ending in 's'. Now by this logic we should

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Alena Prokharchyk
We can just agree from now on to use the ³id for handling multiple ids. And of course, we can never delete the ³ID² parameter just to satisfy the old convention, as this is the most used parameter :) I can see that several existing commands - archive/deleteAlerts are using ApiConstants.IDs

Re: Code quality, QA, etc

2014-02-07 Thread Yoshikazu Nojima
+1 for pre-commit testing. I put pre-commit testing in practice personally, and it helped me a lot. Before I submit a patch, I create a pull request in my github repo. My Jenkins subscribes pull requests by Jenkins plugin for Github and the build result is displayed in Github. I heard there are

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Koushik Das
I looked at BaseListCmd.java and see the following. Prachi, Are you referring to this or anything else? public long getEntityOwnerId() { // no owner is needed for list command return 0; } On 08-Feb-2014, at 12:02 AM, Prachi Damle

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Nux!
On 07.02.2014 19:01, Animesh Chaturvedi wrote: Nux you had a similar issue for previous RC https://issues.apache.org/jira/browse/CLOUDSTACK-5902 which was resolved as not a problem I know, but this time it's persistent. I think it may be related to the installation of the new system template.

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Sheng Yang
+1. Looks fine to me. I think there are should be some UI changes, allow to choose multiple IPs if VM has more than one IP in this network. --Sheng On Fri, Feb 7, 2014 at 9:55 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: +1. Any UI changes? On 2/6/14 5:11 AM, Jayapal Reddy

Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal

2014-02-07 Thread Daan Hoogland
sure, will try to find a spot asap. and write unit tests to simulate those two situations. On Fri, Feb 7, 2014 at 7:20 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: Daan, Here is how it should look: //1) Make all the checks that used to exist in original code + if DHCP service

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
Hey Daan, I guess you are talking about your fix submitted in master [1]. You might want to see Hari's latest patch [2] as well. It solves the following two things which I guess your fix misses. 1. It sets the vcpu max to a hardcoded value (say 16) only when dynamic scaling is enabled. Do note

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Nux!
On 07.02.2014 19:47, Animesh Chaturvedi wrote: Did you review Alena's response? Of course, check the issue https://issues.apache.org/jira/browse/CLOUDSTACK-6061 -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Animesh Chaturvedi
Alena can you review the comment from Nux in bug -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Friday, February 07, 2014 11:52 AM To: dev@cloudstack.apache.org Subject: RE: DB upgrade 4.2.1 - 4.3 fails On 07.02.2014 19:47, Animesh Chaturvedi wrote: Did you review

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
Can I have the patch applied in 4.3-forward? -Original Message- From: Nitin Mehta [mailto:nitin.me...@citrix.com] Sent: Friday, February 07, 2014 11:33 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Animesh Chaturvedi
Did you review Alena's response? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Friday, February 07, 2014 11:28 AM To: dev@cloudstack.apache.org Subject: RE: DB upgrade 4.2.1 - 4.3 fails On 07.02.2014 19:01, Animesh Chaturvedi wrote: Nux you had a similar issue for

Re: [ANNOUNCE] New PMC Member: Mike Tutkowski

2014-02-07 Thread Mike Tutkowski
Thanks, everyone! On Tue, Feb 4, 2014 at 9:06 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Congrats Mike!! Santhosh From: Ahmad Emneina [aemne...@gmail.com] Sent: Tuesday, February 04, 2014 10:45 PM To: dev@cloudstack.apache.org

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
-Original Message- From: Nitin Mehta [mailto:nitin.me...@citrix.com] Sent: Friday, February 07, 2014 11:33 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
On Feb. 7, 2014, 3:57 p.m., Nitin Mehta wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java, line 70 https://reviews.apache.org/r/17747/diff/2/?file=480018#file480018line70 Will the upgrade path get this config ?? Yes Nitin, after upgrade or fresh 4.3 setup

Re: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Alena Prokharchyk
See my reply to the bug. The new system vm template should be registered through CS API registerTemplate (and named like Install Guide requests), not by running template install script. Thanks! Alena. On 2/7/14, 11:51 AM, Nux! n...@li.nux.ro wrote: On 07.02.2014 19:47, Animesh Chaturvedi wrote:

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33959 --- Commit 95e41fdf0da50c165a9317847058fce4efeddbcf in branch

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
Animesh - done. Please cherry pick to 4.3 Daan - for pushing this to master I will have to revert your fix in master. On 07/02/14 11:48 AM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Can I have the patch applied in 4.3-forward? -Original Message- From: Nitin Mehta

RE: systemvm-4.3.0.iso

2014-02-07 Thread Animesh Chaturvedi
I have pulled it into next RC but for each fix going in 4.3-forward I want to see a matching bugId. -Original Message- From: Paul Angus [mailto:paul.an...@shapeblue.com] Sent: Friday, February 07, 2014 5:26 AM To: dev@cloudstack.apache.org Cc: Rajesh Battala; Animesh Chaturvedi

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
Here is the commit id on 4.3-forward commit 95e41fdf0da50c165a9317847058fce4efeddbcf -Harikrishna From: Nitin Mehta Sent: Saturday, February 08, 2014 2:46 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
Done applied to 4.3 -Original Message- From: Harikrishna Patnala Sent: Friday, February 07, 2014 1:31 PM To: Nitin Mehta; dev@cloudstack.apache.org Cc: Anthony Xu; Animesh Chaturvedi Subject: RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer

Re: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Nux!
On 07.02.2014 20:55, Alena Prokharchyk wrote: See my reply to the bug. The new system vm template should be registered through CS API registerTemplate (and named like Install Guide requests), not by running template install script. I have corrected that, but the upgrade still fails. Issue

Re: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Alena Prokharchyk
Nux, During the rollback, you just applied 4.2.1 db dump. That doesn¹t drop the tables that were inserted by partial 4.2.1­4.3 upgrade. Refer to my last comment to the bug for the rollback steps. Thanks, Alena. On 2/7/14, 1:36 PM, Nux! n...@li.nux.ro wrote: On 07.02.2014 20:55, Alena

[DOCS] update on move to rst

2014-02-07 Thread Sebastien Goasguen
Hi, A quick update on the move to .rst format. We now have four repos for the docs: git://git.apache.org/cloudstack-docs-rn.git git://git.apache.org/cloudstack-docs-admin.git git://git.apache.org/cloudstack-docs-install.git git://git.apache.org/cloudstack-docs.git All four are mirrored on

Re: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Nux!
On 07.02.2014 21:50, Alena Prokharchyk wrote: Nux, During the rollback, you just applied 4.2.1 db dump. That doesn¹t drop the tables that were inserted by partial 4.2.1­4.3 upgrade. Refer to my last comment to the bug for the rollback steps. Yes, that was it! On to more testing now,

Re: Review Request 17233: Fix for Issue CLOUDSTACK-5875

2014-02-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17233/#review33968 --- Commit c1af92fcbbc183873d6519f0660b68acfb33bd44 in branch

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33967 --- Commit 01289b1647db2b08d42c883452aae6ca7dda in branch

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Min Chen
Yes. -min Sent from my iPhone On Feb 7, 2014, at 11:10 AM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: We can just agree from now on to use the ³id for handling multiple ids. And of course, we can never delete the ³ID² parameter just to satisfy the old convention, as this is

Re: [DISCUSS]null pointer returned from daoimpl

2014-02-07 Thread Chiradeep Vittal
There is no good answer IMHO. The designer of the API chose this design. Throwing a checked exception or returning Null is equivalent. Throwing a runtime exception is probably wrong since there may be some recovery possible. We could annotate the method with @Nullable so that the compiler/IDE

RE: DB upgrade 4.2.1 - 4.3 fails

2014-02-07 Thread Animesh Chaturvedi
Ok so I am ready to roll with an RC. Thanks Nux, Alena -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Friday, February 07, 2014 2:09 PM To: dev@cloudstack.apache.org Subject: Re: DB upgrade 4.2.1 - 4.3 fails On 07.02.2014 21:50, Alena Prokharchyk wrote: Nux,

RE: [DOCS] update on move to rst

2014-02-07 Thread Animesh Chaturvedi
Cool -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Friday, February 07, 2014 2:02 PM To: dev@cloudstack.apache.org Subject: [DOCS] update on move to rst Hi, A quick update on the move to .rst format. We now have four repos for the docs:

Re: [DOCS] update on move to rst

2014-02-07 Thread Chiradeep Vittal
Visually so much nicer! On 2/7/14 2:58 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Cool -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Friday, February 07, 2014 2:02 PM To: dev@cloudstack.apache.org Subject: [DOCS] update on move to rst

Re: [PROPOSAL] Virtual Router aggregated execution

2014-02-07 Thread Chiradeep Vittal
+1. * The guideline is not clear as to when a developer should use this executor. Why not use it all the time (even for a single command) * Are there any issues when there are multiple management servers involved? * Any threading concerns? That is, multiple threads are attempting to update the

Re: Removing deploy\load options from marvinplugin

2014-02-07 Thread Chiradeep Vittal
Phew. Thanks for the tldr On 2/7/14 3:53 AM, Prasanna Santhanam t...@apache.org wrote: tl;dr i think your point 4 clarifies your change. remove --load and only run tests unless --deploy is given. in the latter - do a deploy. On Fri, Feb 07, 2014 at 11:30:19AM +, Santhosh Edukulla wrote:

Re: Code quality, QA, etc

2014-02-07 Thread Laszlo Hornyak
Hi, I used to work with gerrit in OS projects and I think the tool is great, the integration with jenkins is cool. One problem could be when jenkins infrastructure problems are frequent and developers start to ignore warnings from jenkins. With my particular project we were also frequently hit by

Re: [PROPOSAL] Virtual Router aggregated execution

2014-02-07 Thread Sheng Yang
Thanks for the comment! On Fri, Feb 7, 2014 at 3:25 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: +1. * The guideline is not clear as to when a developer should use this executor. Why not use it all the time (even for a single command) The mechanism behind is NOT a

[VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-07 Thread Animesh Chaturvedi
Hi All, I've created a 4.3.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3 Commit: c1af92fcbbc183873d6519f0660b68acfb33bd44 List of changes: Release notes are still in

devs looking to get involved?

2014-02-07 Thread Marcus
I occasionally have some minor improvement that I need to make to whatever version of cloudstack we're currently running. This is almost always behind what is currently being developed, and I don't always feel like I have time to rebase/refactor it for master. I'm wondering if there are any

  1   2   >