Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/582#issuecomment-122029800
LGTM :+1:
Can I merge it, @wido, or would you like to do it?
Cheers,
Wilder
---
If your project is set up for it, you can reply to
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/599#issuecomment-122030264
I checked all 5 Travis jobs and they failed due to timeout. Thus, it LGTM
:+1:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/595#issuecomment-121843873
I browsed the code and found out that this templateSize =
int(int(templates[0].size) / (1024**3)) was already been used in other places.
So, your changes
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/526#issuecomment-121848960
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121843328
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/526#issuecomment-121846745
@bhaisaab @DaanHoogland , could you also have a look at this one?
It LGTM
Cheers,
Wilder
---
If your project is set up for it, you can
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121849880
Hi @resmo and @bhaisaab
I will check with @remibergsma / @DaanHoogland / @snuf if that's something
we could get involved in. I'm okay with helping,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/590#issuecomment-121843137
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/555#issuecomment-121844265
Travis failed due to a timeout.
I will have a look at the code.
---
If your project is set up for it, you can reply to this email and have your
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121846292
hey @bhaisaab, still WIP. I ask for some help to finish it on the ML,
because I will not have time to work on it the next months.
---
If your project is set up for
We should stick to the 2 LGTM. No matter if that a bug fix or a new feature.
Currently we have PRs where 1 LGTM was given, but them the second reviewer
asked questions and raised concerns which were not answered accordingly. If the
1 LGTM would have been applied, all concernes would have been
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767146
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121921520
Hi @resmo
Can I then get your changes, from your PR, work on it and push via another
PR? Would that be okay with you?
If so, I think we
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34771180
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121914103
Hi @wilderrodrigues that would be awesome!
It is not supposed to break backward compatibility. In my opinion the
functionality is implemented and should work,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34770678
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/596
CLOUDSTACK-8641 - When calling update hostpassword API it throws NPâ¦
â¦E if the update_passwd_on_host if not informed
- On getUpdatePasswdOnHost() method, if
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/587#issuecomment-121928006
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/372#issuecomment-121889370
Hi @wido
I've been waiting for feedback from Pyr on a thread in the dev mailing list
with subject 4.6 if you want to look it up.
I will nevertheless do
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34769780
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34769880
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/540#issuecomment-121854348
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767521
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/540#issuecomment-121883348
This seems to me to be a solution for vmware for a more generic problem. in
the generic code conditions for hypervisortype == vmware are set while the
problem
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767845
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767796
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767004
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121928759
no comments on the code but cna you describe and add tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/555#discussion_r3447
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -697,6 +699,22 @@ private String
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121931545
@wilderrodrigues as long as you don't squash them and keep the attribution
intact, i'm fine with that. otherwise you can also make pull requests to
resmo's
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34786110
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
return false;
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/595#issuecomment-121929346
LGTM (we could decide to make this a generic macro type of construct so we
guarantee unified behavior. on the other hand this is not building a rocket...)
---
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/598
CLOUDSTACK-8642: SSO Method not allowed bug fix.
Due to CLOUDSTACK-8505 and commit 1c81b241e7914b24b06c3b7b3ee98bc0d3b4f68b
only POST methods are allowed. This needs to be explicitly stated
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121954927
LGTM
A test would be welcome indeed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121931572
@wilderrodrigues yes, please. Feel free.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/596#issuecomment-121932811
ltgm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 22-06-15 15:55, sebgoa wrote:
On Jun 22, 2015, at 2:55 PM, Rafael Fonseca rsafons...@gmail.com
wrote:
Hi Sebastien, thx for following up so quickly :)
It's because it's a big change that i think it should be done in
a major release an
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/597
Cloudstack 8642: Fix to use POST method instead of GET method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/596#issuecomment-121949123
LGTM, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121951761
LGTM
Seems like a use-case which was missed when this was changed
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121956704
makes sense, do we have a unit test mech on javascript code?
LGTM
---
If your project is set up for it, you can reply to this email and have your
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121966201
@wido any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121967055
LGTM.
who will merge it? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121967519
Working on a additional commit which brings in more logging and a unit test.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/599
coverity 1116668: try-with-resource on ds provided connection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/600
Coverity issues in OmniwireClassRegistry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack coverity-omniwire
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121981261
I should, mine was the second 'LGTM' but was hoping for some discussion on
javascript test code
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
See http://jenkins.buildacloud.org/job/build-4.5/500/changes
Changes:
[Rohit Yadav] CLOUDSTACK-8642: SSO Method not allowed bug fix. Due to
CLOUDSTACK-8505 and commit 1c81b241e7914b24b06c3b7b3ee98bc0d3b4f68b
--
[...truncated 3006 lines...]
[INFO]
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/600#issuecomment-122014762
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122015786
Travis failed due to NPE:
Tests in error:
KVMFencerTest.testWithFailingFence:135 » NullPointer
KVMFencerTest.testWithSingleHost:75 »
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122016035
Indeed, I noticed that to late. Fixing the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Wido,
We have an acute problem — Oracle will be issuing no further security patches
for Java7 which is a significant opsec risk. Put simply, we can’t leave our
users exposed to such a risk because Ubuntu won’t ship a release for an
non-EOL’ed Java version for another year. Personally, I
Hello,
My environment is cloudstack4.2.0+vmware5.0.I'm testing the upgrade process
from cloudstack4.2.0 to cloudstack 4.4.2 in this local envirionment.My
reference is the cloudstack-release-notes-4.4.2.I have successfully
completed the upgrade process.The cloudstack is running normally after i
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/572#discussion_r34861726
--- Diff:
engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
---
@@ -216,15 +223,82 @@ public boolean
60 matches
Mail list logo
