Re: nice read: squash

Nice reading! Le vendredi 17 juillet 2015, Daan Hoogland a écrit : > I adviced someone to squash a commit today, so to do penance i did > some reading [1]. I can't whole heartedly say I won't sin like this > again but I do feel better now;) > > > [1] > http://paul.stadig.name/2010/12/thou-shalt-

nice read: squash

I adviced someone to squash a commit today, so to do penance i did some reading [1]. I can't whole heartedly say I won't sin like this again but I do feel better now;) [1] http://paul.stadig.name/2010/12/thou-shalt-not-lie-git-rebase-ammend.html -- Daan

Re: Can we use components based on MIT License?

MIT is Cat A. Feel free to use, just comply with the LICENSE and NOTICE requirements. --David On Friday, July 10, 2015, Rohit Yadav wrote: > > On 16-Jun-2015, at 5:23 am, ilya wrote: > > General question, can we add/use components based on MIT License? > > > cc Sebastien/David - just to be su

Re: [MASTER] ID RSA pub too open and asking passprrase

Could you please ask him, Wido? I will look into it again tomorrow and get it fixed! Thanks for the reply! Cheers, Wilder Sent from my iPhone > On 17 Jul 2015, at 15:19, Wido den Hollander wrote: > > > >> On 17-07-15 13:53, Wilder Rodrigues wrote: >> Hi again, >> >> I just cleaned up the

[GitHub] cloudstack pull request: Fix securitygroups ingress FW for protoco...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/601#issuecomment-122313669 @remibergsma @NuxRo &others can you review this? @franklouwers this is one of the rare cases I think squashing makes sense ;) --- If your project is set up

[GitHub] cloudstack pull request: Fix securitygroups ingress FW for protoco...

Github user franklouwers commented on the pull request: https://github.com/apache/cloudstack/pull/601#issuecomment-122309433 JIRA ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-8650 --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [DISCUSS] Release principles for Apache CloudStack

Rene, Remi, I read back the thread and have another answer on this for you; The branch contains a point version number instead of a x.y.z-SNAPSHOT, without the branch a revert commit must follow if we vote them out. a branch can be simply neglected. On Thu, Jul 2, 2015 at 4:46 PM, Remi Bergsma wr

Re: [DISCUSS] Release principles for Apache CloudStack

Finally read the thread, It seems to me that a way forward is to have Remi and Rajani RM 4.6 (which is currently master). The two of them can discuss and start RMing 4.6 (PR merge etc) and then we can iterate on the wiki release scenario. @Remi @Rajani, would that work for you and you ready t

Re: [Discuss] separate ML for PR and build notification?

On Jul 13, 2015, at 12:55 PM, Wido den Hollander wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > On 13-07-15 10:11, Rene Moser wrote: >> Hey >> >> Since we "rebuild" our communication stack (slack, irc, ML, ...) I >> would bring up some discussion about the "noise" in the de

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-122299939 @wido same as @DaanHoogland here, ideal case we would have marvin tests…but... --- If your project is set up for it, you can reply to this email and have your repl

Re: [BLOCKER][4.6] New AWS SDK in master breaks S3 uploads

On Jul 17, 2015, at 10:53 AM, Wido den Hollander wrote: > Hi, > > Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-8640 > > I encountered this by using the AWS SDK under 4.5 (homebrew). > > 4.5 uses the 1.3.22 SDK, but master uses 1.9.8 and that breaks S3 uploads. > > AWS SDK 1.3.22 i

[GitHub] cloudstack pull request: boring resourse leaks again

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/602 boring resourse leaks again You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack coverity-resource-leaks Alternati

[GitHub] cloudstack pull request: Fix securitygroups ingress FW for protoco...

GitHub user franklouwers opened a pull request: https://github.com/apache/cloudstack/pull/601 Fix securitygroups ingress FW for protocol any and 0.0.0.0/0 When using security groups, adding an ingress rule for protocol "any" with source address 0.0.0.0/0, resulted in no action (as t

[GitHub] cloudstack pull request: CLOUDSTACK-8308-Adding-automation-test-ca...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/229#issuecomment-122266368 testpath_snapshot_limits is already in the repo. the required_hardware does not make sense to me. This PR should be closed --- If your project is set up for it

Re: [MASTER] ID RSA pub too open and asking passprrase

On 17-07-15 13:53, Wilder Rodrigues wrote: > Hi again, > > I just cleaned up the whole KVM host, also removing the .ssh/ dir contents > and deployed a new DC. The private key is not created anymore, only the pub > key: > > [root@kvm1 ~]# ls -lart .ssh/ > total 8 > dr-xr-x---. 4 root root 4096

Re: [DISCUSS] PR list length

I see your point Koushik, but as a matter of spreading the knowledge I think it is best to have non-expert give a second ok. In those cases extra explanation will be needed. That doesn't hurt either. If we all have the discipline to work on reviews once a week, we are spreading knowledge and keepin

[GitHub] cloudstack pull request: CLOUDSTACK-8308-Adding-automation-test-ca...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-122262701 @karuturi @kishankavala can you answer @bhaisaab or add your LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear

Dockerize cloudmonkey

Hi David, Could it be possible for you to create an automated build cloudmonkey on docker hub? you have access to cloudstack org in docker hub and github/apache, i don't have access to github/apache thru my github account. The dockerfile is in the root of cloudmonkey project and we would use aut

Re: [MASTER] ID RSA pub too open and asking passprrase

Hi again, I just cleaned up the whole KVM host, also removing the .ssh/ dir contents and deployed a new DC. The private key is not created anymore, only the pub key: [root@kvm1 ~]# ls -lart .ssh/ total 8 dr-xr-x---. 4 root root 4096 Jul 17 06:08 .. drwx--. 2 root root 4096 Jul 17 07:38 . -rw

RE: [DISCUSS] PR list length

For any reviews there are 2 aspects - general coding guidelines and domain knowledge. Based on the current backlog of PRs, I feel that whenever some domain knowledge is required to review a PR and there are not enough reviewers for that, the PR waits for a longer time. That's why I had suggested

Build failed in Jenkins: simulator-4.5-singlerun #254

See -- Started by upstream project "build-4.5-simulator" build number 309 originally caused by: Started by upstream project "build-4.5" build number 501 originally caused by: Started by an

[GitHub] cloudstack pull request: To Verfiy that list templates by domain a...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[MASTER] ID RSA pub too open and asking passprrase

Hi all, I’m nt able to use the id_rsa.pub.cloud on KVM hosts. See snippet bellow: [root@kvm1 ~]# ssh -i ~/.ssh/id_rsa.pub.cloud -p 3922 169.254.0.136 The authenticity of host '[169.254.0.136]:3922 ([169.254.0.136]:3922)' can't be established. ECDSA key fingerprint is 81:be:00:fe:37:8d:3f:99:63:

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] PR list length

I agree as well and since I started this thread a lot of work is being done to keep the list as short as possible. I am still worried that the list is growing, it has over a few weeks and though the growth stopped during the lifetime of this thread I hope we can keep up the discipline to keep it sh

[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] PR list length

I agree with wilder. ~Rajani On Thu, Jul 16, 2015 at 12:08 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > We should stick to the 2 LGTM. No matter if that a bug fix or a new > feature. > > Currently we have PRs where 1 LGTM was given, but them the second reviewer > asked question

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122247318 Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for example always being there in /usr/bin. Using /tmp for temporary directo

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122246365 will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/600#issuecomment-122246414 @DaanHoogland You can merge it I think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122246019 @karuturi @DaanHoogland @bhaisaab I suggest we merge it into 4.5 as well so that it makes 4.5.2 --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/599#issuecomment-122242828 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122241816 @DaanHoogland are you pushing this to 4.5 branch as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Privtmpl

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-122240477 I think it looks good? But it depends on earlier PR's I think since it's only a test --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122240171 I just tested it on 4.5 management server and my deployment errors are gone. I'm fine with it. LGTM --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/580#issuecomment-122237241 @wido thanks for the clarification. as said LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122236249 figured something like that but had't noticed the wait <:} @bhaisaab @wido are you fine like with this? --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/580#issuecomment-122236231 @DaanHoogland It is in the KVMFencer in the MGMT server. The Agent can't send an alert, so I had to do this in the mgmt server. --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/580#issuecomment-122235606 LGTM, how about the alert @bhaisaab asked for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34877501 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Mer

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122234984 Its not always safe. http://stackoverflow.com/a/14837457/201514 In our example, the threads unnecessarily wait for 1000 ms if the previous threads exited from a

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/580#issuecomment-122234914 The tests have been fixed, Mocking issue in the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: upgrade cloudstack from 4.2.0 to 4.4.2

sorry sent to soon On Fri, Jul 17, 2015 at 11:38 AM, Daan Hoogland wrote: > ad 1. The roll back procedure is - restore the old db - reinstall the old version of cloudstack - recover the old etc dir (/etc/cloudstack) that should do it > > ad 2. You only need to edit your cluster setting after t

Re: upgrade cloudstack from 4.2.0 to 4.4.2

ad 1. The roll back procedure is ad 2. You only need to edit your cluster setting after the upgrade to set them to 4 ad 3. yes they can remain running On Fri, Jul 17, 2015 at 5:03 AM, wrote: > Hello, > My environment is cloudstack4.2.0+vmware5.0.I'm testing the upgrade process > from cloudstac

Re: [DISCUSS] Moving to Java 8

On 16-07-15 17:58, John Burwell wrote: > Wido, > > We have an acute problem — Oracle will be issuing no further security patches > for Java7 which is a significant opsec risk. Put simply, we can’t leave our > users exposed to such a risk because Ubuntu won’t ship a release for an > non-EOL’e

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34875009 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Me

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34874962 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Me

Re: [LOGGING] Logging levels in CloudStack code

retweet ;) For those doing regular reviews of code this is also an item. thanks Wido for a sound cry in the desert. On Fri, Jul 17, 2015 at 10:58 AM, Wido den Hollander wrote: > Hi, > > After debugging multiple issues in CloudStack the past week I got > annoyed again by the fact that almost all l

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34873680 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Mer

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-15640 I found documentation on the net [1] that this is fine but I changed the flow anyway [1]http://stackoverflow.com/questions/7971946/in-java-return-value-wit

[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/600#issuecomment-15132 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[LOGGING] Logging levels in CloudStack code

Hi, After debugging multiple issues in CloudStack the past week I got annoyed again by the fact that almost all logs are hidden behind loglevel DEBUG and that our code doesn't make proper use of INFO, WARN and ERROR. I opened: https://issues.apache.org/jira/browse/CLOUDSTACK-8645 Now, fixing thi

[BLOCKER][4.6] New AWS SDK in master breaks S3 uploads

Hi, Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-8640 I encountered this by using the AWS SDK under 4.5 (homebrew). 4.5 uses the 1.3.22 SDK, but master uses 1.9.8 and that breaks S3 uploads. AWS SDK 1.3.22 is old, very old, but 1.9.8 is also rather old. The new SDK throws different

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34872122 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Me

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122219752 @wido @bhaisaab Made the suggested changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122216105 @wido, sounds like you mean to have it in but are not satisfied because of @karuturi 's remark. I will look into adding the notify at some place as I think it m

[GitHub] cloudstack pull request: asserted coverity resource leak issues

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/599#discussion_r34870126 --- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java --- @@ -63,9 +63,7 @@ private Merovingian2(long msId) { super(Mer

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-122212266 Wido, I want tests but if three other people want to merge it I'm not going to stand between them and the repo on my own. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-122211686 Since this one got 3 LGTM's but there are outstanding test requests, how to proceed? Do I merge it or wait for the tests? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122210319 Since the comment of @karuturi says there is something wrong with the code I don't think we can say LGTM here? I actually encountered this issue today on a runn

[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/600#discussion_r34869004 --- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java --- @@ -108,7 +107,7 @@ public void scan() {

[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/600#discussion_r34867930 --- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java --- @@ -108,7 +107,7 @@ public void scan() {

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-122200420 LGTM. Device id 7 on virtual SCSI (can be of any sub type : LsiLogic, LsiSAS, BusLogic, Paravirtual) controller is reserved for controller itself, re

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/548#issuecomment-122199556 LGTM. I see this patch is updating chain information for all 3 cases of storage migration, 1) volume migration 2) vm migration with storage