[GitHub] cloudstack pull request: Cloudstack-8693: Adding missing code in t...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/645 Cloudstack-8693: Adding missing code in testpath same vm name.py testpath Adding missing code to get hypervisor information You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126583069 Cool :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: initial dockerization commit.

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/623#issuecomment-126582144 I was able to build the images locally. changes looks good. :+1: for the centos 6 and marvin, it is always taking 4.6 images from jenkins. Which means we ha

VR remote access vpn not working in master

Hi All, In latest master remote access vpn is not working because the configuration is not applied on the VR. On the VR logs below error msg is seen. 'Error I do not know what to do with file of type remoteaccessvpn' I have file ticket CLOUDSTACK-8690

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/625#discussion_r35948897 --- Diff: setup/db/db/schema-452to460.sql --- @@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` ( CONSTRAINT `fk_extern

[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/631#discussion_r35947714 --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py --- @@ -0,0 +1,185 @@ +# Licensed to the Apache Software Foundation (ASF) under

Re: New "snapshot(s)" text in GUI

FYI that I just fixed this little "snapshot(s)" issue tonight in master. Here's the SHA: c0230273cdbdf2558f4a0802d177bd5757de34fd On Mon, Dec 29, 2014 at 6:38 PM, Nux! wrote: > +1 for reverting, looks unprofessional/inconsistent > > -- > Sent from the Delta quadrant using Borg technology! > > N

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126570824 @DaanHoogland @miguelaferreira I understand you concerns. I have created the ticket for this in JIRA with ID: CLOUDSTACK-8692. Will keep this in mind while for future

Small grammatical point to clarify

Hi everyone, I just checked in a couple changes to messages.properties in master. One thing I'd like to note is what I changed in e640e0cf6eb9508f74f9bad59519f7189da7d82e. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=client/WEB-INF/classes/resources/messages.properties;h

Re: [Blocker] Default ip table rules on VR

Thanks for working on it Wilder !! On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > Hi, > > We discussed that one yesterday and I already assigned the issue to myself > on Jira. I will fix it. > > Cheers, > WIlder > > > > > On 30 Jul 2015, at 14:09, Sanj

Re: [GitHub] cloudstack pull request: initial dockerization commit.

Hello dev@! I'm looking for another LGTM (real one, please read the PR) as replacement of Seb, PR #623 replace the PR #605 based on Seb's comments. Cheers, On Mon, Jul 27, 2015 at 4:52 AM, wido wrote: > Github user wido commented on the pull request: > > https://github.com/apache/clou

Re: [4.6] RC1 soon ?

Thanks Mike, I was thinking that the order of applying the statement parameters was reversed. Maybe you can try and apply this snippit: diff --git a/engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java b/engine/schema/src/org/apache/cloudstack/storage/datasto

Re: [4.6] RC1 soon ?

I'm doing other testing locally anyways. If you happen to find a fix, then I won't bother to revert. I can just try it again with your fix. I'll wait until tonight MST to revert. On Thu, Jul 30, 2015 at 1:51 PM, Daan Hoogland wrote: > leasure time is on > > On Thu, Jul 30, 2015 at 9:44 PM, Mike

Re: [4.6] RC1 soon ?

leasure time is on On Thu, Jul 30, 2015 at 9:44 PM, Mike Tutkowski wrote: > Sure, I can revert it and leave it for your leisure to find an acceptable > fix to satisfy FindBugs. > > On Thu, Jul 30, 2015 at 1:42 PM, Daan Hoogland > wrote: >> >> I am now thinking of how to isolate this code to writ

Re: [4.6] RC1 soon ?

Sure, I can revert it and leave it for your leisure to find an acceptable fix to satisfy FindBugs. On Thu, Jul 30, 2015 at 1:42 PM, Daan Hoogland wrote: > I am now thinking of how to isolate this code to write a proper test. > This is not going to be successful tonight, while the original seven

Re: [4.6] RC1 soon ?

I am now thinking of how to isolate this code to write a proper test. This is not going to be successful tonight, while the original seven samurai is on tv. Maybe reverting is the best option and we live with findbugs regression for a day. I will think of a way to fix this tomorrow wit a more clear

Re: [4.6] RC1 soon ?

But reintroduced the vulnerability that findbugs was complaining about... I think the problem is in this bit: int i=0; for (Map.Entry detail : details.entrySet()) { pstmt.setString(++i,detail.getKey()); pstmt.setString(++i,det

Re: [4.6] RC1 soon ?

No problem, Daan. :) Just from an empirical standpoint, though, reverting the commit in my local repo fixed the problem. On Thu, Jul 30, 2015 at 1:20 PM, Daan Hoogland wrote: > never mind that again, answerring to fast as I probably do one out of > two or three times :( Looking further... > > O

Re: [4.6] RC1 soon ?

never mind that again, answerring to fast as I probably do one out of two or three times :( Looking further... On Thu, Jul 30, 2015 at 9:19 PM, Daan Hoogland wrote: > Mike, I am looking at the commit and it makes perfect sense as the the > prior situation was creating a prepared statement based o

Re: [4.6] RC1 soon ?

Mike, I am looking at the commit and it makes perfect sense as the the prior situation was creating a prepared statement based on dynamicly added strings. The only queer thing is that the int i = 1 is replaced with i = 1, reusing the loop counter instead of hiding it. Maybe this is the problem On

Re: [4.6] RC1 soon ?

I see the problem. The way a SQL statement was constructed was changed by commit b84093f691ae0b09d2c525d50f2e2d200c709b2c: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java;h=d3c29f70d6ab

Re: [4.6] RC1 soon ?

FYI that I get the same error message when trying to attach a data disk that is based on zone-wide primary storage. On Thu, Jul 30, 2015 at 12:10 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I'm actually having trouble creating a VM whose root disk runs on > zone-wide primary stora

Re: [4.6] RC1 soon ?

I'm actually having trouble creating a VM whose root disk runs on zone-wide primary storage. This is definitely a blocker for 4.6. I'm just beginning to look into this, but this is the error message I receive: findZoneWideStoragePoolsByTags:Exception:No value specified for parameter 4 On Mon, Ju

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/637 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: Cloudstack commands to Xen hosts

I should add: I think it only sends API commands to the cluster through the cluster master. Todd Hebert Hosting engineer E: theb...@digiweb.ie A: College Business & Technology Park, Blanchardstown, Dublin 15, Ireland W: http://www.digiweb.ie/   -Original Message- From: Todd Hebert

RE: Cloudstack commands to Xen hosts

Either http or https..not sure which. xapi runs on ports 80 and 443 on each XenServer, so it hits one of those with an API request Todd Hebert Hosting engineer E: theb...@digiweb.ie A: College Business & Technology Park, Blanchardstown, Dublin 15, Ireland W: http://www.digiweb.ie/   -

Cloudstack commands to Xen hosts

Hi all, I was wondering, how does CS send commands to Xen hosts? Does it use SSH? Cheers

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126331708 So I will amend the interrupted to be level debug and then merge. next I will create a new PR for any remaining empty catch blocks, @koushik-das. --- If your p

Re: UsageMonitor UI Plugin ready

Ramzi, That's great,thanks for your contribution! I'll test it shortly. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Ramzi Youssefi" > To: "dev" > Sent: Thursday, 30 July, 2015 12:22:12 > Subject: UsageMonitor UI Plugin r

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126319900 Hi @kansal If this issue was caught by your internal Coverity scan, wouldn't it also have been cough by the public Coverity scan? Or are these confi

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126319443 -1 on this. I cannot track any internal tracking system of another company. please if the public coverity doesn't have this make a jira ticket describve the pro

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/640#issuecomment-126315563 Sorry, I already merged on apache repo. I will better the next time. Howto find the rules before merging ? (2 LGTM, How many asfbot/cloudstack-pull pro

Re: [Blocker] Default ip table rules on VR

Guys, I see votes here but no arguments. Why is it a blocker? >>> From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] >>> Sent: 30 July 2015 02:07 PM >>> To: >>> Subject: Re: [Blocker] Default ip table rules on VR >>> >>> I see VR ingress traffic is blocked by default from iptables

Re: [Blocker] Default ip table rules on VR

Hi, We discussed that one yesterday and I already assigned the issue to myself on Jira. I will fix it. Cheers, WIlder > On 30 Jul 2015, at 14:09, Sanjeev N wrote: > > Agree with Kishan Kavala and Jayapal. > > On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala > wrote: > >> This is a security

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/640#issuecomment-126307227 Bruno, please find two LGTM before merging, thanks. Can you still advertise and find some? --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126301540 @DaanHoogland It was the issue that was reported by our internal coverity. The issue reported is: "noescape: Resource 'in' is not closed or saved in readObjec

Re: [Blocker] Default ip table rules on VR

Agree with Kishan Kavala and Jayapal. On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala wrote: > This is a security issue with high impact. > We should treat it as a blocker. > > -Original Message- > From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] > Sent: 30 July 2015 02:07

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126288404 @sspans Since Test case is updated to cover VXLAN also, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/638#discussion_r35862152 --- Diff: test/integration/testpaths/testpath_hypervisor_limit.py --- @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r35862098 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description =

Build failed in Jenkins: simulator-4.5-singlerun #256

See -- Started by upstream project "build-4.5-simulator" build number 311 originally caused by: Started by upstream project "build-4.5" build number 503 originally caused by: Started by an

UsageMonitor UI Plugin ready

Hello everyone, herby I share with everyone our first UI Plugin to monitor the usage resources. Here is the link: https://github.com/BIT-Group-GmbH/cloudstack-plugin-ui-usagemonitor Any thoughts will be very much appreciated. Cheers and have fun! -- Ramzi Youssefi Görlitzer Str. 49 01099 Dresd

[GitHub] cloudstack pull request: Update L10N resource files on 4.4 branch ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/642 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/643#discussion_r35860179 --- Diff: server/src/org/apache/cloudstack/region/RegionsApiUtil.java --- @@ -186,8 +186,12 @@ protected static UserAccount makeUserAccountAPICall(Re

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/644 Removed "medium" dictionary from test_data and modified the tests dependen on it We have two entried(keys) named "small" and "medium" inside test_data.py to specify the vm properties and acce

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126274712 @kansal please add the coverity number to the commit message, this way we can not track it. And while you look at it make sure you put the issue on your name to

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/643 Coverity Issue: Resource Leak fixed Resource leak fixed. Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kansal/cloudstack Cov

[GitHub] cloudstack pull request: Update L10N resource files on 4.4 branch ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/642 Update L10N resource files on 4.4 branch with 4.4 translation strings… … from Transifex (20150730) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/640#issuecomment-126263112 Thanks BrunO! I can't judge all the languages but du/en/fr look good to me --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/641 Update L10N resource files on 4.5 branch with 4.5 translation strings… … from Transifex (20150730) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126260440 @DaanHoogland Merge this in 4.6. If possible push the log level changes in 4.6 as well. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/640 Update L10N resource files on master branch with 4.6 translation strings from Transifex (20150730) You can merge this pull request into a Git repository by running: $ git pull

Re: Git Rebase Question

Happy to know your problem is fixed. Cheers \ Miguel Ferreira mferre...@schubergphilis.com On 29 Jul 2015, at 19:34, Mike Tutkowski mailto:mike.tutkow...@solidfire.com>> wrote: Hi Miguel, I appreciate your willingness to help - thanks! As it turns ou

[GitHub] cloudstack pull request: :q!Coverity 17897

Github user kansal closed the pull request at: https://github.com/apache/cloudstack/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126258728 ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: :q!Coverity 17897

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/639 :q!Coverity 17897 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kansal/cloudstack Coverity-17897 Alternatively you can review and apply th

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126257887 The plugin would fail, similar to how it fails now when you ask ik to do vxlan when it only supports STT. The encapsulation type is something that you first config

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126250367 @sspans yes but they might be tempted to do some vxlanning after upgrading ACS not upgrading NSX . what would happen? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126250153 Testing and a unit-test will still be added. We need this feature because we're planning to roll out new zones with VXLAN, which if the changes remain sma

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126247958 Daan: any supported release of vmware nsx will support VXLAN. People running older releases probably already have an STT setup running, and should not encounter pr

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126238495 So @koushik-das Do you propose the folowing? - merge this for 4.6 - make a critical ticket for 4.7 to asses log levels note that I am not completely d

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126233316 Changes LGTM, since we are creating a separate bug for correctly handling log levels. @DaanHoogland I am not saying to remove the interrupted exceptions, just

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user devdeep commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r35849928 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description = "temp

RE: [Blocker] Default ip table rules on VR

This is a security issue with high impact. We should treat it as a blocker. -Original Message- From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] Sent: 30 July 2015 02:07 PM To: Subject: Re: [Blocker] Default ip table rules on VR I see VR ingress traffic is blocked by def

Re: [Blocker] Default ip table rules on VR

I see VR ingress traffic is blocked by default from iptables mangle table. But on the guest interface all the traffic is accepted. Also egress firewall rule will break because of FORWARD policy. Thanks, Jayapal On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi wrote: > > It is security concern

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r35849002 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description =

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/638#discussion_r35848734 --- Diff: test/integration/testpaths/testpath_hypervisor_limit.py --- @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/638#discussion_r35848618 --- Diff: test/integration/testpaths/testpath_hypervisor_limit.py --- @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126215256 @kishankavala @DaanHoogland :+1: for the Jira ticket. After 4.6 we can come back to this and assess the messages accordingly. But would be nice to h

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126214607 Code wise it is LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/638 CLOUDSTACK-8689: Verify effect of changing value of XenServer Max guest limit Verify effect of changing value of "Max guest limit" of XenServer on previously added hosts -Check if

Re: [Blocker] Default ip table rules on VR

It is security concern on the VR. All the ingress traffic onto the VR is accepted. Let it be blocker. Thanks, Jayapal On 30-Jul-2015, at 12:28 PM, Daan Hoogland wrote: > I changed it to critical. It is only a blocker if we agree on this > list that it is. > > On Thu, Jul 30, 2015 at 6:44 AM

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126206244 @kishankavala you actually made me think I should wait till after 4.6, on the other hand we will have to take the pain in a release. --- If your project is set

[GitHub] cloudstack pull request: Added a test to verify that listSnapshots...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/637#issuecomment-126205414 @DaanHoogland Agreed that setting appropriate log level is out of the scope for this PR. But we should file a jira ticket to track and address it before nex