[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r50081550 --- Diff: ui/scripts/docs.js --- @@ -1008,7 +1008,7 @@ cloudStack.docs = { }, // Add volume helpVolumeName: { -

Re: [PROPOSAL] LTS Release Cycle

On Tue, Jan 19, 2016 at 4:20 AM, John Burwell wrote: > In terms of the merge strategy, nothing about the current process would > change. Defects would be fixed on the branch where they occurred and then > forward ported to master. For each maintained LTS branch less than 14 > months old, only blo

Re: Help with JUnits

Thanks Mike, I read through the link and also saw the video, this answers part of my question about executing the unit tests. The other part of the questions still remains ie were are junits written in Java for this class and operation UserVmManagerImpl.commitUserVm. How do we check the juni

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r50079832 --- Diff: ui/scripts/docs.js --- @@ -1008,7 +1008,7 @@ cloudStack.docs = { }, // Add volume helpVolumeName: { -

Build failed in Jenkins: build-master-slowbuild #3021

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Help with JUnits

Here's a video of a presentation I gave about Marvin (from CloudStack Days in Austin last year): https://www.youtube.com/watch?v=N_eKBA_TeOs On Mon, Jan 18, 2016 at 9:49 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Does this help? > > > https://cwiki.apache.org/confluence/display/

Re: Help with JUnits

Does this help? https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python On Mon, Jan 18, 2016 at 8:56 PM, B Prakash wrote: > Hi, > > > Please can someone help me with identifying and amending junits for > UserVmManagerImpl.commitUserVm? I see a test class called

Help with JUnits

Hi, Please can someone help me with identifying and amending junits for UserVmManagerImpl.commitUserVm? I see a test class called UserVmManagerTest but I dont see a good junits coverage here. Also link in the 'Developer > Testing > Unit testing with JUnit and Spring' doesnt give out lot

Re: [DISCUSS][PROPOSE] use of optional instead of null

Daan, The problem lies within Java itself and the decision not to allow for typed nulls. Therefore, writing safe code requires a certain degree null checking. There are also circumstances where a null is the correct representation. For example, there are optional numeric values who can only

Re: [PROPOSAL] LTS Release Cycle

Daan and Erik, @Erik Reading through the proposal, I realize that I was not explicit. LTS releases would be official ASF releases following the same voting procedures as any other release. Also, realized that I have a bit a math fail in my proposal. The cut dates are intended to be six (6) mont

Build failed in Jenkins: build-master-slowbuild #3020

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSAL] LTS Release Cycle

Ilya, Unless we have a bug fix that addresses a significant, widespread system stability problem or a high priority/impact security issue, an LTS will roll up a number of fixes. Each release would receive the full system test to verify that the patch set does not introduce regression defects.

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-172715155 Code LGTM, as a general comment though, I think it is cleaner to be as precise as possible with exception handling. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r50066929 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -942,6 +931,83 @@ protected

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-172710149 @DaanHoogland np, I will close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1337#discussion_r50060205 --- Diff: ui/scripts/network.js --- @@ -3667,8 +3652,16 @@ return 2; //hide Autoscale butt

Build failed in Jenkins: build-master-slowbuild #3019

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Enhance VR performance

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50058474 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -96,29 +96,8 @@ def configure_server(self): self.conf.search(sli

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1342#discussion_r50058625 --- Diff: ui/scripts/ui-custom/instanceWizard.js --- @@ -429,12 +427,52 @@ $step.find('.custom-size-label').remove

[GitHub] cloudstack pull request: Enhance VR performance

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50057844 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

[GitHub] cloudstack pull request: Enhance VR performance

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50057840 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

Re: [DISCUSSION] Collab for Spring 2016

I like this idea as well because it gets more of the participants focusing on the actual code. I think it will make the hackathon more useful for the project this way. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.

Re: [DISCUSSION] Collab for Spring 2016

So you're thinking a Hackathon day and a day of presentations? That seems reasonable. On Monday, January 18, 2016, Pierre-Luc Dion wrote: > 2 days or more so we could have an hackathon or a day where we could spend > collaborative time working on cloudstack ? > I liked the hackathon of previous

Re: [DISCUSSION] Collab for Spring 2016

2 days or more so we could have an hackathon or a day where we could spend collaborative time working on cloudstack ? I liked the hackathon of previous events but they were usually during time of interesting talks so I think it would be nice to split them but within the same event. PL On Mon, J

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-172661987 looking into this, probably been working on to much at the same time today, sorry --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172657149 f(^(* cherry-pick problem. it was fixed in 4.2.1 first :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

New Defects reported by Coverity Scan for cloudstack

Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 1 new defect(s) introduced to cloudstack found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(

Build failed in Jenkins: build-master-slowbuild #3018

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-172624897 @DaanHoogland Please check, unit test error: ``` --- T E S T S --

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172622057 @DaanHoogland Please check, it doesn't compile :-( ``` [ERROR] COMPILATION ERROR : [INFO] --

Re: [DISCUSSION] Collab for Spring 2016

I'd be interested in a couple events this year pretty much wherever they are. I have a couple ideas for new presentations that I think will be of interest to people. It's typically easier for me to get permission for longer-distance trips if the event is longer (I expect that is common). We might

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172619972 Giving that, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Build failed in Jenkins: build-master-slowbuild #3017

See Changes: [nitin.maharana] CLOUDSTACK-9231: Root volume migration from one primary to another [miguelferreira] Add test to check that each thread has it's own execution counter [miguelferreira] Fix execution counter t

[GitHub] cloudstack pull request: test: Fix Libvirt test so that it works o...

Github user bheuvel commented on the pull request: https://github.com/apache/cloudstack/pull/1242#issuecomment-172607827 Well, short answer, LGTM and seen it compile on Windows (only) with this adjustment. Longs answer has more to do with the object/code generating the path `

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172606992 Makes sense Rafael, added something to that regard --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172603168 Shouldn’t we make that clear at the documentation too? I mean, the method/function should contain some info about the removal of the function. It is

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1349 CLOUDSTACK-9239 throw exception on deprecated command an API call to LockAccount fails silently with a 200 return and no contents. client are responsible to check and will find that no loc

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-172597438 here is my original request to look at them: http://markmail.org/message/fqv252o3p7hmzwxz --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1348 CLOUDSTACK-9142 Migrate VM changes xmlDesc in a safe way The problem arises when the origin hypervisor has an ip addres that ends with 1, like '10.10.10.1' and the VM is having a disk on a

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-172594983 @remibergsma I would have to dive into my original investigation again. I am not sure who or where the others where created anymore. lat me markmail that for y

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-172563054 What needs to be done to fix them all? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: ui: improve metrics view implementation

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ui: improve metrics view implementation

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1347#issuecomment-172560057 did a run through the code: LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-172558281 again code LGTM. Let's quickly run it 3 out of 5 findbugs issues will be fixed in this. --- If your project is set up for it, you can reply to this email and

Build failed in Jenkins: build-master-slowbuild #3016

See Changes: [nitin.maharana] CLOUDSTACK-9230: Remove unnecessary return statement from cloudStack.js -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:

[GitHub] cloudstack pull request: CLOUDSTACK-9231: Root volume migration fr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747 LGTM based on these tests: Situation before when not using Netscaler: ![screen shot 2016-01-18 at 15 37 25](https://cloud.githubusercontent.com

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1334#issuecomment-172539609 LGTM, not tested actual Netscaler integration as I don't have such a setup. I did check the syntax and saw the UI still renders properly. ![scre

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670 @nitin-maharana I like it when you put screenshots, as this speeds up my testing because I can see what you mean. I will test it soon, can you help me by puttin

[GitHub] cloudstack pull request: ui: improve metrics view implementation

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1347#issuecomment-172536210 LGTM, nice improvement @bhaisaab ! Some screenshots of my test env: ![screen shot 2016-01-18 at 15 09 08](https://cloud.githubusercontent.com/a

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172533708 LGTM, UI seems to display OK. ![screen shot 2016-01-18 at 15 00 56](https://cloud.githubusercontent.com/assets/1630096/12393165/516e8c2e-bdf4-11e5-9b79-

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r49997495 --- Diff: ui/scripts/docs.js --- @@ -1008,7 +1008,7 @@ cloudStack.docs = { }, // Add volume helpVolumeName: { -

[DISCUSSION] Collab for Spring 2016

Hi, I can't recall the thread about having a Collab this spring. Not sure either if a place has been selected yet, Does anyone would be interested to participate if we organise something in Canada? or because of the Bresil edition it would be preferable to have it in europe? I wouldn't go with a

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-172522583 At leaseweb we noticed the same behavior for networks. I propose we use the uuid as the name there as well. Will create a PR. --- If your project is set up fo

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1344#issuecomment-172519784 This due to the PR being for a merge commit. You could have just pushed it upstream The extra merge does nothing the extra file (s?) is only in the conf

Build failed in Jenkins: build-master-slowbuild #3015

See Changes: [wrodrigues] CLOUDSTACK-9154 - Returns the guest iterface that is marked as added [wrodrigues] CLOUDSTACK-9154 - Adds test to cover nics state after GC [wrodrigues] CLOUDSTACK-9187 - Adds test to cover multip

[GitHub] cloudstack pull request: Enhance VR performance

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1346#issuecomment-172512058 Started the tests: ``` [root@cs1 integration]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a ta

Build failed in Jenkins: build-master-jdk18 #457

See Changes: [wrodrigues] CLOUDSTACK-9154 - Returns the guest iterface that is marked as added [wrodrigues] CLOUDSTACK-9154 - Adds test to cover nics state after GC [wrodrigues] CLOUDSTACK-9187 - Adds test to cover multiple ni

[GitHub] cloudstack pull request: ui: improve metrics view implementation

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1347 ui: improve metrics view implementation - Implement Search boxes in all Metrics views - Fix threshold calculations for host and storage pool metrics view - Consider overcommit ratios fo

[GitHub] cloudstack pull request: Enhance VR performance

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1346#issuecomment-172505604 Have started tests on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055 LGTM :+1: Did code review and ran the PR in beta --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1344#issuecomment-172503325 After merging this PR shows much more commits and changed files than before merge. For the record, this what I saw at the moment of merging: ![

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1344#issuecomment-172500103 LGTM Run the tests to be sure, all fine. ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ c

[GitHub] cloudstack pull request: Enhance VR performance

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1346#issuecomment-172488515 Hi @borisroman Thanks for the fixes! It will really make the VRs behave better! :) I now sit next to Boris here at Schuberg Philis and was

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-172485592 @remibergsma conflict got resolved. I have tried running this test. There were some test setup issue while I am running I resolved those in my local. The test go

[GitHub] cloudstack pull request: Enhance VR performance

Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r49976226 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

Build failed in Jenkins: build-master-slowbuild #3014

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Enhance VR performance

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1346 Enhance VR performance Will post integration test results soon! Ping @wilderrodrigues @remibergsma You can merge this pull request into a Git repository by running: $ gi

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1190#issuecomment-172466590 LGTM Test revert snapshot on XenServer ... === TestName:test_01_check_revert_snapshot | Status SUCCESS === ok --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-172463466 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172460540 @remibergsma @DaanHoogland I've fixed a concurency issue in a unit tests (pointed out by @borisroman) and in the process rebased this branch on latest 4.7.