[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1392#issuecomment-178752840 Thanks, closing and moving this commit to PR https://github.com/apache/cloudstack/pull/1397 As it tries to fix the issue that the other PR brings --- If your

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1397 maven: Upgrade dependency versions Updated most dependencies to latest minor releases, except: - Gson 2.x - Major spring framework version - Servlet version - Embedded

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1398 CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, Network, Egress rules Steps to Repro: Please see the snapshots attached. Fix:

[GitHub] cloudstack pull request: CLOUDSTACK-9269: Missing field for Switch...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1396 CLOUDSTACK-9269: Missing field for Switch type for Management and Storage traffic types Repro Steps: === Create an Advanced zone(VMware). Configure physical network.

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-178750977 Reopened from https://github.com/apache/cloudstack/pull/1393 with the branch on ASF remote. cc @DaanHoogland --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1393#issuecomment-178750332 @DaanHoogland how about this, I close this PR; push the branch to asf remote and you continue on that branch keeping the same PR? --- If your project is set up

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-178759820 @DaanHoogland I've tested this and fix an issue, please feel free to make changes directly on this branch --- If your project is set up for it, you can reply to

Jenkins build is back to normal : build-master-slowbuild #3138

See

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user dmytro-shevchenko commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-178890524 Done, rebased with 4.9xx master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

Github user cloudsadhu closed the pull request at: https://github.com/apache/cloudstack/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/691#issuecomment-179025093 for same issue Another PR created and checked in master so closing this PR request. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1377#discussion_r51680970 --- Diff: test/integration/component/test_escalations_snapshots.py --- @@ -152,6 +156,34 @@ def __verify_values(self, expected_vals, actual_vals):

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1377#discussion_r51681502 --- Diff: test/integration/component/test_escalations_snapshots.py --- @@ -639,3 +671,47 @@ def test_04_list_vm_snapshots_byid(self):

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659 Hi, @alexandrelimassantana thanks for notifying. I have made modification, according to your suggestion. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9272: No option in UI to add G...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1399 CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP" Steps to Repro: Go to Regions -> Local -> View GSLB -> Add GSLB Click on the service type

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1389#issuecomment-178503110 not worth it, @borisroman? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500 @DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1389#issuecomment-178507273 thank, don't hurry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1390 CLOUDSTACK-9267: String is not localized on create instance wizards. Repro Steps: == 1. Setup basic environments as normal. 2. Open a browser, go to Web Console.

[Discuss] Flexible CI/CD - Trillian

Project: Trillian We have been working on PoC of a CI environment design which will: · Provide fast build or rebuild of environments for testing. · Enable multiple independent concurrent builds · Be available on-demand through automation or individual request. ·

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-178507781 more explanation then code, but makes sense. mostly cosmatic: LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1391 Restore iptables at once using iptables-restore instead of calling iptables numerous times You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1392 framework/quota: Fix checkstyle issue Fixes a checkstyle issue for enums, breaks with newer mvn checkstyle versions cc @agneya2001 You can merge this pull request into a Git

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1393 maven: Upgrade dependency versions and to maven 3.3.9 Skipped: (but upgraded to latest minor release) - Major spring framework version - Servlet version - Embedded jetty version

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-178660255 LGTM as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-178526046 There is one more localised issue in the project page, So instead of creating a new one adding it to this PR only. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-178522940 I thought of making a small explanation. But I follow this template while making a PR so that it would be easy for committer to review very fast. Anyway

Re: [Discuss] Flexible CI/CD - Trillian

Hi Paul, This is great news, good job, naming apart. :-) Is ESXi a hard requirement on running Trillian? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Paul Angus" > To: dev@cloudstack.apache.org > Cc:

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1394 CLOUDSTACK-9268: Display VM in Load balancing rule in UI Steps of Repro: = 1:Create VMs 2:Make LoadBalancing rule in GUI 　Name:WWW 　PrivatePort:80

Build failed in Jenkins: build-master-slowbuild #3137

See -- [...truncated 824 lines...] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) at

[GitHub] cloudstack pull request: [4.7] VMware boot order fix

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1395 [4.7] VMware boot order fix In case of VMware, since root disk needs to be first in the hdd boot order, we collect list of hdds and create a hdd boot order with the root disk as the

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-178696450 @GabrielBrascher thanks, fixed the accessor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-178702561 LGTM (just did code review, no regression tests) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1392#issuecomment-178703798 simple rename of an enum: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [PROPOSAL] LTS Release Cycle

All, Based on the feedback from Ilya, Erik, and Daan, I have updated my original LTS proposal to clarify that LTS releases are official project deliverables, commit traceability across branches, and RM approval of PRs: ## START ## Motivation == The current monthly release cycle

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1393#issuecomment-178705720 @bhaisaab could you move the version numbers to the root pom instead of updating the project poms? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-178706035 @nitin-maharana can you add a screenshot of the intended change? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1393#issuecomment-178706313 @DaanHoogland sure will do this weekend, this was mostly edited by the maven versions plugin. Do you want to work on this, as you may have some version related

[GitHub] cloudstack pull request: [4.7] VMware boot order fix

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1395#issuecomment-178709268 looks good, I cannot test this. Can you create a marvin test (or point one out) for this? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1393#issuecomment-178710383 I will integrate them, and make a PR to this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-178716448 Before Fix: = 

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-179035607 Did code review. Code looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9066: Update testpath to delet...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1078#issuecomment-179054474 LGTM based on code review!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9168: Testpath to check if wro...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1245#discussion_r51685979 --- Diff: test/integration/testpaths/testpath_netmask.py --- @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: CLOUDSTACK-9168: Testpath to check if wro...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1245#discussion_r51686104 --- Diff: test/integration/testpaths/testpath_netmask.py --- @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#