Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207714662
@kiwiflyer Jenkins is failing. Not sure how the error could be related to
your code changes, so can you do a `push -f` again to kick it off again.
Here is th
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207710030
@jburwell Thanks for the comments. I pushed a new commit that implements
most of your comments. I'm still looking at one or two of them.
---
If your project
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59110681
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ priv
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59110675
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ priv
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59108724
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -114,6 +142,17 @@ privat
I will get into the habit of posting these statuses on monday mornings so
it better aligns with people's regular activities and does not get lost in
the 'weekend emails'. :) Have a good weekend everyone...
On Fri, Apr 8, 2016 at 6:36 PM, Will Stevens
wrote:
> This is something I will likely st
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207676683
Hi, would you mind extracting to a method lines 606-612? They are
duplicated at line 627.
Then, you could even create test cases for it.
---
If your
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207676112
@swill I've squashed the commits
@kollyma I'm sorry I missed your message. Do you still see a problem?
Something strage that I see in your output is the
`siz
Hi,
ACPDoctor (was CCPDoctor) is a proprietary utility designed for CloudPlatform.
Accelerite technical support uses it for CloudPlatform installation,
troubleshooting and customer issues. We have removed the public link to avoid
any confusion.
Thanks,
Lianghwa
> -Original Message-
Welcome to the community, Rashimi.
>
Regards,
John Burwell
john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On Apr 8, 2016, at 1:03 PM, Ahmad Emneina wrote:
>
> Welcome Rashmi, look forward to seeing great contributions!
>
> Ahmad
This is something I will likely start doing on a weekly basis. This is my
current RM task list. As I merge in PRs they will be removed from this
list, but these are the PRs I am actively working on. I have a thread open
(PRs for 4.9 Release) for people to specify PRs they want to get on my
radar
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631254
Ya, probably a good discussion to take to dev@.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207630967
on a second thought I'll probably ask this on dev@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631157
I will have to think about that a bit. I think it would be valuable, but I
have to get my head around if there are implications in doing that. Are
there any i
Thanks Eran. Historically this tool was freely available at
http://ccpdoctor.com/. I am guessing that is no longer the case? Thanks
for maintaining this tool, I have used it quite a bit in the past and it is
a valuable tool for troubleshooting...
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cl
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207629434
@swill sure :) one more thing I want to discuss, should we enable
-Dnoredist for Travis builds? I maintain this noredist repo which we can use to
git clone as the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207628400
Yes, that is what I plan to do. I just saw a different squash commit
complete successfully, so it seems that travis is not 'always' failing, even
though it has faile
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207627057
Thank you @kiwiflyer. Once Jenkins finishes I will merge this since we
have the code reviews we need and there is no logical changes that need to be
tested (since @p
Hi Will,
Accelerite customers get access to this tool as part of their support agreement
and there is no extra fee for it.
Eran Steiner
Accelerite CloudPlatform Engineering
-Original Message-
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of
Will Stevens
Se
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207625965
@swill I would say let's wait for travis to go green on this and then
merge. Then in future if anything break, we can have a look at the logs to see
which unit tes
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207625716
@bhaisaab thanks for doing this. I suspect the travis run will fail so I
will have to break my own rule and force merge. :) I will wait for it to
finish regardless
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207624970
Thank you very much for the quick follow up on this, it is greatly
appreciated. :+1: I will review the linked PR.
---
If your project is set up for it, you can re
Thanks Eran. Can you clarify if the tool will remain freely available?
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Fri, Apr 8, 2016 at 5:54 PM, Eran Steiner
wrote:
> Hi,
>
> That's cor
Thanks for the clarification seb. That helps me understand how to
troubleshoot this.
I am open to others helping me troubleshoot this though. Any takers? ;)
On Apr 8, 2016 4:50 PM, "Sebastien Goasguen" wrote:
> Will, the way travis works is that it reads what is in .travis.yml at the
> root of o
Hi,
That's correct, ACPDoctor (CCPDoctor) is a proprietary tool developed for
helping Accelerite customers with ongoing CloudPlatform support. It is
maintained by Accelerite engineering and Support and released frequently with
ongoing troubleshooting and tuning suggestions. It is also used to
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1481
travis: increase build verbosity
Outputs for modules that fail or succeed with unit tests results.
Based on the issue raised in https://github.com/apache/cloudstack/pull/1466
this PR
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207618243
@swill Squashed and force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207617920
@swill @nvazquez I saw the failing job:
https://travis-ci.org/apache/cloudstack/jobs/121766436
It failed due to missing Marvin distribution:
IOError: [Errno
Will, the way travis works is that it reads what is in .travis.yml at the root
of our repo.
If you check it, you will see that it uses scripts in /tools to make a fresh
build of the simulator, start the simulator and run the tests.
Everyone who has a fork will end up with Travis runs in their t
Github user phillipkent commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/17#issuecomment-207598302
@bhaisaab Just to clarify, the problem isn't when * is between other
characters, it is a * anywhere in the request URL which will lead to
disagreement of the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59085891
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/PrimaryDataStoreImpl.java
---
@@ -239,10 +241,34 @@ public boolean isManage
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59085610
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -279,7 +284,52 @@ public boolean del
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59085130
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -279,7 +284,52 @@ public boolean del
I am not sure who has control of travis and how that works. I have not had
a chance to get my head into that aspect yet.
Can someone have a look at the following issue which seems to be happening
to a bunch of travis builds right now.
Requirement 'tools/marvin/dist/Marvin-*.tar.gz' looks like a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59084967
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -440,41 +526,28 @@ private void
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207591089
I saw travis failing with this earlier. I will see if I can figure out
what is going on. Thx...
---
If your project is set up for it, you can reply to this email a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59084839
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -387,38 +424,87 @@ private Strin
Thank you sir. I have added it to my queue. :)
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Fri, Apr 8, 2016 at 3:04 PM, Remi Bergsma
wrote:
> Hi Will,
>
> I’d propose to test this one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59084080
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -245,6 +228,52 @@ public Snapsho
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59083203
--- Diff:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
@@ -90,7 +96,7 @@ public void mak
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59083160
--- Diff:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
@@ -65,8 +66,13 @@ public long ge
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082995
--- Diff:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
@@ -44,7 +45,7 @@
boolea
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082791
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
---
@@ -189,12 +189,24 @@ public void
processEvent(Ob
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082769
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
---
@@ -189,12 +189,24 @@ public void
processEvent(Ob
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082814
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
---
@@ -299,28 +311,17 @@ public DataTO getTO() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082240
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082189
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59082041
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59081711
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59081613
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59080710
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59081457
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59081095
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59079601
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59079506
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59078926
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59078742
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59078437
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private St
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59078361
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ p
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59078225
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077514
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207570464
Remove unused files is always good. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077320
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077350
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077297
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077257
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private Vo
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59077175
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
---
@@ -23,18 +23,21 @@
imp
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076982
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076866
--- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java ---
@@ -35,7 +35,7 @@
long memory;
long dom0MinMemory;
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076763
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076683
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076292
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076160
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59076080
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207565521
@mike-tutkowski while we can't run the tests, there is still value in being
able to read them to understand how the functionality is being tested. During
review,
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59075640
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -80,32 +92,48 @@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59075182
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59075048
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59075010
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074950
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private vo
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207562190
You're welcome :)
Now Travis failed without including changes (only comment line). Do I try
again after Jenkins finishes using push -f?
---
If your project i
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r5907
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -132,31 +171,52 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074456
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -132,31 +171,52 @@ public void
Hi Will,
I’d propose to test this one as it fixes a nasty concurrency issue. I runs on
prod at SBP for some time now so I’m quite sure it’s solid but let’s run the
tests again to be sure.
https://github.com/apache/cloudstack/pull/1470
Regards,
Remi
On 08/04/16 20:56, "williamstev...@gmail
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074290
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -114,6 +142,17 @@ private bool
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074279
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -80,32 +92,48 @@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074209
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -114,6 +142,17 @@ private bool
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074068
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -80,32 +92,48 @@
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207559800
I'm not sure what the standard for "idiomatic" is here. :) I've pretty much
usually seen "_" (and sometimes "m_") used to note a member variable versus a
loc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59073600
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -394,6 +394,7 @@ public VolumeInfo createV
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59073181
--- Diff:
core/src/org/apache/cloudstack/storage/command/ResignatureCommand.java ---
@@ -0,0 +1,46 @@
+//
+// Licensed to the Apache Software Fo
Thanks for the items syed. I have added them to my active list.
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Fri, Apr 8, 2016 at 2:32 PM, Syed Mushtaq
wrote:
> Hi Will,
>
> Thanks for a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59073124
--- Diff:
core/src/org/apache/cloudstack/storage/command/ResignatureCommand.java ---
@@ -0,0 +1,46 @@
+//
+// Licensed to the Apache Software Fo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207555946
@syed can you squash the commits please and do a `push -f` to update the PR
branch?
Do you have any feedback for @kollyma if he is seeing a similar issue as
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207555843
The CloudStack community can definitely have those tests, if it wants them.
Right now, however, we don't have any way to enable other people (besides
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207554891
@mike-tutkowski why can't the Marbin test cases be checked in? While we
can't run them, it would be nice to review them to understand exactly how the
feature is b
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207554051
@mike-tutkowski @swill I don't think a formal guideline has been set, but
we have been pushing toward adopting more idiomatic Java naming conventions.
The use of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207553542
@syed I have not looked into this. Is it possible for us to improve the
test so it actually tests that the VPN works?
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207551688
Oh, I understand. Thanks... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207550783
Thanks @swill, I just wanted to remove all my commits for Travis test to
run without my changes, but doing that closed the pr. Now I pushed a commit
including a co
1 - 100 of 167 matches
Mail list logo