[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90397919 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import java.u

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90397788 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import java.u

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90397502 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import java.u

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/828 @sureshanaparti @sateesh-chodapuneedi this looks like a useful patch, can you change the base branch of your PR to 4.9? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/873 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/873 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

2016-11-30 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1804 CLOUDSTACK-9639: Unable to create shared network with vLan isolation Description: = Create shared network fails with Error. While creating a shared network it fails to

[GitHub] cloudstack issue #1794: added more guest os

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1794 @karuturi ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/828 LGTM. Verified manually in my VMware setup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90394494 --- Diff: api/src/com/cloud/network/Network.java --- @@ -215,6 +216,8 @@ public static Provider getProvider(String providerName) { public stat

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/828 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/828 LGTM. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack issue #1803: CLOUDSTACK-9636: The host alerts box should be named...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1803 LGTM, @nitin-maharana can you rebase and change PR's base branch to 4.9. This is a small and useful change. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1802 LGTM, let's wait for the result. @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1579 I'm seeing no new errors except for `test_06_download_detached_volume` and `test_01_create_template`. @prashanthvarma can you have a look, they may be intermittent in nature. @jburwell ca

[GitHub] cloudstack pull request #1801: fix marvin test failure test_router_dhcp_opts

2016-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov can you have a look at failure in `test_01_snapshot_root_disk`? @jburwell Jenkins is not reliable, with my latest fix Travis will do noredist build checks and RAT-license checks

[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts

2016-11-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1801 LGTM. Thanks @murali-reddy I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 @murali-reddy a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1802 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1579 @prashanthvarma agreed regarding the most common causes of failures. @murali-reddy @borisstoyanov and @abhinandanprateek have been working to address these issues as they are encountered. To

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1435 @PaulAngus @rhtyd what are your thoughts on automating the testing of the Docker container? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack issue #1803: CLOUDSTACK-9636: The host alerts box should be named...

2016-11-30 Thread nitin-maharana
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1803 ![image](https://cloud.githubusercontent.com/assets/12583725/20781994/b9ddd9e6-b7ad-11e6-86b6-c80d347cc2ac.png) --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1435 @pdion891 can you please investigate the Jenkins failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1435 @pdion891 if possible, I would like to get this merged for 4.9.1.0. How does this PR relate to #1789? Also, could you please investigate the Jenkins failure and create JIRA ticket for this is

[GitHub] cloudstack issue #1784: CS-505: Marvin test to check VR internal DNS Service

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1784 @murali-reddy is internal DNS service impacted by having multiple NICs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 @murali-reddy a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380293 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380926 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380579 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380262 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380120 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1784: CS-505: Marvin test to check VR internal DNS ...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1784#discussion_r90380041 --- Diff: test/integration/smoke/test_router_dnsservice.py --- @@ -0,0 +1,268 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-11-30 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1802 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts

2016-11-30 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1801 test_router_dhcp_opts is passing, and we have necessary LGTM's. can we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1754 Trillian test result (tid-514) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 35803 seconds Marvin logs: https://github.com/blueoran

[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1798 @marcaurele there appear to be Travis failures. Could you please check into them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request #1798: CLOUDSTACK-9631: API: affinitygroupids or aff...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1798#discussion_r90372709 --- Diff: api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java --- @@ -96,6 +96,10 @@ public Long getId() {

[GitHub] cloudstack pull request #1777: clearCLOUDSTACK-9133: Two volume.delete usage...

2016-11-30 Thread priyankparihar
Github user priyankparihar closed the pull request at: https://github.com/apache/cloudstack/pull/1777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 Hi @jburwell, do you think we can merge this in master or you are in a code freeze for 4.10.0.0 ? Thanks, --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 @resmo I've updated the PR. I've tested the simulator and marvin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/828 LGTM. This patch has been working well in production for over a year now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/828 @rhtyd Rebased against lastest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread prashanthvarma
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @jburwell Thank you for the update, I was planning to investigate the same test failure (test_router_dhcp_opts) as unlike other test failures it looked like an actual reproducible issue f

[GitHub] cloudstack issue #1711: XenServer 7 Support

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1711 @syed yes, you will add the changes to `schema-4910to4920` for the `4.9` port. This will cover anyone upgrading from a version >= 4.9.1.0 to 4.9.2.0. I do not plan to automatically forward me

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90342302 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90342459 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack issue #1803: CLOUDSTACK-9636: The host alerts box should be named...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1803 @nitin-maharana could you please add screen shots of the change to the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341780 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90340642 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341385 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341157 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341463 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341553 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90340513 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90341649 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90339611 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90339269 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90315044 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -111,37 +116,37 @@ public CertServiceImpl() { @DB @O

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90310482 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90310924 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90339078 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90315713 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -180,16 +185,16 @@ public void deleteSslCert(DeleteSslCertCmd deleteS

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90338425 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd deleteS

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90314823 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90339460 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90313790 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword()

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90315176 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -111,37 +116,37 @@ public CertServiceImpl() { @DB @O

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90309869 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90315448 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -150,26 +155,26 @@ public SslCertResponse uploadSslCert(UploadSslCertC

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90312936 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90340246 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90312667 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90338915 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90315376 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -111,37 +116,37 @@ public CertServiceImpl() { @DB @O

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90338636 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd deleteS

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90314765 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -176,18 +176,18 @@ public void runUploadSslCertSelfSignedWithPassword

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90314781 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -226,14 +226,14 @@ public void runUploadSslCertSelfSignedNoPassword()

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90310643 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90312334 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90311210 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90310775 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-11-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90310270 --- Diff: utils/src/main/java/com/cloud/utils/security/CertificateHelper.java --- @@ -40,123 +46,122 @@ import java.util.ArrayList; import jav

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2016-11-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 Addressed all the changes suggested and rebased. With vSphere 4.0/4.1, when the ports per dvportgroup is set to less than 256 (current default), then it is set to the default 256, else it

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Trillian test result (tid-509) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33518 seconds Marvin logs: https://github.com/blueoran

[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1801 Trillian test result (tid-510) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33387 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 @pdion891 I would say merge #1435 first --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 @resmo could you do a PR on top of #1435 ? or this have to be merged first? so we can get your chances and some of mine. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 So, should we go forward and merge #1435 + #1769 to master? I might just need to rebase and update version number of the current commit. With those 2 PR, we would have master back o

[GitHub] cloudstack issue #1711: XenServer 7 Support

2016-11-30 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1711 Thanks Guys for testing this out. I had a question @jburwell You wanted me to port this to 4.9 and then it would be forward merged to 4.10 and master. How would the DB changes be handled? right now

[GitHub] cloudstack pull request #1803: CLOUDSTACK-9636: The host alerts box should b...

2016-11-30 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1803 CLOUDSTACK-9636: The host alerts box should be named as hosts in Alerts. The host Alerts box shows hosts in Alerts. The name host Alerts is misleading, it should be changed to hosts

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1579 @prashanthvarma the redundant router/VPC failures are known. We have a fix pending for the `test_snapshot` failures in XenServer (#1800). However, I am concerned about that`test_router_dhcp_o

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov there is a Jenkins failure, but the results page returns a 404. Could you please re-push this PR to re-trigger the Jenkins/Travis run by running `git commit --amend --no-edit &&

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1579 @prashanthvarma please ignore my last comment. It appears that we have found an issue with the `test_router_dhcp_opts` test case. #1801 has been submitted to fix it. Once #1800 and #1801 hav

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1579 Trillian test result (tid-507) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40678 seconds Marvin logs: https://github.com/blueoranguta

  1   2   >