[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r100478202 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1727 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r100477949 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Travis CI test cases failure in PR 1908

Hi, In PR 1908 few of the test cases are failing which are not related to the this. vgpu test case is failing. I think this test is not required to run on simulator. Is this the same case for all or I am only getting these error. https://github.com/apache/cloudstack/pull/1908 Thanks, Jayapal

[GitHub] cloudstack issue #1936: [CLOUDSTACK-9773] API: don't break API output with n...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1936 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1727 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @karuturi Test passed. Two LGTM received. Looks like it is ready for merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1747 Trillian test result (tid-808) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32193 seconds Marvin logs:

Re: [GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

If no action is being taken, the valid answer is to return null. This will make the listener logic to try the next listener On Thu, Feb 9, 2017 at 6:00 AM, koushik-das wrote: > Github user koushik-das commented on a diff in the pull request: > >

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rafaelweingartner @koushik-das @karuturi Great, I've re-targeted PR to master branch. Thanks for your help! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 @DaanHoogland: yes, I want it run in Trillian, but my understanding is that manual steps need to be taken in the test setup for Trillian in order to first build the SystemVM from this PR and then

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill I know and work needs done. On the other hand, you mentioned you wanted to see this run in trillian. You still want that? Else I will skip and just review the code tomorrow.

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 @DaanHoogland did you make the test run in Trillian install a SystemVM built from this PR? If you didn't it won't actually be a valid test run... --- If your project is set up for it, you can

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1727 Perfect @nvazquez Thanks for all of the hard work 👍 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1282 @Slair1 Its missing required reviews and tests.(We have a huge backlog. any help in code review/test run is welcome). please refer to

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1727 Its an enhancement. It should be for the next major release which is 4.10(on master branch) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

Github user Slair1 commented on the issue: https://github.com/apache/cloudstack/pull/1282 @anshul1886 any idea why this hasn't been merged yet? are there concerns/issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1747 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1747 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1747 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1747 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1747 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1741 I started a build yesterday but am not at my computer today. I'll look at the results later. Biligual auto correct use. Read at your own risico On 8 Feb 2017 4:58 pm,

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 Here is the CI run for this PR using my KVM Bubble environment. This CI run is using a SystemVM built from this PR branch (required for a valid test) and since we have not been able to do that

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 ### CI RESULTS ``` Tests Run: 87 Skipped: 1 Failed: 4 Errors: 0 Duration: 9h 13m 51s ``` **Summary of the problem(s):** ```

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rafaelweingartner excellent, I added both test cases on `VMSnapshotManagerTest`, thanks! @koushik-das thanks for pointing that out, I agree with you that db changes should be in

[GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1906#discussion_r100281158 --- Diff: plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java --- @@ -156,7

[GitHub] cloudstack issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the ca...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1930 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1933 @abhinandanprateek Looks like there is another PR #1856 related to this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r100267498 --- Diff: setup/db/db/schema-490to4910.sql --- @@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis