Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111591078
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2044
ah ok, I was not aware of that @serg38 . I'll look it up, except from not
enabling the feature, how would you handle this?
a. To not allow restore
b. To recognise that the disk
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2044
@serg38
ad 1. yes they can, if you look in the ticket there is a part of
description that describes this possibility. But that said I don't see how
restore is going to be hindered
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568764
--- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java
---
@@ -28,6 +28,8 @@
"API end point. Can be
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r11156
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568831
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568225
--- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
@@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
show me the money (tm)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/2030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
renaming and close-opening for retests. "it works on my laptop (tm)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/2044
CLOUDSTACK-9877 Cleanup unlinked templates
This implements CLOUDSTACK-9877 by marking templates for gc when
1. the template they where created with is deleted from cloudstack
2
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2032
LGTM, checked the source
$ grep -r 4.9.3.0
no hits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1997
so that is two situations
1. it is known to be powered off (no sendStop() should be performed at all)
2. it is unknown because their is no report. Wouldn't one first check the
host
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2024
trivial enough: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1997
@jayapalu your check is ok, what is not ok is that it is needed. Somehow a
stop can be send to a VM for which no host is known?
I am worried about the reason of your fix and that we
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2023
@karuturi I think it is easiest to just reapply and not search for the
cause of an 8 month old PR resulting in conflicts. (if the original code has
the right URLS in it)
---
If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2022#discussion_r108918688
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ---
@@ -1477,6 +1493,40 @@ public static String
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2023
LGTM
@kishankavala did you check what went wrong with the kvm template.
@karuturi reported that and it was probably some auto-conflict-resolution.
---
If your project is set up
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1980
LGTM (based on code only)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2011
thanks @ustcweizhou
@karuturi can we merge this? and merge forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi I hade a brief peek, #1982 does not have templates for lxc or
ovm3, so that at least is one problem.
I think it needs to be reverted and recreated, probably on top of this one
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2011
@ustcweizhou this enables looking for a nic by a name like a1b2c3
(\D+\d+\D*\d*\D*\d*) it will also allow all shorter as long as they start with
which makes sense. But to satisfy
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi the intent of this PR was never to change any of the templates,
only the locations. I see some changes in there that I think are the result of
the many rebasing this PR has
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2003
code LGTM but @ustcweizhou 's patch still makes sense to me. Maybe you can
add that separately? travis still fails!
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r106675353
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi I rebased on latest master, is anything else expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r106667548
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
sorry @karuturi should I update? This is really not on my radar that much
anymore. I will look at it this afternoon.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@ustcweizhou @sebgoa @rhtyd can you review this as a first version of an
integrated plugin for application clusters. It is still very k8s specific and I
want to defer making it more
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan test centos7 kvm-centos7
component/application_clusters/test_application_cluster_life_cycle.py,component/application_clusters/test_application_cluster_provisioning.py
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi @wido @rhtyd @swill @pdion891 @rafaelweingartner
I see the system VMs pointed to are still those in the 4.6 directory on the
download servers. Is that really intended? I
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
So this PR will be useless as is!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/669
@rafaelweingartner good improvement. @anshul1886 can you merge Rafael's
stuff? He addresses the code doublure and the generic exception.
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package centos7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package centos7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r105162233
--- Diff: packaging/centos63/cloud.spec ---
@@ -445,7 +445,7 @@ grep -s -q "db.usage.driver=jdbc:mysql"
"%{_sysconfdir}/%{name}/m
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1995
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
ping @rhtyd @swill @chiradeep @NuxRo @pdion891 @wido @karuturi
I rebased
please send me any pull requests on this if you feel extra is needed.
---
If your project is set up
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@ustcweizhou of course. It is still work in progress but all changes needed
will be added in time.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1779
Looks good to me, @rhtyd are your concerns met?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1988
WIP: CLOUDSTACK-9815 intergration of ApplicationClusterService
this external plugin will be integrated as core plugin. It was originally
created as plugin on 4.5. bouncycaste needs
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103890661
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103872151
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1779
@priyankparihar I agree that host should not show as up but indeed why hide
it? Unless we show no details for an unmanaged cluster we should be able to
find the host in there. It should
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1960
I went through the code and found no real issues. for any other reviewers I
recommend reading the FS first. It is quit a big chunk but very neat.
LGTM
---
If your project is set
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -74,7 +74,7
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221221
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
[1768.network.results.txt](https://github.com/apache/cloudstack/files/805988/1768.network.results.txt)
[1768.vpc_routers.results.txt](https://github.com/apache/cloudstack/files/805989
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@rhtyd I don't see how your concern is more true for the new code by
@marcaurele then it is true for old code. cleanup is still going to be executed
after the scripts, is it? only directly
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103207344
--- Diff: .travis.yml ---
@@ -42,13 +42,18 @@ env:
smoke/test_dynamicroles
smoke/test_global_settings
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103210828
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103212736
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForZoneCmd.java ---
@@ -0,0 +1,115 @@
+// Licensed to the Apache
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103212914
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@BlueOrangUtan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@BlueOrangUtan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@syed the -cleanup scripts are for removing data that had been migrated,
not for temporary tables. also a use case for those may be if things are done
partly in the migrate script
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1944
seen it work in practice: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@karuturi I think this should go in. Even being a bit of a risk, it will
potentially reduce the support hours on upgrades.
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It
is not encoded in older upgrades. Unless we clean those upgrades up we will
have some issues.
---
If your
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
LGTM but
I hope you appreciate the concerns @marcaurele , on the other hand let's
fix what breaks and make sure the 4.9 to 4.10 works with this. We can always
advice to upgrade to 4.9
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/859
@kishankavala i forgot about this one, guess we won't make 4.7 ;)
can you appease cloudmonger?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@swill I know and work needs done. On the other hand, you mentioned you
wanted to see this run in trillian. You still want that? Else I will skip
and just review the code tomorrow
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I started a build yesterday but am not at my computer today. I'll look at
the results later.
Biligual auto correct use. Read at your own risico
On 8 Feb 2017 4:58 pm
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/844
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/844
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1929
@milamberspace could you try with this patch? I think @ustcweizhou solved
your problem with the default route
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/977
hey @kiwiflyer (not related to the PR at hand) I see that this PR is not
reported on acspr.enu.net as ci complete. Is that a bug?
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1858
If we have to
On Thu, Dec 22, 2016 at 9:02 PM, Milamber <notificati...@github.com> wrote:
> LGTM and Happy holidays!
>
> â
> You are rece
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez unfortunately I no longer am involved in cloud computing. I'd
really need a deep dive to give value, sorry.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
valid points @chiradeep but I think they both warrant separate PRs, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
I think we can remove all templates from prior versions, from the code that
is. As for the repo, only if we know it is no longer being used. I think we at
least need to give a heads up
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
I removed it in the last commit. download,apachecloudstack.net points to
cloudstack.apt-get.eu. Did I miss one or Do you mean to remove the domainname?
---
If your project is set up
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
pinging some people as this might need attention @swill @chiradeep
@pdion891 @wido @shapeblue ( @rhtyd @jburwell @abhinandanprateek ;) @accelarite
(@rajani @koushik-das ...?)
I
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@swill Pinging @ustcweizhou again, I know leaseweb has an interest in this.
They use advanced zones in several different setups so their ok is a good
indication we can merge (together
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1530
@swill @jburwell is this one ok?
@bvbharat I don't see anything in the link in your comment so I must assume
the failure is in the test itself
If we don't merge this I will close
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1582
CLOUDSTACK-9408 for the move away from download.cloud.com
- commented some occurences of cloud.com as being harmless
* examples
* identifiers (internal)
- changed
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1582
CLOUDSTACK-9408 for the move away from download.cloud.com
- commented some occurences of cloud.com as being harmless
* examples
* identifiers (internal)
- changed
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Yes @wido ,they look good to me but I am not running a cloud at the moment
so hence I asked @ustcweizhou to have a look.
He had concerns but I did not see him react since.
The test
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1582
CLOUDSTACK-9408 for the move away from download.cloud.com
- commented some occurences of cloud.com as being harmless
* examples
* identifiers (internal)
- changed the URL
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1531
@remibergsma @rhtyd :+1: let's add the packer project and phase out the old
template builds. more decoupling and (i suspect) simpler build process.
---
If your project is set up
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
CI Results: ok one test failed but retest manually succeeded
[1547.results.network.txt](https://github.com/apache/cloudstack/files/300726/1547.results.network.txt)
[1547
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@wido, I am not in favour of squashing these. They seem to be different
fixes with their own history. I will start an integration run.
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1575
@romain-dartigues in such cases you can fetch the branch of the submitter
in your own workspace and build on top of it, push to your own fork on github
and open a PR from that. When
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1557
No I am talking about the problems with TrustAllManager. I am not convinced
there is a problem by the not by @rodrigo93 .
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1557
@rodrigo93 @rafaelweingartner Do you have a scenario that proves these
methods to be a problem? returning true or null (or void) does not imply a
problem unless the result can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1542
@nvazquez sounds great, keep us posted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger
1 - 100 of 1779 matches
Mail list logo
