Re: Review Request 27652: Normalize error message strings to make maintenance of said strings a bit easier.

2014-11-06 Thread Derrick Schneider
. To reply, visit: https://reviews.apache.org/r/27652/#review60111 --- On Nov. 6, 2014, 12:46 a.m., Derrick Schneider wrote: --- This is an automatically generated e-mail. To reply, visit

n00b question about code cleanup fixes

2014-11-05 Thread Derrick Schneider
Hey, all. I just downloaded and got Cloudstack building on my dev machine, and I had a question about a minor code-cleanup issue I saw. Specifically, in DatabaseUpgradeChecker, there's this: if (Version.compare(trimmedCurrentVersion, upgrades[upgrades.length - 1].getUpgradedVersion()) !=

Review Request 27652: Normalize error message strings to make maintenance of said strings a bit easier.

2014-11-05 Thread Derrick Schneider
value into a variable, I simply did a build to make sure everything was still good. If there's other stuff I can do, please advise. Thanks, Derrick Schneider

Re: n00b question about code cleanup fixes

2014-11-05 Thread Derrick Schneider
Thanks! Submitted. It's nothing major. Just something I noticed while I was in that code. On Wed, Nov 5, 2014 at 12:43 PM, Wido den Hollander w...@widodh.nl wrote: On 11/05/2014 07:28 PM, Derrick Schneider wrote: Hey, all. I just downloaded and got Cloudstack building on my dev machine