Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r57577607
--- Diff: core/src/com/cloud/agent/api/storage/CopyVolumeCommand.java ---
@@ -75,4 +76,12 @@ public boolean toSecondaryStorage() {
public
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-199133805
@bvbharatk Thank you for running the marvin tests. Do you think any
specific test that is failing on this branch ?
---
If your project is set up for it, you
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/36#issuecomment-199133110
@GabrielBrascher all suggestions are good, made them for some i will have
to tune the code, will do that too.
---
If your project is set up
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-197830412
Marvin test log for testing ospf:
nosetests --with-xunit --xunit-file=/tmp/simulator/smoke/test_quota.xml
--with-marvin --marvin-config=/root
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/36
OSPF: WIP formatting documentation for ospf
WIP: documentation for ospf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-198251894
Documentation PR is here
https://github.com/apache/cloudstack-docs-admin/pull/36
---
If your project is set up for it, you can reply to this email and have
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r51858432
--- Diff: setup/db/db/schema-471to480.sql ---
@@ -27,3 +27,10 @@ ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url`
varchar(2048);
ALTER
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-176082402
@DaanHoogland I agree there should be some guideline on code style. If
these are there I think most of us will be willing to follow these. I guess
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175931632
This code that was suggested:
private AccountVO createAccountVoForType(short type) {
AccountVO accountVO = new AccountVO
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175472278
This patch cleans up any find bug issues in cloud-framework-quota and
cloud-plugin-database-quota, verifiy output below. I think we should not delay
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1350#discussion_r51006727
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -197,4 +197,58 @@ public void
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175710627
@rafaelweingartner @bhaisaab I have taken out the duplicate account
initialisation.
---
If your project is set up for it, you can reply to this email and have
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175712977
@cristofolini your changes are incorporated can you review these.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1371
OSPF: WIP: adding dynamically routing capability to VPC
adding dynamically routing capability to VPC and adding config item
structure to VR quagga configuration
OSPF: zone quagga
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175500735
merging LGTM from @DaanHoogland and @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175656788
@rafaelweingartner It is only about realistic test data that is being
passed to the method tested. You should differentiate between the tested code
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175634392
@rafaelweingartner If it is a black box test then the person testing will
obviously try to pass a realistic data set, that is what I have done. It is
possible
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175624327
@rafaelweingartner quality is what we are discussing and I simply do not
think that putting 3 lines of object initialisation in a method will make it
high
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175601093
@rafaelweingartner Can you comment on the duplicated lines. There is a way
you can get to the code and comment there.
---
If your project is set up
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175603740
@rafaelweingartner if you mean initialisation of AccountVO to be moved into
a method, and replacing it with a method call. I guess I would prefer it this
way
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175408926
@cristofolini @bhaisaab @remibergsma test code split into simpler methods.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-175372328
@cristofolini it is not that involved a code and not something that i can
reuse.
But yes i will take a holistic look at the code and refactor when I get
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1353
OSPF: WIP: adding dynamically routing capability to VPS
Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9163
FS:
https://cwiki.apache.org/confluence/display/CLOUDSTACK
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172418090
@remibergsma @bhaisaab made review changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-171865987
tag should not be a reason for incompatibility. that is you can mover from
a service offering that is similar but with any other set of tags. we should
just do
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1303
QuotaStatementTest: fix the method invocation verification
Quota emails are send at start of the month, that triggered the
sendQuotaAlert that was not getting invoked earlier.
You can
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1306
4.7 quota test
engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0
QuotaStatementTest: fix the method invocation verification
You can merge this pull request into a
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1289
Quota: findbug fixes
Findbug fixes for cloud-framework-quota and cloud-plugin-database-quota.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1281#issuecomment-166833361
sure !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1254#discussion_r47990946
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
@@ -59,7 +59,7 @@ public QuotaSummaryCmd
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1254
CLOUDSTACK-9174: A deleted account results in NPE
When an account is deleted from cloudstack for which quota is still
being calculated and if the quota reaches minimum threshold
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-165325933
@nitin-maharana @koushik-das @kishankavala @bhaisaab @jburwell
@DaanHoogland @remibergsma Can we have a discussion on: Why do we need any kind
of restriction
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-165102057
@nitin-maharana i am wondering why should change in service offering have
any restrictions on tags ? @kishankavala any usage implications.
---
If your project
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-165001244
Moving the test to test/integration/plugins folder as in most automated
environment this will either fail or not run, due to the MS restart required
to enable
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164652898
@DaanHoogland this is what I did:
1. Created a simulator environment
2. Deployed the datacenter using the cfg above,
3. checked the DB and confirmed
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163939898
Sorry, I just started looking at PRs, next time I will elaborate on my LGTM.
For this particular one when a account is deleted it leaves the ssh key
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163940491
Elaborating on my LGTM: The changes are in right upgrade path. The sql
script is error free. It adds guest os support for 6.0 excluding the ones
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163879371
@milamberspace pt_BR updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163879896
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1194#issuecomment-163880656
Closing it as translations are submitted via transfix website.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47334512
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1194#issuecomment-163586496
@GabrielBrascher Noted, I think I need to submit translation via Transfix.
I am working on it.
---
If your project is set up for it, you can reply
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-163834017
@nitin-maharana The current way was to move the service offering to a
similar or a more flexible one in terms of deployment. While this change will
make the new
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163835153
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1194#issuecomment-163158903
@milamberspace will give it a try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-163178775
checking. cc @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1201
CLOUDSTACK-9131: Create a new API to check if the plugin is enabled.
Adding a new command to check if the quota plugin is enabled.
Also changed the command version to 4.7.
You can
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1205
QUOTA: Ensuring that the dates displayed are as per user expectations
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1193#issuecomment-163479275
Closing this to change the case of the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1194
CLOUDSTACK-9125: Brazilian translations
The pull request contains brazilian translations for quota labels.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1192
CLOUDSTACK-9122: future credit etries should be incorporated when theâ¦
future credit etries should be incorporated when the balance is calculated
1. Some code is refactored so
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1193
QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162529656
@bhaisaab @remibergsma there is still one issue that I am looking at now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162595100
@bhaisaab the issue is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796541
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796893
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796854
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/188#issuecomment-132160851
Yes this was committed.
On 14-Aug-2015, at 2:48 pm, Rohit Yadav notificati...@github.com wrote:
Was this merge on master?
â
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/188#issuecomment-95858828
Was thinking of more of a script with a wizard interface, instead of bunch
of scripts, that guides the user during upgrade.
Some suggestions:
A way to fix
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/188#issuecomment-95811296
It appears that some functionality still needs to be completed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/186#issuecomment-95016103
Reviewed it, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
65 matches
Mail list logo
