Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216487485
@swill I think you mentioned the wrong Boris :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1400
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1391#issuecomment-179292599
New PR with additional fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500
@DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few
---
If your project is set up for it, you can reply to this email and have your
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1391
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1384#issuecomment-178064538
LGTM :+1: Based on screenshots and code-review
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1386#issuecomment-178064345
LGTM :+1:
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1383#issuecomment-178064659
LGTM :+1: Based on codereview
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178000474
Integration test results:
```
Test router internal advanced zone ... === TestName:
test_02_router_internal_adv | Status : SUCCESS ===
ok
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1389
Restore iptables at once using iptables-restore instead of calling ip
tables numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1364#issuecomment-174861340
LGTM :+1:
Already running in production at SBP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174492298
LGTM :+1:
Based on integration tests and code-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1362#issuecomment-174225635
Finally! :-)
LGTM :+1: Based on code-review and screenshots!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173872641
@DaanHoogland It improves performance due to fact firewall rules are only
created (in memory) once we expect a change. If for example a dhcp lease needs
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1356
More VR performance!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance-wip
Alternatively you
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1334#issuecomment-173364778
LGTM :+1:
Based on code review and screenshot from remi
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50335474
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -190,4 +196,28 @@ Use
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50325672
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -48,6 +49,9
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50325617
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -1,4 +1,5
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50241366
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-173184982
Most of them have already been resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/886#issuecomment-173185222
When the network stack get's refactored this won't be necessary anymore.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/720#issuecomment-173186487
Been open for 3 months, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1340#issuecomment-173184740
LGTM :+1:
Reviewed code, and according to the screenshots it works.
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763
No reviews, so closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634
Closing because of preference to logback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1232#issuecomment-173186549
Closing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580
Closing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1346
Enhance VR performance
Will post integration test results soon!
Ping @wilderrodrigues @remibergsma
You can merge this pull request into a Git repository by running
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055
LGTM :+1:
Did code review and ran the PR in beta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1293#issuecomment-172248684
LGTM :+1:
Been running in beta for a couple of weeks now, no problems!
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1329#issuecomment-172247093
LGTM :+1:
delaycompress isn't usefull. The VR has limited space, so delaying the
compression of the logfiles won't help!
---
If your project is set
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-171681534
@wido @kevindierkx Why not use TEXT? Then we'll never have to worry again
:-)
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1327#issuecomment-170505131
It's sorted! LGTM
 {
cloudStack.plugins
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1285#discussion_r48488856
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -111,19 +114,27 @@ public LdapAuthenticator
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1285#discussion_r48498393
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -111,19 +114,27 @@ public LdapAuthenticator
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166411739
LGTM :+1:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1227#issuecomment-164146356
Nice! LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164177113
@milamberspace @remibergsma @DaanHoogland LGTM :+1:
Only did code review.
---
If your project is set up for it, you can reply to this email and have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657
LGTM :+1:
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164065917
LGTM :+1:
Ran tests on Ubuntu 14.04
```Create a redundant VPC with two networks with two VMs in each network
... === TestName
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1224
CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory
structure.
Ping @wilderrodrigues @wido @remibergsma @miguelaferreira
Refactored the `Apache CloudStack Plugin
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163536301
@wilderrodrigues @remibergsma I could only verify for KVM.
Ran tests on Ubuntu 14.04 management/hypervisor.
```
Test to verify access
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163568069
@wilderrodrigues @remibergsma @DaanHoogland LGTM :+1:
Better styling this way.
No unit or integration tests run. Though in this case I don't
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1195#issuecomment-163229139
@wilderrodrigues @remibergsma LGTM :+1:
```Create a redundant VPC with two networks with two VMs in each network
... === TestName
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1189#issuecomment-162941648
Hi @wilderrodrigues,
I tested it just now! Looking good! Ran against Ubuntu 14.04 KVM
management/hypervisor.
```
Test redundant router
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/26#discussion_r45843949
--- Diff: source/global.rst ---
@@ -28,7 +28,7 @@
.. |sysvm64-url-ovm|replace::
http://cloudstack.apt-get.eu/systemvm/4.6
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1105#issuecomment-158918940
Hi @bhaisaab, what do you mean with "fix the scripts in src paths" ? Regards
---
If your project is set up for it, you can reply to this email and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1108#issuecomment-158981153
I agree with @DaanHoogland, less is more! Thanks for your contribution.
I'll run integration tests on it to show nothing breaks.
---
If your project is set up
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1105#issuecomment-158980731
@bhaisaab Ah, i've already looked them up, and in fact, in the git repo,
they have the +x flag. So during the install, they have that flagged stripped
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1105
Debian/Ubuntu packaging issues
See individual issues.
Before:
```
root@acs46:~# ls -la /var/lib/cloudstack
total 16
drwxr-xr-x 4 root root 4096 Nov 23 00:20
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1095
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158344376
@remibergsma Of course I tested manually! Nice Jenkins Job btw ;)
I see three LGTM's, two of which are based on code review, one on running
integration
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1084#issuecomment-158017282
@wilderrodrigues LGTM :+1:
Always in support of removing old/dead code! :)
Testing:
CentOS 7.1 Setup Managment/Hypervisor
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1084#issuecomment-158020779
@jayapalu That's we're git's versioning system comes into play. We want to
keep the current working directory as clean as possible. Meaning, without
unused/dead
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158021643
@remibergsma Agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1095
CLOUDSTACK-9076: Changed ownership of directory /var/lib/cloudstack to
cloud.
Now the management server can create directories inside this folder.
It's a packaging issue. Testing
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1070#issuecomment-158036108
@miguelaferreira @remibergsma @wilderrodrigues LGTM :+1:
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zone1-kvm1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158062783
@wilderrodrigues Fixed your comments, refactoring is for the next round ;)
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157697285
@DaanHoogland You're right. Forgot to remove it in my last iteration.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157551229
Ping @wido @remibergsma @wilderrodrigues @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1083
CLOUDSTACK-9062: Improve S3 implementation.
The S3 implementation is far from finished, this commit focuses on the
bases.
- Upgrade AWS SDK to latest version.
- Rewrite S3
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156414832
@DaanHoogland That's already being done by @wilderrodrigues. Therefore this
one is obsolete.
---
If your project is set up for it, you can reply to this email
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156384240
@dsclose Thanks for your PR, it shows support! As the script is not in use
anymore, would you close the PR?
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1065#issuecomment-156394882
LGTM :+1:
Improving comments, always :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1064#issuecomment-156253559
@wilderrodrigues Thanks for fixing! Will run tomorrow or this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275233
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /va
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275343
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /va
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1036#issuecomment-155071567
LGTM, deployed on Ubuntu 14.04 with Tomcat6. Working fine! :+1:
