[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-04-05 Thread cloudsadhu
Github user cloudsadhu commented on the issue: https://github.com/apache/cloudstack/pull/1813 added logic to handle global level full clone setting. full clone parameter are handled differently (as per code its referring in 3 places due to that even if we set the full clone

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-30 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r108862410 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,36 +134,46 @@ def test_00_deploy_vm_root_resize(self): # 2

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-26 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r108092328 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self): # 2

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-14 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r106085688 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self): # 2

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-13 Thread cloudsadhu
Github user cloudsadhu commented on the issue: https://github.com/apache/cloudstack/pull/1813 @serg38 - thanks for your comment- I have added nfs support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-23 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1458#issuecomment-213686569 Thanks Swill and now All the checks are passed.Please merge this PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-21 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212828874 reviewed your code change and looks good. Please post the test result. LGTM based on code review !! --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

2016-04-21 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-212766999 LGTM based on the code review !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-11 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1458#issuecomment-208331373 HI, Thanks for your review comment and i ran the few tests on the created setup even though it won't impact the any testcases but for your request i

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-06 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1458#issuecomment-206272202 I have incorporated the all the review comments and squashed all my commits to single commit. This script prepares setup required to run advanced

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-01 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1458#discussion_r58188259 --- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg --- @@ -0,0 +1,191 @@ +{ +"

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-01 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1458#discussion_r58188294 --- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg --- @@ -0,0 +1,191 @@ +{ +"

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-01 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1458#discussion_r58188213 --- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg --- @@ -0,0 +1,191 @@ +{ +"

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

2016-04-01 Thread cloudsadhu
GitHub user cloudsadhu opened a pull request: https://github.com/apache/cloudstack/pull/1458 BUG-ID:CLOUDSTACK-9331:added code in marvin frame config file for advBaremetal support … Added code in marvin framework config file to support baremetal advanced testcases You can

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2016-02-02 Thread cloudsadhu
Github user cloudsadhu closed the pull request at: https://github.com/apache/cloudstack/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2016-02-02 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/691#issuecomment-179025093 for same issue Another PR created and checked in master so closing this PR request. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-12-15 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1048#issuecomment-164737419 Sure please find the test results below: @summary: Test volume delete event generation in error state condition ... === TestName

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-11-09 Thread cloudsadhu
GitHub user cloudsadhu opened a pull request: https://github.com/apache/cloudstack/pull/1048 CLOUDSTACK-8731-checking usage event for delete volume checking usage event for delete volume. I have incorporated all the suggested changes. You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-08-27 Thread cloudsadhu
Github user cloudsadhu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/691#discussion_r38084154 --- Diff: test/integration/component/test_persistent_networks.py --- @@ -1459,6 +1459,135 @@ def test_delete_account(self): return

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-08-13 Thread cloudsadhu
GitHub user cloudsadhu opened a pull request: https://github.com/apache/cloudstack/pull/691 CLOUDSTACK-8731-checking usage event for delete volume @summary: Test volume delete event generation in error state condition ... === TestName: test_volume_delete_event_errorState | Status