[GitHub] cloudstack-docs issue #18: Removed support for Citrix XenServer

2016-07-14 Thread eriweb
Github user eriweb commented on the issue: https://github.com/apache/cloudstack-docs/pull/18 The change LGTM, perhaps you could refer to the PR or some info about the change? Also, is there a note in release notes? How should people with xenserver + nuage that upgrades

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-20 Thread eriweb
Github user eriweb commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1420#discussion_r60384237 --- Diff: packaging/centos7/cloud-management.service --- @@ -24,6 +24,7 @@ Description=CloudStack Management Server After=syslog.target

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-04-14 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-210016535 Quite horribly that we need those modules for a simple perl script of 58 lines (including license header and empty lines). Not related to your PR though, but a good

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

2016-04-04 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205507905 Would be great with a jira ticket to track it though :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

2016-03-31 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1455#issuecomment-203855979 @remibergsma @wilderrodrigues @borisroman you guys have been testing a lot previously, would this change work for you? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...

2016-03-19 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1446#issuecomment-198795359 Jira is used for more than you might think. It is used to build release notes as well as a metric in board reports for community activity

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

2016-03-19 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-198791923 Thanks for your PR @rafaelweingartner, for tracking purposes, would you mind creating a jira ticket and including the ticket id in the PR title? --- If your

[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...

2016-03-19 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1446#issuecomment-198789993 For tracking purposes, would you mind creating a Jira ticket for this, and add the jira ID to the title? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Is the project attempting a fork on Githu...

2016-03-19 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1442#issuecomment-197510472 You could close it by pushing a dummy commit. But yes, I have to agree that sending a PR is some weird communication form! --- If your project is set up

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-03-19 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-198256679 Would you mind running a broader test suite to verify that there are no regressions? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

2016-03-11 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-195361874 @rafaelweingartner that's not really an answer, and I stand my question. Have you done any testing? does the code compile? does unit tests run

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

2016-03-10 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-195069715 Have you done any testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does