[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153605360 I upgraded an existing xenserver setup with the changes in this PR. (clear the tags on xenserver and restarted the networks to recreated VRs with new systemvm.iso

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

2015-11-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153371665 :+1: (code review only) good improvement. A test case would have been nice. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153372412 Thanks @wilderrodrigues I will test this tomorrow morning IST --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153274765 did the following to test it on an existing XenServer setup (It has two networks egress_allow with default egress allow and isolated2 with default egress DENY

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43605823 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43612367 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/941#issuecomment-152971271 @kansal Can you address the localization concerns? Also, if possible could you provide screenshots of the change? --- If your project is set up for it, you

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152976291 though its beyond what this PR want to fix, maybe we could fix L403(hash == HASH_CONFLICT) and L406(hash != HASH_IGNORE) as well. --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-152993596 manually verified the fix. Before the fix: on list networks page, I see three api calls 1. list zones 2. list networks with SG groups 3. list

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-152994809 great find @nitin-maharana manually tested the fix In my setup, I had a vm with two nics isolated1 - 10.1.1.14 - default isolated 2

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru answe...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1015#issuecomment-153003386 LGTM (code review. no tests executed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1001#issuecomment-153004732 tested that all the english strings are loading fine and there are no JS/UI issues observed. :+1: LGTM --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43601287 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader

Re: Automatically trigger a new Jenkins build

2015-10-30 Thread Rajani Karuturi
Thats a good idea. I have seen other open source projects do it this way. (example: netty project) On demand build is a better way than doing for every commit change. especially when the code reviews are going on or there is WIP, its not intended to do a build on every commit or update. (The

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-30 Thread Rajani Karuturi
Jenkins though unstable is right at what it does. That is, if its green, the build works fine, there are no check style errors, there are no new PMD/Findbugs errors etc. On the other hand, Travis green/red doesnt say anything at the moment. It can be red due to a timeout and sometimes its green

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

2015-10-30 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1006#issuecomment-152493863 Manual Testing: Before: ssh_keypairs ``` mysql> select * from ssh_keypa

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

2015-10-30 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/982#issuecomment-152497680 manually tested by upgrading an existing xenserver setup and force reconnecting the host Before ``` [root@rjn-xen65-host plugins]# ls -la /etc

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-29 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152176166 Hi @k0zka are you saying it might be specific to tomcat6? Reverting the the change works fine. Do you think we should revert this until we find a solution

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

2015-10-29 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152148071 @wilderrodrigues can you clear browser cache (cmd +shift + del in firefox) or reload the page without cache using shift+f5 and then try? --- If your project

Re: Regarding JIRA permissions

2015-10-28 Thread Rajani Karuturi
Done. ~Rajani On 28-Oct-2015, at 11:41 am, Kshitij Kansal wrote: > Hi, > > Can someone please give me permissions to assign bugs to myself in JIRA? > Username: kansal > > Regards, > -- > Kshitij Kansal

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

2015-10-28 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/996 [4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UI This is a regression from commit af2f21894ce061faadc8cec29b901719303a29dc added vpcofferings to the select list

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-28 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151734282 @K0zka I have the same issue as @ustcweizhou no log, no error message. Just a blank page environment: management server running on centos 6.6 and tomcat

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151773344 @borisroman I started seeing below error messages on console and VR doesnt start. Is it related to this change? ``` [ 480.108811] "echo 0 &g

[GitHub] cloudstack pull request: CLOUDSTACK-8917 : Instance tab takes long...

2015-10-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/894#issuecomment-151394435 code LGTM. Its a nice improvement to have. Since remi already ran the tests, I am merging this. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8992 Allow 32 disks to b...

2015-10-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/980#issuecomment-151397659 I am running the tests for #980 and #983 together. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151721874 LGTM. All the tests in BVT tests pass. (I see some failures in scalevm and deployvm from iso tests but, they are environment issues) --- If your project

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8992 Allow 32 disks to b...

2015-10-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/980#issuecomment-151721813 LGTM. All the tests in BVT tests pass. (I see some failures in scalevm and deployvm from iso tests but, they are environment issues) --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-151086437 @snuf @NuxRo KVMGuru and LXCGuru are defined at https://github.com/apache/cloudstack/blob/master/server/resources/META-INF/cloudstack/server-compute/spring-server

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096712 3rd attempt. I hope it succeeds this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151047752 @borisroman yes this is real :) . I think this might exist in 4.5 as well. Haven't tested it there. I rebased with the current master --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150898083 copy-pasting mike's response from email ( http://markmail.org/message/bptis5kitr2chqcn ). looks like its still not working for him with vmware-managed storage

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150897664 I was concerned the code change is against the initial design and we may be doing it without understanding all the implications. But, since we dont have any better

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-10-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/849#issuecomment-151016206 @remibergsma thanks a lot for running the tests.. I rebased it with the current master --- If your project is set up for it, you can reply to this email and have

Re: Development and building of ui components

2015-10-25 Thread Rajani Karuturi
There might be a better but for simple js changes, I do the below and restart jetty $ cp ./ui/scripts/domains.js ./client/target/generated-webapp/scripts/domains.js $ rm ./client/target/generated-webapp/scripts/domains.js.gz $ cp ui/scripts/domains.js

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Rajani Karuturi
ure you got the right type of server?" is listed again in the > output. > > It seems VMwareGuru is invoked and it passes the CopyCommand on to the > SSVM, which claims it doesn't support the command. > > Thanks, > Mike > > On Thu, Oct 22, 2015 at 10:56 PM, Rajani

Re: [4.6] Can't create template or volume from snapshot

2015-10-22 Thread Rajani Karuturi
Mike, Can you please test on PR https://github.com/apache/cloudstack/pull/962? It fixes this issue. ~Rajani On 23-Oct-2015, at 7:29 am, Mike Tutkowski wrote: > I guess I should point out that my system VMs are all running on XenServer, > but I don't think that

RE: [4.6] Can't create template or volume from snapshot

2015-10-22 Thread Rajani Karuturi
ailto:dev@cloudstack.apache.org> Subject: Re: [4.6] Can't create template or volume from snapshot Hi Rajani, Just checking to make sure this is the PR you intended. It looks related to OVM3 only. Thanks! Mike On Thu, Oct 22, 2015 at 9:39 PM, Rajani Karuturi <rajani.karut...@citrix.com > wro

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-22 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-150203517 Thanks for taking this up @snuf. I am out of office and will be able to test it only on Monday. @NuxRo Can you try this please? --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-149889343 @NuxRo This is the exact value I used and which worked for me "Ovm3Guru" Just a check, did you restart the Management Server after changing t

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-149880562 Which why I think the fix should be in ovm3hypervisorguru -Original Message- From: "ustcweizhou" <notificati...@github.com>

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-149880641 What value did you give? It should be ovm3guru -Original Message- From: "NuxRo" <notificati...@github.com> Sent: ‎21-â

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

2015-10-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/959#issuecomment-149880745 Agree. -Original Message- From: "Wilder Rodrigues" <notificati...@github.com> Sent: ‎21-‎10-‎15 13:22 To: &q

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-149859553 after excluding ovm3 hypervisor using the "hypervisor.gurus.exclude" global setting, template creation from snapshot on kvm is successful. I don

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

2015-10-20 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/959#issuecomment-149782673 The code concerns(incase of stop-start on a slow network and the changes of outer while waiting infinitely) with it were not addressed. I am ok with merging

[GitHub] cloudstack pull request: [4.6][BLOCKER] CLOUDSTACK-8923: Create st...

2015-10-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/934#issuecomment-148684942 I ran BVT tests on a setup with two xenserver 6.5. I didnt see any new failures. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: [4.6][BLOCKER] CLOUDSTACK-8923: Create st...

2015-10-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/934#issuecomment-148696476 Thanks @DaanHoogland and @NuxRo . I will merge this in sometime. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: [4.6][BLOCKER] CLOUDSTACK-8923: Create st...

2015-10-15 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/934 [4.6][BLOCKER] CLOUDSTACK-8923: Create storage network IP range failed This is a regression from commit 0cd8c06f7dceaf999acf202862c5d1d580e7aa0e try-with-resource used at https

[GitHub] cloudstack pull request: [4.6][BLOCKER] CLOUDSTACK-8923: Create st...

2015-10-15 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/934#issuecomment-148346807 @NuxRo Can you test this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-10-15 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/888#discussion_r42110792 --- Diff: packaging/centos7/cloud-management.service --- @@ -15,22 +15,19 @@ # specific language governing permissions and limitations # under

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

2015-10-15 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148299850 @bvbharatk I agree. That would help is handle the stop start case as well. In addition if we could also make the outer while loop finite, that would be good. ie

[GitHub] cloudstack pull request: [4.6][BLOCKER] CLOUDSTACK-8923: Create st...

2015-10-15 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/934#issuecomment-148597263 @NuxRo for the benefit of the next reviewer, can you please outline the manual/automatic tests you executed? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

2015-10-14 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148077678 I think this issue is happening due to the outer while loops which got introduced in commit 50d756e87d26f0ac86e7897505ad2747735c4d5c The outer loop waits until

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

2015-10-14 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/931#issuecomment-147990778 Thanks @wilderrodrigues. I will run the tests tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

2015-10-14 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/931#issuecomment-148048131 Hi @wilderrodrigues I ran all the tests in smoke folder(BVT) on a setup with 2 xenserver 6.5 hosts in advanced zone. All the tests passed except the below

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/929 [4.7] CLOUDSTACK-8951: validation for config param "remote.access.vpn.psk.length" throwing error for value < 8 and value > 256 right now, 8, 256 are hardcoded in the c

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/927 [4.7] secure and hidden config values are returned as plaintext string secure and hidden config values are first unencrypted before returning them in the api. This is not desired

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/928 [4.7] CLOUDSTACK-8950 Hypervisor Parameter check is not performed for registerTemplate and getUploadParamsForTemplate API's Any string is allowed as hypervisor type from the api

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147749011 thanks for running the tests @remibergsma should we merge this PR since we have two reviews from @DaanHoogland and @remibergsma ? --- If your project is set

Re: 4.6 release

2015-10-13 Thread Rajani Karuturi
to knock off blockers in this week and create RC next week. ~Rajani On Thu, Sep 24, 2015 at 11:45 AM, Rajani Karuturi <raj...@apache.org> wrote: > (resending in plain text) > > Thanks Boris(@borisroman) for fixing 3 blockers. > > We now have 7 blockers for th

[GitHub] cloudstack pull request: Pr 906 912 bug zone wizard and adv search...

2015-10-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/915#issuecomment-147193430 LGTM(code review). As @remibergsma said on pr #912 this should be included in 4.6 since it already has two reviews with Daan testing it, I am going to merge

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-147289439 @pdion891 @remibergsma we already have a jenkins systemvm build which takes git branch as parameter. http://jenkins.buildacloud.org/view/parameterized/job

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

2015-10-11 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r41721892 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List volumes

Re: [SUSPECTED SPAM]new features in 4.6 ?

2015-10-08 Thread Rajani Karuturi
yes. they are in 4.6. merged from this pr https://github.com/apache/cloudstack/pull/806 ~Rajani On Fri, Oct 9, 2015 at 10:39 AM, Raja Pullela wrote: > Dustin, the changes to support VMWare 6.0 are in 4.6, I think. Can you > test the latest build on 4.6 to see if it

Re: Citrix References in Marvin

2015-10-05 Thread Rajani Karuturi
Dont know about [1] and [2]. [3]: they are simple data disks 1GB virtual size created from cloudstack and downloaded. they are used in tests for upload volume/template. We do not have a location to share them. Below are the links from my dropbox account.

Re: jenkins analysis and rat jobs

2015-10-05 Thread Rajani Karuturi
Thanks Daan. thats nice! Does it also show "in progress" state like travis? ~Rajani On Mon, Oct 5, 2015 at 3:25 PM, Daan Hoogland wrote: > H, > > As you have undoubtetly noticed the jobs at builds.a.o no longer comment in > our PRs after they are done. They do however

[GitHub] cloudstack pull request: CLOUDSTACK-8848 ensure power state is up ...

2015-10-04 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/909#discussion_r41109279 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java --- @@ -111,7 +111,19 @@ private void processReport(long hostId

[GitHub] cloudstack pull request: CLOUDSTACK-8848 ensure power state is up ...

2015-10-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/909#issuecomment-145423925 one minor comment. otherwise, LGTM (only did code review) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8848 ensure power state is up ...

2015-10-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/909#issuecomment-145436050 I will merge this once travis is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8868: use PasswordGenerator.ge...

2015-10-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-145255883 @wido we need another review. Also, since master is frozen, we cant push this at the moment. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

2015-10-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r40881830 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List volumes

[GitHub] cloudstack pull request: CLOUDSTACK-8808: Successfully registered ...

2015-10-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/901#discussion_r40881668 --- Diff: core/src/com/cloud/storage/template/QCOW2Processor.java --- @@ -75,6 +76,16 @@ public FormatInfo process(String templatePath, ImageFormat

Re: jenkins disk full ?

2015-09-30 Thread Rajani Karuturi
ck-4.2-systemvm64 > 3.1M ./cloudstack-4.4-auto-marvin > 334M ./package-rhel63-master-noredist > 6.8M ./test-maintenance-operations-master > 36G . > > On Tue, Sep 29, 2015 at 9:04 AM, Pierre-Luc Dion <pdion...@apache.org> wrote: >> David, Do you think you could do another cleanup o

[GitHub] cloudstack pull request: CLOUDSTACK-8808: Successfully registered ...

2015-09-30 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/901 CLOUDSTACK-8808: Successfully registered VHD template is downloaded again due to missing virtualsize property in template.properties We have multiple file processors to process different types

Re: [Blocker] test duplicated in test_scale_vm.py

2015-09-30 Thread Rajani Karuturi
I agree with Raja. BVT test case failures should be treated as blockers. Once the test issue is fixed, they might uncover new issues/regressions. ~Rajani On 30-Sep-2015, at 2:32 pm, Raja Pullela wrote: > The problem needs to be fixed - "have tested a solution that

Re: 4.6 blockers

2015-09-29 Thread Rajani Karuturi
As per the latest BVT reports, CLOUDSTACK-8876 should also be a blocker. I am bumping the priority of it. ~Rajani On 29-Sep-2015, at 5:06 pm, Sebastien Goasguen wrote: > Just checking JIRA, we have 5 blockers for 4.6: > >

Re: OVS Plugin documentation issues

2015-09-29 Thread Rajani Karuturi
On the docs link you sent, at the bottom right, there is a link which says “v:master”. clicking on it will show you a github edit link which is https://github.com/apache/cloudstack-docs/edit/master/rtd/source/networking/ovs-plugin.rst you can edit online and “propose the change”(which would

Re: Zone in RegisterTemplateCmd API

2015-09-27 Thread Rajani Karuturi
so many if-else statements :) I would prefer making zoneid optional and defaulting it to -1. simple and clear. ~Rajani On 26-Sep-2015, at 1:34 am, Boris Schrijver wrote: > Hi Patrick, > > We're using S3 and are facing the same issues. > > This would indeed be a very

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143542706 code LGTM. I am facing some issues with my devcloud4 setup and hence couldnt run tests. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143543503 @anshul1886 without the new method, how do you ensure that PowerStateUpdateTime is up to date for the vm? It may be a very old value and can be a false alarm(same

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143543557 Thanks for all the debugging and testing @remibergsma and @wilderrodrigues looking forward to see a stable master once again.. --- If your project is set up

Re: [BLOCKER] CLOUDSTACK-8848

2015-09-26 Thread Rajani Karuturi
Thanks for the update rene. Unfortunately I do not have a vmware setup to test. I will do a code review tomorrow and run some tests on xen to make sure its not breaking anything else On శని., సెప్టెంబర్ 26, 2015 at 17:39 అపరాహ్న, Rene Moser < m...@renemoser.net> wrote: I discovered the race

Re: 4.6 release

2015-09-24 Thread Rajani Karuturi
public traffic blocked in vm created using DefaultIsolatedNetworkOfferingWithSourceNatService Wilder Rodrigues Rajani Karuturi CLOUDSTACK-8697 Assign VPC Internal LB rule to a VM fails Wilder Rodrigues Pavan Kumar Bandarupally Once these are out of the way, we can start on first RC. Let us

Re: [Blocker] Egress rules are not configured in VR

2015-09-24 Thread Rajani Karuturi
Hi Raja, I think CLOUDSTACK-8905, CLOUDSTACK-8881 and CLOUDSTACK-8795 are all related. Wilder, Can you comment? ~Rajani On 24-Sep-2015, at 11:52 am, Raja Pullela wrote: > Hi, > > > > Hopefully this will be the last Blocker on the VR functionality ? > > Can

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-24 Thread Rajani Karuturi
@resmo I will find some time tomorrow to test this. Can you add steps to test please? Or are they already available on the other pr? On Thu, Sep 24, 2015 at 19:39 PM, resmo wrote: Github user resmo commented on the pull request:

Re: 4.6 release

2015-09-23 Thread Rajani Karuturi
tgoing public traffic blocked in vm created using DefaultIsolatedNetworkOfferingWithSourceNatService <https://issues.apache.org/jira/browse/CLOUDSTACK-8795> Wilder Rodrigues <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wilder.rodrigues> Rajani Karuturi

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-23 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-142520701 I am not merging this as I see a -1 from @wilderrodrigues @wilderrodrigues, unittests are added and steps to test are also available. Can you review again

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-23 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-142520584 Tested this on a xenserver 6.5 setup. delete host/storage pool/cluster/pod/network/zone are all successful. :+1: --- If your project is set up

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

2015-09-23 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/875#issuecomment-142807954 :+1: merging.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: jenkins disk full ?

2015-09-22 Thread Rajani Karuturi
Hi David, disk space issue again. Can you please do a little more cleanup? http://jenkins.buildacloud.org/computer/coohq-slave-01/executors/0/causeOfDeath ~Rajani On 18-Sep-2015, at 11:59 pm, David Nalley wrote: > I freed up a little bit of space, but we'll have to do

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

2015-09-22 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/875#issuecomment-142487306 I faced the same issue and using bento/centos6.7 fixed it. :+1: tested only in advanced --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8883: Resolved c...

2015-09-22 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/863#issuecomment-142491036 I tested this using redhat 6.3 as KVM hypervisor host is in UP state after stop/start of management server Force reconnect of the host also worked

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8883: Resolved c...

2015-09-22 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/863#issuecomment-142499721 ok. merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: new user in Jira

2015-09-22 Thread Rajani Karuturi
Hi PL, I added Patrick to the contributors list. I also added you to the PMC list on jira. ~Rajani On 23-Sep-2015, at 3:59 am, Pierre-Luc Dion wrote: > Thanks guys for the quick response. Ill recheck but I didn't had such a > great karma when we look at it earlier today.

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

2015-09-22 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/873 CLOUDSTACK-8896: allocated percentage of storage pool going beyond 100% This issue occurs when a volume in Ready state is moved across storage pools. While finding if the storage

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-09-21 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/860 CLOUDSTACK-8889: delete volume doesnt decrement primary store resource count Primary Storage count for an account does not decrease when a Data Disk is deleted belonging to the account

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-09-21 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/849#discussion_r39960628 --- Diff: api/src/org/apache/cloudstack/context/CallContext.java --- @@ -90,7 +90,13 @@ public void putContextParameter(Object key, Object value

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-20 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-141880230 I will change the default value to 10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

2015-09-20 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/857 Cloudstack-8885 added blocked connection listener for rabbitmqeventbus When rabbitmq connections are blocked(for example when rabbitmq is server is out of space), all the cloudstack

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-09-18 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/849 Cloudstack-8816 some of the events do not have resource uuids The key objects in the context map are sometimes String and sometimes object. This causes missing uuids when an entity put

[PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Rajani Karuturi
Hi all, There is little progress on 4.6 blockers this week. To release 4.6, we all should come together and fix the blockers. In recent days, master has broken multiple times with compilation failures/regressions. If master breaks, time spent on figuring out what happened and fixing it is time

<    1   2   3   4   5   6   7   8   9   10   >