[GitHub] cloudstack pull request: Feature cenik123 vpcvrr 1.1.1

2014-12-11 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/33#issuecomment-66652799 Hey folks, should be public now, sorry, I didn't realize :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Feature cenik123 vpcvrr 1.1.1

2014-12-02 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/33#issuecomment-65199170 Hey folks, Karl thanks for contributing. Looks like quite a bit of work! Rohit thanks for CC-ing me in :) It's a bit hard to read the pull

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-23 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56589622 Thanks for all the help Rohit! I'm sure to most people some bash script rearrangement looks boring, but nevermind that, to me it just feels good to sumbit more than

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56385199 thanks for testing rohit. We've never seen this (with xen). If you look at the error, ``` /dev/vda5: Superblock last mount time (Fri Sep 19 14:54

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56387394 sorry, nevermind the last comment. From the jenkins build log: ``` [2014-09-19 14:57:59] INFO: stoppping all virtualbox vms for jenkins + bundle

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56402358 Hey Rohit, looks like that did it. Can you try the outputs from http://jenkins.buildacloud.org/job/systemvm-refactor-CLOUDSTACK-7143/10/console when it finishes

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-17 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-55866128 Hey Rohit, like I thought, a ruby issue.I'm surprised RVM isn't enabled already since the build was already using it (I think...). The fix should be along

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

2014-09-08 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/17#issuecomment-54785217 Hey Daan, _this_ change is finedone as-is. Like Rajani mentioned, the other changes to that file could be ported, too. I'm +0 on that -- on the one hand, it's a good

[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/15#issuecomment-54600044 I'm afraid not. This fix actually counts on setJavaHome() succeeding -- but _after_ that, that value does not make it to JSVC. The call to daemon calls runuser which

[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/15#issuecomment-54626548 Sweet, thanks! Personally I think just having it on master is ok -- anyone that is likely to run into this issue is also likely to have configuration

[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread lsimons
Github user lsimons closed the pull request at: https://github.com/apache/cloudstack/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

2014-09-05 Thread lsimons
GitHub user lsimons opened a pull request: https://github.com/apache/cloudstack/pull/17 bugfix/CLOUDSTACK-7476 for 4.4 branch. See https://github.com/apache/cloudstack/pull/15 for the pull request that was merged to master associated discussion. You can merge this pull

[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-04 Thread lsimons
GitHub user lsimons opened a pull request: https://github.com/apache/cloudstack/pull/15 Fix CLOUDSTACK-7476: always pass along $JAVA_HOME On a secured environment (selinux w/ env_reset enabled in sudoers), the runuser command that is invoked by the daemon() function does

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-04 Thread lsimons
GitHub user lsimons opened a pull request: https://github.com/apache/cloudstack/pull/16 CLOUDSTACK-7143: Refactoring of the systemvm build process E-mail thread: http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3C7A6CF878-7A28-4D4A-BCD2-0C264F8C90B7

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-04 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-54490782 Hey Rohit, thanks for reviewing! We actually have a new vagrant-based component test setup for the systemvm to contribute, too; I'm working on extracting

[GitHub] cloudstack pull request: Pull request of changes in the cloud-ser...

2014-09-02 Thread lsimons
Github user lsimons commented on the pull request: https://github.com/apache/cloudstack/pull/14#issuecomment-54167891 Thanks Travis! So cool that this is working...the failure is due to the change here: https://github.com/schubergphilis/cloudstack/commit