[GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...

2016-03-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1438#issuecomment-200255385 @swill @DaanHoogland tested this PR - LGTM. All BVTs have passed with the exception of the following tests - test_07_list_default_iso - iso didn't exist

[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...

2016-03-18 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1427#issuecomment-198490086 LGTM Ran BVT with XS 6.5 - all the test passed with the exception of the following tests due to env issues: test_01_create_volume - ssh issue

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-166878523 @remibergsma can you merge these changes? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697 @remibergsma can you please check this commit and merge it in? Thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166878921 @remibergsma can you please merge this in? Thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1041#issuecomment-166879168 LGTM - changes look pretty straightforward. @remibergsma can you please merge this in. Thanks, Raja --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-166879406 @borisroman , @bhaisaab , this refactoring helps speed up BVT runs by reducing the number of VM deployments. we should get the test results to close on this PR

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-166879646 @remibergsma can you please merge this in? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-166879847 @remibergsma can you please merge this in? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-166880339 @runseb, this cannot be run via simulator. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-166880792 @remibergsma can you please comment on this PR, if it was merged ? thanks, --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151071811 +1 move this test out of BVTs - this was brought up on almost 3-4 weeks ago. @runseb - I guess, my understanding is - we need 100% passrate on all BVTs - we

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151070859 LGTM, I have tested this on a private setup and is working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-22 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-150153497 LGTM - skipping testing is designed with a purpose and this is exactly we should be using it for. As a as person running/maintaining the tests, someone would have

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-22 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-150168452 @miguelaferreira - we have discussed this on an earlier email. as Prashant said, In this case a test case is skipped because the setup does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-22 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-150171997 @miguelaferreira 100% passrate on the BVTs - if there are skipped cases you should/want to find out why they are getting skipped and fix them. If you are skipping

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-12 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147607738 Following are the tests that run on Simulator basic and adv - separately, please add ".py" to the end. Simul

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-02 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-145200154 @sanju1010 this is not the right file - the following file needs to be updated - https://github.com/apache/cloudstack/blob/94f1ebb60af320166206c213e18b97a177bc145a

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Removed duplicate test f...

2015-09-30 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/900#issuecomment-144346102 LGTM! Thanks Sanjeev! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8883: Resolved c...

2015-09-22 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/863#issuecomment-142499253 Thanks Boris, the functionality is working now- agent log shows reconnecting to MS when a connection is lost. Let's merge this! --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-20 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-141879610 All Failed Tests integration.smoke.test_vm_snapshots.TestSnapshots.test_01_test_vm_volume_snapshot All Passed Tests

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-20 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/842#issuecomment-141878785 Ran XS Basic/EIP BVTs and passrate is at 97% - couple of tests failed due to unrelated bug/issue. --- If your project is set up for it, you can reply