[GitHub] cloudstack pull request: Add Unit Tests for Libvirt/KVM storage co...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/986 Add Unit Tests for Libvirt/KVM storage code These classes were not covered by Unit Tests and this commit adds some tests for their basic functionality. You can merge this pull request

[GitHub] cloudstack pull request: Removed unused code from the EngineHostDa...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/942#issuecomment-151547785 Based on the fact that all the code builds and the UnitTests are also running properly I can give this one a LGTM --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151516059 @ustcweizhou Great to see that these are there! @borisroman has some pending patches as well. If we submit some patches towards libvir-l...@redhat.com we can probably

[GitHub] cloudstack pull request: CLOUDSTACK-8677: use wrapper classes for ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-151508583 To add to the PR, it's not only needed for the Call-Home functionality, but we are using a very, very old version of Gson. --- If your project is set up for it, you

Re: [DISCUSS] Move to GitHub

tter to keep the control of the source > code repo. This is the core of your work. > Agree. I love Github and it works great, but make it THE primary source for the source code and go away from ASF? Well, I'm not sure. True, Git is distributed and that's cool, but I think we should make sure

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151094003 @ustcweizhou It's just a matter of sending patches to RedHat and they will accept it. You can also request a new release of the bindings when you need

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975042 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String mapRbdDevice

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975005 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java --- @@ -0,0 +1,121

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975057 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String mapRbdDevice

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151160292 @ustcweizhou I want a stable master branch which works all the time. Executing binaries is not reliable as we can't do proper exception handling. Also, virsh

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151153457 @ustcweizhou I understand the reasoning and that you want this feature in 4.7, but there is no guarantee it will be fixed afterwards. Once the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8992 Allow 32 disks to be atta...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/980#issuecomment-151190538 LGTM Should be no problem for KVM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Hyper-V clock on KVM node - CLOUDSTACK-8978

uot;rtc", "catchup", null); > > > Let me know what you all think about this change. > Is there a better place / way to implement this? > That would indeed be the place to fix this. It's currently rather hardcoded, but that would be the place to go. Wido > &

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150553318 Agreed with @remibergsma, but the code-wise this is a LGTM. One PR which includes #812 as well would be nice. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-149531398 So, this PR is hard to test. For now I've verified that it compiles on my Ubuntu desktop with Java 8 and all the Unit Tests succeed, so that's good. Asking

[GitHub] cloudstack pull request: Add agent name in received response

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/936#issuecomment-149136968 With @DaanHoogland code-wise is LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-149138303 Code-wise it looks good, but is it possible that you add a unit test? --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [DISCUSS] Log shipping from system vms

ngs. In our case we are using Logstash with the Log4j input [0] on our KVM Agents, but this would also be handy on the SSVMs. Wido [0]: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-log4j.html

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-148661785 @remibergsma This PR is marked as closed, but it was actually reverted. Although it's not a bugfix, it is a fix for the Unit Tests on Windows. Do we want

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/926#discussion_r41961743 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -310,8 +326,17 @@ private void init(Map<String, String> c

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-147991655 Based on the code this seems good to me. I haven't been able to verify it though. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/926#discussion_r41961770 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -310,8 +326,17 @@ private void init(Map<String, String> c

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/926#discussion_r41961830 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -700,6 +734,121 @@ public void doInTransactionWithoutResult(TransactionStatus status

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-147962383 @ustcweizhou I understand the reasoning behind the 300 second minimal interval, but isn't that up to the admin? If he/she wants to set it to 10 seconds on their cloud

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r41998154 --- Diff: pom.xml --- @@ -73,7 +73,7 @@ 1.9.2 1.0.0-build217 2.6.9 -1.7.2 +[2.4,) --- End diff -- Our

[GitHub] cloudstack pull request: CLOUDSTACK-8929

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/904#issuecomment-144700407 @wilderrodrigues Aha, yes. Didn't think of that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-8921

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/899#discussion_r40903392 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -544,6 +546,9 @@ public Answer

[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/889#issuecomment-144712407 @wilderrodrigues A proper integration test for Ceph is still on my whishlist, but to do that we need a running Ceph cluster which we can talk against. I wrote

[GitHub] cloudstack pull request: CLOUDSTACK-8868: use PasswordGenerator.ge...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-144698401 Any progress? I think this PR looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: new colleagues

On 01-10-15 12:07, Daan Hoogland wrote: > Hello fellow stackers, > > This to let you know that I just entered the building of Leaseweb, in order > to be working there for the next couple of years. You know them via Whei > Zou, who will be my close colleague. I had a great time with Schuberg >

[GitHub] cloudstack pull request: CLOUDSTACK-8929

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/904#issuecomment-144697940 Seems like a very trivial fix to me. LGTM based on the code I see --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/889#issuecomment-144322421 @runseb No, not really. All my Unit tests are succeeding on rados-java itself. It should work as expected. But I have no in CloudStack test --- If your project is set

Re: CloudStack Ceph S3 Secondary Storage on KVM

On 09/30/2015 02:44 AM, ilya musayev wrote: > Hi Wido, > > Hope your day is going well. > > Would you know if CloudStack Ceph S3 Secondary Storage on KVM requires > NFS backing or can it be bypassed? > Yes, it still requires a staging NFS secondary store. Wido > Thanks > ilya >

[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/889 CLOUDSTACK-8879: Depend in rados-java 0.2.0 This should fix the CloudStack Agent from crashing when it has to handle more then 16 RBD snapshots on one Volume. You can merge this pull request

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143148262 Seems good to me, in Basic Networking it's not always required. I see that Travis CI timed out, any reason for that? Based on the code a LGTM from me

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-143175301 @remibergsma Oops! I missed that e-mail while working on it this morning. I'll stay off master :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/884 Use java.io.tmpdir instead of hardcoded /tmp Small fix to have the tests also work on other platforms You can merge this pull request into a Git repository by running: $ git pull https

Re: Building cloudstack failing on windows

ail(Assert.java:88) > at > com.cloud.storage.template.LocalTemplateDownloaderTest.localTemplateDownloaderTest(LocalTemplateDownloaderTest.java:37) > Hmm, yes, that seems to be a hardcoded path to /tmp. new LocalTemplateDownloader(null, url, "/tmp", TemplateDownloader.DEFAULT_MAX_TEMPLATE_SIZE_IN_BYTES, null); I just sent a PR: https://github

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/867#discussion_r40195834 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py --- @@ -116,6 +116,7 @@ def has_chain(self, table, chain): def has_rule

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/864#discussion_r40195974 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-142581607 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r40195709 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List volumes, StoragePool

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/878#issuecomment-142604837 Seems good to me. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-142722939 @remibergsma, my LGTM was based on the code. I was not able to fully test it. I checked the diff and it was very small --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8883: Resolved c...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/863#discussion_r40059225 --- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java --- @@ -88,6 +88,7 @@ public void start() throws NioConnectionException

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/835#issuecomment-141004854 I agree with @DaanHoogland That should be unit tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-141004554 @karuturi I think that 8 is a good thing, that brings in much more combinations. Maybe even 10? And I agree with @bhaisaab, no more global settings

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

d. I pushed a new version of rados-java and it's making it's way to Maven central now. When that is done I can push a PR for CloudStack which we might get backported to 4.5.3 Wido

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140675073 @remibergsma @bhaisaab Could you take a look? It's almost similar to the Agent systemd profile :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140676140 @bhaisaab Tnx! I tested it on a CentOS 7 system: ``` [root@vm-d818122e-51ca-479f-9618-051b4eed7c10 system]# systemctl status cloudstack-usage

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/831#issuecomment-140669424 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140746033 @remibergsma Thank you for testing. Stupid mistake indeed. That should be fixed now. I checked on a CentOS 7 machine: ``` + exit 0 RPM Build

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140315801 @borisroman Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140305692 @remibergsma Yes, stupid. Fixed that. Pushed a new commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140303120 @bhaisaab Could you take a quick peek? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140307070 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140306807 @DaanHoogland Pushed a fix for that log line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140332659 Pending travis LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 15-09-15 13:56, Dmytro Shevchenko wrote: > Hello Wido, I saw you updated this code again. Maybe you know, what > procedure for rebuilding this library in Apache maven repository? > Because here http://repo.maven.apache.org/maven2/com/ceph/rados/ still > present only old 0.1.4 vers

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/820 CLOUDSTACK-8840: Systemd service for the Usage Server There already was a uncompleted systemd service file for the Usage Server. This new one replaces sysvinit and the old systemd

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/821 CLOUDSTACK-8645: Improve logging of RBD functionality in KVM A simple commit which changes a couple of log lines. You can merge this pull request into a Git repository by running: $ git pull

Re: RPM Build from Source Fails for CentOS 7.x

On 14-09-15 08:35, Keerthiraja SJ wrote: > Hi All, > > After I follow the doc to build rpm from source there seems to be some > basic issue. > > First the source is looking for the tomcat6 and @ the same time inside the > source I could see only >

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39370166 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java --- @@ -124,6 +132,22

Re: Repo CS 4.5 for CentOS 7.x Missing

I'm however a Ubuntu guy, so I don't know that much about CentOS and testing :) Wido > Regards, > Remi > > > > > On 13/09/15 09:25, "Keerthiraja SJ" <sjkeer...@gmail.com> wrote: > >> When will the 7.x rpm's will get uploaded. >

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/813 CLOUDSTACK-8625: Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using

Re: Repo CS 4.5 for CentOS 7.x Missing

On 09/13/2015 01:28 PM, Remi Bergsma wrote: > Hi Wido, > > PR 731's patch does not apply cleanly on 4.5 due to a conflict in > LibvirtComputingResource.java. It doesn't look too complicated (just one > conflict), but I'd rather have one of the Java gurus look at this. I just

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/814 CLOUDSTACK-8443: Support CentOS 7 for 4.5 This is based on two PRs: - 731 - 757 This commit is based on the 4.5 branch for a future 4.5 release. You can merge this pull request

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-139915515 @remibergsma @maneesha-p Indeed. We have the information, so why not KVM? That would cover allmost all cases. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/814#issuecomment-139913862 @bhaisaab Could you look into this? If this gets a LGTM we might want to spin out 4.5.3 shortly with proper CentOS 7 support. A short e-mail to the dev@ list

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139914467 Looking at the if-statement I give it a LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Cloudstack 8816 entityuuid missing in som...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/782#issuecomment-139915412 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Systemd support for CloudStack 4.6

(14.04) only has partial systemd support. It releases use from JSVC since we don't have to daemonize. I think it's a good step forward for the packaging and usage of CloudStack. Wido

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139913812 @remibergsma I did and made another small change. I don't have a very good CentOS dev setup here, so I wasn't able to test it very thorough. I think

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-139915266 This one was merged, but it wasn't closed since something went wrong with the commit to master. @remibergsma, help? Any idea on how to close this PR

Re: Repo CS 4.5 for CentOS 7.x Missing

I don't see a Jenkins job for CentOs 7. Do we even have one? > Op 12 sep. 2015 om 19:29 heeft Keerthiraja SJ het > volgende geschreven: > > Hi All, > > I could see there is no packages under the directory. > > http://cloudstack.apt-get.eu/rhel/7/4.5/ > > During the

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 09/11/2015 05:08 PM, Andrija Panic wrote: > THx a lot Wido !!! - we will patch this - For my understanding - is this > "temorary"solution - since it raises limit to 256 snaps ? Or am I wrong ? I > mean, since we dont stil have proper snapshots removal etc, so after

Re: No more direct commits to master please!

On 09/12/2015 02:29 PM, Miguel Ferreira wrote: > Hi Wido, > > I’ve been investigating what could have gone wrong with commit > "CLOUDSTACK-8799 fixed for vpc networks.” > (b66dcda49f370e6fc91ebff889a694f17826ca44). > This commit was directly pushed to master, tha

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 10-09-15 23:15, Andrija Panic wrote: > Wido, > > could you folow maybe what my colegue Dmytro just sent ? > Yes, seems logical. > Its not only matter of question fixing rados-java (16 snaps limit) - it > seems that for any RBD exception, ACS will freak out... >

Re: Repo still pointing 4.5.1

On 11-09-15 08:20, Keerthiraja SJ wrote: > Really need someone to do createrepo because the repodata seems to be very > old. > > repodata/ <http://cloudstack.apt-get.eu/rhel/6/4.5/repodata/>2015-05-07 > 16:04 > > Kindly do the need full as soon as possible. > T

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139493789 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39248790 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,25 @@ def get_control_if(self): return ip

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 11-09-15 10:19, Wido den Hollander wrote: > > > On 10-09-15 23:15, Andrija Panic wrote: >> Wido, >> >> could you folow maybe what my colegue Dmytro just sent ? >> > > Yes, seems logical. > >> Its not only matter of question fixing rados-j

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/799#issuecomment-139538952 LGTM. With @bhaisaab though. Please fix Centos 7 as well. Btw, we should really use systemd :) --- If your project is set up for it, you can reply

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 11-09-15 14:43, Dmytro Shevchenko wrote: > Thanks a lot Wido! Any chance to find out why management server decided > that it lost connection to agent after that exceptions? It's not so > critical as this bug with 16 snapshots, but during last week we catch > situation when

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139538657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: No more direct commits to master please!

On 11-09-15 16:26, Remi Bergsma wrote: > Hi all, > > What happened to master? I see a lot of direct commits. I thought we agreed > to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. > Errr, I used that script? This is what my Bash history shows

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 10-09-15 12:17, Andrija Panic wrote: > We are testing some [dirty?] patch on our dev system and we shall soon > share it for review. > > Basically, we are using external python script that is invoked in some part > of code execution to delete needed CEPH snapshots and then after that >

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 10-09-15 14:07, Andrija Panic wrote: > Wido, > > part of code where you want to delete some volume, checks if volume is type > RBD - and then tries to list snapshots, delete snapshtos, and finally > remove image. Here first step- Listing snapshtos- fails, if there are

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/795#discussion_r39164669 --- Diff: utils/src/main/java/com/cloud/utils/storage/QCOW2Utils.java --- @@ -0,0 +1,60 @@ +// +// Licensed to the Apache Software Foundation (ASF

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 10-09-15 14:21, Andrija Panic wrote: > Thx Wido, > > I will have my colegue Igor and Dmytro join with details on this. > Great! > I agree we need fix upstream, that is the main purpose from our side! > I love to see a pull request for rados-java :) 0.1.5

Re: Cloudstack session storage in Redis or Memcache databases

On 10-09-15 16:34, Artjoms Petrovs wrote: > Hello! > > Once again I am up to think about some crazy ideas. > > Is it possible to store the Cloudstack session in a shared Memcached or > Redis database? This way I would like to share the session with a PHP > system, located on the same server. >

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139247851 Still looks good to me. pom.xml should be there --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39176487 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -105,8 +121,17 @@ def process(self): ip = CsIP(dev

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39176449 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,25 @@ def get_control_if(self): return ip

[GitHub] cloudstack pull request: CLOUDSTACK 8819: Return correct template ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/789#issuecomment-138829516 We don't need an external script for this. The QemuImg tools we already have in place can do this for you. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39018553 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,17 @@ def get_control_if(self): return ip

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-138855244 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138476262 @vincentbernat Agreed, if we want a persistent file we should fix it in the packaging and not in the Python code. Code should never create files in a dynamic

[GitHub] cloudstack pull request: debian: Updated dependencies for Packages

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/783#issuecomment-138465225 @resmo Fair enough. These changes are just some small fixes. A new PR with those fixes is fine with me, but I think we can merge this one? --- If your project is set

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138465073 We have to LGTMs. Are we merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    5   6   7   8   9   10   11   12   13   14   >