Re: [01/50] git commit: updated refs/heads/master to 1290e10

2014-09-24 Thread Leo Simons
Hey hey, On Sep 23, 2014, at 11:50 PM, David Nalley da...@gnsa.us wrote: On Tue, Sep 23, 2014 at 4:44 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi David, On 23-Sep-2014, at 8:31 pm, David Nalley da...@gnsa.us wrote: Where was the merge request for this huge merge to master? (it was

Re: [01/50] git commit: updated refs/heads/master to 1290e10

2014-09-23 Thread Hugo Trippaers
Hey David, This is one of the requests that came in using the “new github pull request thing. The big advantage is that we leverage the nice things from github. Part of doing it that way means we keep the history of the original developer intact. With review board we typically get one smashed

Re: [01/50] git commit: updated refs/heads/master to 1290e10

2014-09-23 Thread Rohit Yadav
Hi David, On 23-Sep-2014, at 8:31 pm, David Nalley da...@gnsa.us wrote: Where was the merge request for this huge merge to master? (it was at 50 commit emails, when it stopped sending, ) We have passed feature freeze for 4.5.0, so I am confused as why this was merged. Is there a reason not to

Re: [01/50] git commit: updated refs/heads/master to 1290e10

2014-09-23 Thread David Nalley
On Tue, Sep 23, 2014 at 4:44 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi David, On 23-Sep-2014, at 8:31 pm, David Nalley da...@gnsa.us wrote: Where was the merge request for this huge merge to master? (it was at 50 commit emails, when it stopped sending, ) We have passed feature

Re: [01/50] git commit: updated refs/heads/master to 1290e10

2014-09-23 Thread Rohit Yadav
Hi David, On 23-Sep-2014, at 11:50 pm, David Nalley da...@gnsa.us wrote: Yes, GH PR is exactly like the Review Board emails in this particular aspect. My question is why is this merged into master rather than a feature branch, and why no [MERGE] email as per: