Re: [DISCUSS] coding convention for method - and class length

2013-07-20 Thread Daan Hoogland
...@citrix.comwrote: -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: 18 July 2013 9:43 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] coding convention for method - and class length On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: I'm

Re: [DISCUSS] coding convention for method - and class length

2013-07-19 Thread John Burwell
:43 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] coding convention for method - and class length On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: I'm not sure how I feel about an arbitrary number of lines per method (although 200 is obviously quite high and I would

Re: [DISCUSS] coding convention for method - and class length

2013-07-18 Thread Mike Tutkowski
@cloudstack.apache.org Subject: Re: [DISCUSS] coding convention for method - and class length +1 for the maximum length per line I also agree with Wido that around 120 characters will be more fit current needs. Regards Isaac -- *Mike Tutkowski* *Senior CloudStack

Re: [DISCUSS] coding convention for method - and class length

2013-07-18 Thread Chip Childers
] coding convention for method - and class length +1 for the maximum length per line I also agree with Wido that around 120 characters will be more fit current needs. Regards Isaac -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e

Re: [DISCUSS] coding convention for method - and class length

2013-07-18 Thread Mike Tutkowski
...@sungard.com] Sent: 18 July 2013 9:43 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] coding convention for method - and class length On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: I'm not sure how I feel about an arbitrary number of lines per method

[DISCUSS] coding convention for method - and class length

2013-07-16 Thread Daan Hoogland
LS, I am looking at a method 200 lines long. I've seen more of those. I would propose a maximum length of 80 lines per method and A maximum of 10 methods per class, not including getters and setters of course. I think this would help with the readability of the source base and thus the growth

RE: [DISCUSS] coding convention for method - and class length

2013-07-16 Thread Donal Lafferty
What is the method? DL -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: 16 July 2013 10:00 AM To: dev@cloudstack.apache.org Subject: [DISCUSS] coding convention for method - and class length LS, I am looking at a method 200 lines long. I've

Re: [DISCUSS] coding convention for method - and class length

2013-07-16 Thread Wido den Hollander
Hi, On 07/16/2013 10:59 AM, Daan Hoogland wrote: LS, I am looking at a method 200 lines long. I've seen more of those. Yes, that is pretty long. I would propose a maximum length of 80 lines per method and There was a recent discussion about this, but I wasn't able to find it that

Re: [DISCUSS] coding convention for method - and class length

2013-07-16 Thread Isaac Chiang
+1 for the maximum length per line I also agree with Wido that around 120 characters will be more fit current needs. Regards Isaac

RE: [DISCUSS] coding convention for method - and class length

2013-07-16 Thread Donal Lafferty
: [DISCUSS] coding convention for method - and class length +1 for the maximum length per line I also agree with Wido that around 120 characters will be more fit current needs. Regards Isaac

Re: [DISCUSS] coding convention for method - and class length

2013-07-16 Thread Daan Hoogland
thread covering max characters per line? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: 16 July 2013 11:12 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] coding convention for method - and class length +1 for the maximum length per line