Pearl1594 commented on a change in pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r783633640
##########
File path: cloudstack/VPCService.go
##########
@@ -2855,7 +2855,7 @@ type VPC struct {
JobID string `json:"jobid"`
Jobstatus int `json:"jobstatus"`
Name string `json:"name"`
- Network []string `json:"network"`
+ Network []Network `json:"network"`
Review comment:
@tetra12 - the change LGTM, but I believe this change would also
probably be required at `CreateVPCResponse`
(https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L721)
and `UpdateVPCResponse`
(https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L3172).
You could probably add a check in the function named `mapType`
(https://github.com/apache/cloudstack-go/blob/main/generate/generate.go#L1849)
- to handle this change via the code generator. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
