rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-653728710
Named slots could have been used, but I'll merge for now
This is an automated message from the Apache Gi
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-653725726
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to t
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-652302553
@utchoang you can create a new component and in that import and use
autogenview instead of the other way around, then in your new component you can
pass templates etc in
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-652293929
@utchoang I still see no usage of slots, are you working on doing a separate
component implementation and use slots instead of extending AutogenView?
-
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-652285606
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to t
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-652277539
@utchoang can you fix the conflicts? Thanks.
This is an automated message from the Apache Git Service.
T
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-651543188
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-650991789
Thanks @utchoang
@blueorangutan package
This is an automated message from the Apache Git Service.
To
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-650256208
@utchoang thanks much better LGTM, I've left one additional remark on how
you can refactor the code by use of slots (or named-slots) see -
https://vuejs.org/v2/guide/com
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-649492461
Thanks @utchoang I'll review tomorrow
@blueorangutan package
This is an automated message from the Ap
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648682312
@utchoang headsup looks like there is a conflict as well
This is an automated message from the Apache Gi
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648613412
@utchoang please avoid making changes to core widgets including ListView,
ResourceView etc; as/when necessary put slots in them and create components
that embed them and
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648559207
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the mess
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-647926274
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-647854068
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the mess
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-647575429
@utchoang can you fix the confilct please, also check all your existing PRs
for conflicts; thanks
This
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-645764397
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to t
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-645291274
@utchoang there are still issues:
- Translation issue in form, for example the add credit form
- The tariff is no longer editable; if you want you can create a new v
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-645259236
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-645163415
@utchoang LGTM but can you address the following:
- Fix translation/key label usage across views (see locales/en.json to pick
the keys, all lowercase)
- Add ability
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644576089
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
21 matches
Mail list logo