Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
LGTM, merging based on code reviews and tests, ignoring known intermittent
errors in vpc/rvr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Based on test results LGTM. /cc @jburwell
Can we have one more LGTM on this, @serg38 @jburwell ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhytd @jburwell @karuturi test_nested_virtualization_vmware
Success 305.03
The other tests fail due to environmental issues e.g. below. I think it is
ready for merging
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Trillian test result (tid-348)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32441 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Packaging result: âcentos6 âcentos7 âdebian. JID-165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@serg38 these errors look similar to those we have seen on other PRs. We
are currently investigating them with the assumption that they are most likely
environmental. Once we have them
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd Looks like blueorangutain vmware side has issues on
hypervisor. Can you take a look and then re-kick the tests? Some errors were
due to that.
530, errortext : u'Unable
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Trillian test result (tid-343)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36589 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@blueorangutan test centos7 vmware-55u3 test_nested_virtualization.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@karuturi @jburwell As per @rhtyd we can run additional tests with
blueorangutan . Can we execute them and merge this PR since it passes the
standard test suite just fine?
---
If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @nvazquez we have the capability to run any additional tests
using blueorangutan now, can you suggest what tests we should run. The syntax
would be following: (to be commented)
test
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
That's great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez @rhtyd is working on an enhancement to blueoragnutan that will
allow to specify component tests to run in addition to the smoke tests. When
that is ready, we will re-execute the
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Trillian test result (tid-240)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26546 seconds
Marvin logs:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks @jburwell! Rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
The debian pkg failed due to an intermittent unit test failure (ignorable,
env issue).
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Packaging result: âcentos6 âcentos7 âdebian. JID-120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez I would like to get this PR merged for 4.10.0.0. Could you
please rebase this PR to pull the latest Marvin enhancements/fixes? Once that
is done, I will kick off a regression test
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks for testing @nvazquez I think since @NuxRo built new vmware
templates, we can consume macchinina/vmware:
http://dl.openvm.eu/cloudstack/macchinina/x86_64/testing
The TinyCore
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Hi @rhtyd, we ran `test_internal_lb.py` and `test_vpc_vpn.py` using
`tl-vmware.ova` template and got this results:
`test_vpc_vpn` is ok:
```
Test Site 2 Site VPN Across
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd sure, will do and post results
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez you're welcome. If you've some bandwidth, can you run your test
against this template which will also help validate the new vmware test
appliance: https://github.com/rhtyd/tinylinux
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd I included new marvin test for nested virtualization,
thanks @rhtyd for your idea!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell This sounds like a good idea. In this PR all abstraction work is
done so the things to do would be to implement support in respective hypervisor
resources as well as strip "vmware."
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd good idea to check the CPU flags. There is a part of me that would
like to see a VM actually spin up inside a VM, but there are also many things
that could go wrong that are not
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Great tip, @rhtyd This way it is actually very straightforward. We should
be able to come up with integration test for this PR shortly
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell nested VM is something tricky to test, we can support this as a
subtle feature but not a generally supported one. In our test/trillian
environment, we're already running nested
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@serg38 no problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd Thanks in advance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhytd can you help @serg38 craft a template with KVM installed and the
virsh commands to create a nested VM?
---
If your project is set up for it, you can reply to this email and have your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell The only BUILTIN Centos template for Vmware is 5.3 that doesn't
have KVM support to my knowledge. Are you proposing to introduce another
BUILTIN template so that it is available for
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@serg38 the goal is not only verify that functionality works now, but in
the future to protect against regressions. My thinking is that we could deploy
a CentOS VM, install KVM, and verify
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell Creating Marvin test for this PR will be a huge undertaking. It
would require building and configuring a hypervisor in a deployed VM and then
creating VM in VM. Considering storage,
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@serg38 @nvazquez I apologize that I am late to the review. I would like
to see a Marvin test added that verifies that nested virtualization works when
the global setting is enabled (i.e.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner @jburwell @karuturi Looks like this PR has everything to
get merged. Can we do it by the release freeze?
---
If your project is set up for it, you can reply to this email and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Solved, thanks @rafaelweingartner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@serg38 with your explanations, I am ok with the current state of this PR.
No further changes are needed.
There is only one problem now. There are some merge conflicts that have to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd @jburwell @rafaelweingartner @koushik-das Can we agree if this PR is
OK as it is ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhtyd @jburwell @rafaelweingartner @koushik-das The rationale to have
vmware.nested.virtualization.perVM was that advanced vm_details and template
details are user controlled. With
@rhtyd The rationale to have vmware.nested.virtualization.perVM was that
advanced vm_details and template details are user controlled. With
https://issues.apache.org/jira/browse/CLOUDSTACK-9457
‘Allow retrieval and modification of VM and template details via API and UI’
users will be able to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez @serg38 how about we remove vmware.nested.virtualization.perVM
and instead if the user vm detail exists and is true, it overrides the global
setting?
---
If your project is set up for
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd @koushik-das Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
I am the one thas has to thank you @nvazquez, great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks @rafaelweingartner
This is the link to JIRA ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9457
---
If your project is set up for it, you can reply to this email and
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Great. You have done a lot of work already; but, just to make sure things
do not get lost. What about opening a Jira ticket to expose that customization
through the ACS API?
---
If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner That's correct. At this point advanced VM details and
advanced template details have no UI exposure. At some point we can bring in PR
to show this in UI and allow API based
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Great.I am ok with the code. I give my LGTM here.
I have one extra question, though. How do you intend to change that
parameter (NESTED_VIRTUALIZATION_FLAG) to tell which VM
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
I had removed it, I saw your comment in that file and I included it in last
refactor, I forgot to mention it in my last comment :)
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
There is still one point I would like to highlight. The method
VmwareResource.configNestedHVSupport does not need to be static.
---
If your project is set up for it, you can reply to
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Sure, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez, it seems that there was a problem with the Jenkins Job. Can you
force another build?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks @rafaelweingartner, I agree with you, I refactored it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
I understand the need to create a test. And I agree that it deserves a
test. What I meant was the following.
IMHO, you could simply remove the final keyword of the variable
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner I agree it wasn't the best solution but I meant to
include it for the sake of testing `configureNestedVirtualization` method.
Which approach can I take to test this method,
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez the code is great now.
I have just a concern about that hack to change the field declared as final.
In my opinion, the final there does not bring benefits. So, I
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner thanks a lot for your help as always!
I refactored based on your comments. I really liked your review, especially
your refactor on
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez long time we donât do this ;)
First of all, your PR explanation is great. The code is very well
documented and explained and with test cases (very good ones).
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Oh that's sad, no problem, thanks anyways @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@nvazquez unfortunately I no longer am involved in cloud computing. I'd
really need a deep dive to give value, sorry.
---
If your project is set up for it, you can reply to this email
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Hi @DaanHoogland @remibergsma @ustcweizhou,
I rebased master branch for this pull request as it's been opened for a
while, could it be reviewed please?
---
If your project is
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1542
### ACS CI BVT Run
**Sumarry:**
Build Number 198
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Could this be reviewed for VMware please? Then I can work on extending it
to other HVs
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
71 matches
Mail list logo
