[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-19 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @mlsorensen We can indeed do that, but the good thing for now is that the RNG is disabled by default. You also need a very ancient libvirt for it not to support RNG and that will get less

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-19 Thread mlsorensen
Github user mlsorensen commented on the issue: https://github.com/apache/cloudstack/pull/1572 I realize I'm late to the party on this, but I'd like to suggest that we change from the agent.properties "vm.rng.enable=true" to simply using the libvirt version detection like we do for oth

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 @rhtyd my point is that, even if its run on KVM, this functionality wont be covered with existing tests. I agree to your point. It was just that I had xen tests available and another run on KVM

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi I think it beats the purpose of smoke tests if we don't run them against the hypervisor(s) the PR/change is most likely related to. Without valid test results it is hard to validate a ch

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 1. the current set of integration tests doesnt test the new functionality added in this PR. Its merely a check to see nothing else is broken. 2. when did we freeze? I skimmed through the mai

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi am I missing the test results on this PR for the enhancements? All I see are tests against XenServer which have no bearing on this change. Why was this PR merged without a full run

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 code LGTM 👍 from @ustcweizhou and there are test runs I am merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-09-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Can I get a review on this one so it can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-07-12 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 No LGTM on this one yet. Are we good @ustcweizhou and @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-20 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1572 ### ACS CI BVT Run **Sumarry:** Build Number 203 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _Link to logs Folder (search b

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-08 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Did you get a chance to take a look @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1572 Thanks @wido will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Ok, thanks @ustcweizhou . Could you take a technical look and see if you LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido thanks. it sound fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @remibergsma: Could you check again? You can now set the rate with period and bytes to prevent exhaustion. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @ustcweizhou Using 'vm.rng.enable=true' you can enable or disable the RNG. This controls if the XML is generated or not. This is set to false by default, so it will work on Ubuntu 12.04 wit

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido , thanks for your reply. As I know, there are still many people using Ubuntu 12.04. Especially for one starting using CloudStack/Ubuntu 2-3 years ago ( before Ubuntu 14.04 release), it

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Yes, valid point @remibergsma , see: https://libvirt.org/formatdomain.html#elementsRng I'll add support so that you can configure: `` `` That way you can prevent

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-04 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido Thanks for the feature, I like it! Although I'm a bit worried that many VMs could potentially exhaust the hypervisor's `/dev/random`? How do you handle that? --- If your project is set up f