Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
LGTM, this is only a comment change. Changes have been verified, so I'll
proceed with merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@jburwell we can merge this, since it's a doc change no tests are needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
LGTM @jburwell I checked the changes against the values defined in
`AlertService` and they check out perfectly.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd have you had a chance to analyze? I would like to include this
change in 4.9.1.0 and 4.10.0.0 for which we are planning to cut RCs on 25 Sept
2016.
---
If your project is set up for i
Github user dcarbone commented on the issue:
https://github.com/apache/cloudstack/pull/1591
squashed, pointing at 4.9, and commit amended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd @dcarbone given that we are trying to get a 4.8 RC cut ASAP (we are
week late already), I think it is best to push this PR to 4.9.2.0. Would you
mind re-pointing it to the 4.9 branch?
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@dcarbone can you squash your commits and rebase against latest, thanks.
Please also amend git commit message to include the JIRA ID.
@jburwell I did not start my analysis, I'll do that once we
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@dcarbone thanks for creating a JIRA ticket. Could you please prepend the
headline of your commit message with the ticket ID (i.e. [CLOUDSTACK-9468])?
Additionally, the Travis build is failin
Github user dcarbone commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@jburwell: JIRA ticket created:
https://issues.apache.org/jira/browse/CLOUDSTACK-9468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
I would like to get this PR merged as part of the 4.8.2.0 release, but we
don't have much time to get it completed.
@dcarbone could you please create a JIRA ticket explaining the
bug/e
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
We'll need to check this against the consumers of the response, based on
present alert codes we may need to update it. We'll also need to see when the
alert code diverged, why some of the alert co
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1591
Can maybe @rhtyd comment on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
12 matches
Mail list logo
