Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Alright, given the reviews and that all changes have been incorporated with
exhaustive testing with Ubuntu and CentOS I'll proceed with merging this
without blocking 4.9.1.0 RC much further.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido @vincentbernat and others -- any objections, this is good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@vincentbernat @wido thank you for your suggestion and review, I've pushed
the final version from my end. Packages works on both CentOS7 and Ubuntu
12.04/14.04/16.04.
---
If your project is set
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Update: postinstall code has been removed now @wido @vincentbernat
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Packaging tests confirmed, PR is OK. Debian packages tested on Ubuntu
12.04/14.04/16.04, rpms tests on CentOS 7.2. Both usage, agent came up on
installation.
---
If your project is set up for
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido @vincentbernat I could not get rid of the postinst step as shell is
not executed when I move the code in the EnvironmentFile itself. I've reduced
its impact to only run when the default
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Thanks @wido I'll see if I can fix the issue without including the changes
in postinst files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
LGTM for me right now.
One side note, I hate changes being made in postinst files. But I wouldn't
know a different route though.
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido @vincentbernat I've incorporate all the changes now, including
refactoring of systemd file and now we've both centos and ubuntu/debian
packaging consuming from the the same service/default
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Thanks @vincentbernat I'll update the dependencies, and in the
post-installation step we can modify the default JAVA_HOME path of the host in
the default/{cloudstack-usage, cloudstack-agent}
Github user vincentbernat commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Otherwise, I think the change to be compatible with 12.04 is OK (no Upstart
script should ever be provided in this case).
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido actually on a fresh system it would first attempt to find and install
openjdk8, on existing ones if openjdk7 is installed then it won't force
openjdk8 by default. Thanks.
---
If your
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@rhtyd Seems good, but it would still not force the install of Java 8 on
Ubuntu 16.04
However, I don't think that's a blocker.
LGTM for me
---
If your project is set up for it,
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@vincentbernat I made some changes, built packages and was able to install
and run agent and usage server on both Ubuntu 12.04, 14.04 using the same
packages.
@wido @vincentbernat can you
Github user vincentbernat commented on the issue:
https://github.com/apache/cloudstack/pull/1647
it is not possible to have systemd support and build on 12.04 at the same
time. dh-systemd doesn't exist on 12.04 and its actions are quite important. If
you remove it and just install
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Thanks @wido that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@rhtyd When this one merges and is merged forward I will send a PR for
master to remove 12.04 support.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@rhtyd Why another PR for against master? I thought we were merging forward?
This stuff is really starting to confuse me.
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido based on the ML discussion, I've removed the specific change that
removed 12.04 support. Can you send another PR for master for removing support
for 12.04.
---
If your project is set up
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido While I understand that it is quite old and presents maintenance
challenges, it remains supported until [April
2017](https://wiki.ubuntu.com/Releases). Therefore, it would be reasonable
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido with this change will we have to host two versions of deb repository
-- one built on ubuntu without systemd (such as 14.04) and one built on ubuntu
with systemd (16.04+)?
---
If your
#1647: [lts] CLOUDSTACK-9462: Systemd
support for Ubuntu 16...
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
I did the test myself, but since it's my code I can't LGTM this.
---
If your project is set up for it, you can reply to this email
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
I did the test myself, but since it's my code I can't LGTM this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@wido given it's a pure packaging fix, and as per RMs we've enough LGTMs
but we lack a test LGTM -- I can help merge this after some tests wrt usage and
kvm agent (on ubuntu 16.04) over the
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1647
@rhtyd No, it doesn't do the management server.
Let's just merge this PR and make a new one for that. I don't want to delay
merging this any longer.
Thanks @vincentbernat for the
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1647
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1647
Job ID-92
---
If your project is set up for it, you can reply to this email
Github user vincentbernat commented on the issue:
https://github.com/apache/cloudstack/pull/1647
LGTM for the Ubuntu part. You could share `/etc/sysconfig/*` and
`/etc/default/*` files between RHEL/Ubuntu (same files, just installed at
different locations). Same for the service
27 matches
Mail list logo
