Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1656
Thanks @serg38 @abhinandanprateek for the review. With enough lgtms and
(manual) test result against a large pre-4.1 db, I'll proceed with merging.
---
If your project is set up for it, you can
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1656
LGTM on code review, the fix is taking care of the removed column, thereby
maintaining the constraints.
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1656
There are no upgrade tests to confirm the fix as all the changes are in an
older 4.1.0->4.2.0 upgrade path. After this fix, here are manual test results
to show that db upgrade finished cleanly
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1656
@jburwell fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1656
@rhtyd would it be possible to re-target this PR to the 4.8 branch? It
seems like a good fix to include in 4.8.2.0 as well as 4.9.1.0.
---
If your project is set up for it, you can reply to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1656
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1656
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1656
Job ID-99
---
If your project is set up for it, you can reply to this email
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1656
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1656
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
