Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi Please take care of the code change in the following
PR as well as i am closing
https://github.com/apache/cloudstack/pull/1721
The change is as follows
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
Thanks for sharing @sateesh-chodapuneedi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1664
Hi @rhtyd, Working on this PR this week, should be able to update and push
soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi @yvsubhash ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi @yvsubhash ping, guys can you rebase and fix conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi can you fix the conflicts and rebase against latest
master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi can you resolve conflicts and rebase against latest
master, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@jburwell Yes, currently working on breaking the methods into multiple
smaller units, and adding unit tests. Along with these adding the marvin tests
from the other PR so that PR
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi have you @nitt10prashant worked out combining the
Marvin tests with this PR? Also, please investigate the Travis CI failures.
Finally, have you had a chance to address
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi please add unit tests to increase code coverage,
break large methods into smaller reviewable methods. Thanks.
---
If your project is set up for it, you can reply to this
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@jburwell I will check with @nitt10prashant on this. Will try to add the
tests in PR #1417 to this PR.
---
If your project is set up for it, you can reply to this email and have
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi @nitt10prashant could you please collapse the test
case and feature PRs? It is very difficult to test the feature when the tests
are in a different branch.
---
If your
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1664
Target this PR to ACS master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
13 matches
Mail list logo
