Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Thanks @milamberspace
Based on the tests and LGTMs, I'll proceed with merging this on 4.9. On
fwd-merging, I've fixed conflicts and renamed a subsequent class to match the
change. Fwd-merged
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1665
LGTM.
Tested on CS 4.9.0 to 4.9.1.0-snapshot installation.
(perhaps just change the comment below inside the SQL file to indicate
4.9.1.0 (missing .0?)
"-- Schema
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Tests performed after fwd-merge, all pass:
- Upgraded from 4.9.1.0
- Clean db deployment
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Tests performed:
- Upgraded from 4.9.0, upgrade path ran (whose sql file names were
changed)
- Clean db deployment
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@rhtyd good catch -- sorry for that oversight. I have redone the PR to
only rename the files and class.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell we'll need that upgrade path class, we have some alter table
changes we want for the 4.9.0->4.9.1.0 upgrade path, see the diff for changes
you've removed.
---
If your project is set
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@rhtyd I have fixed the ``DatabaseUpgradeCheckerTest`` to reflect 4.9.1.0
being a ``NoopUpgrade``. I also removed the unnecessary 4.9.0->4.9.1.0 upgrade
scripts and class.
---
If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell this needs to be reworked now that #1654 is merged. Good to have
the changes but not a blocker for 4.8, 4.9 RCs.
---
If your project is set up for it, you can reply to this email and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
With new db schema/versioning and upgrade changes in #1654 we can merge
this with some additional changes once #1654 is merged and fwd-merged.
---
If your project is set up for it, you can reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell -1
The db upgrade version only considers the major/minor fields such as a.b.c,
the last `.d` is ignored (for that matter any other suffix in the version). Due
to the current
11 matches
Mail list logo
