Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1689
we have two LGTMs and test run. I am merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1689
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1689
@mike-tutkowski excellent -- thanks for adding that configuration bit. I
am LGTM once the Jenkins and Travis complete successfully.
@karuturi @rhtyd are you able to review for a
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1689
@jburwell I just added that to requirements.txt. I also put a link to
solidfire-sdk-python 1.1.0.92 in the description of this PR.
---
If your project is set up for it, you can reply to
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1689
@mike-tutkowski is the SolidFire Python SDK available via pip? If so,
could you please add it to `requirements.txt` in the project root directory?
---
If your project is set up for it, you
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1689
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1689
TestAddRemoveHosts.py:
test_add_remove_host_with_solidfire_plugin_1
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:
test_add_remove_host_with_solidfire_plugin_1 |
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1689
@mike-tutkowski could you please amend the test result details to this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
