Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
LGTM now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou coding convention issue is taken care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
code LGTM
@yvsubhash it would be nice if you can reformat part of the code with java
code conventions.
---
If your project is set up for it, you can reply to this email and have your
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou does it look good to you now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1726
### ACS CI BVT Run
**Sumarry:**
Build Number 456
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7
_Link to logs Folder
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1726
I have tested this and **LGTM** for test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou thats good point. It should be removed after all download
links expire. I will address this case
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@yvsubhash yes, you are right, it is 'download links', not 'volume
snapshots'. I made changes on this long time ago and almost forgot how it works.
so, my question is, should we
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou As I understand, Volume goes to Expunged state when it is
removed from primary and gets removed when it is removed from secondary
storage. line 2211 to 2215 is to handle
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@yvsubhash so, the question is , in what condition the volume is Expunged
but not removed ? if it does not happen, then the change from line 2211 to 2215
is not needed.
however, to be
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou In case of volume snapsnots, volume gets set to removed
irrespective of the presence of snapshots. I have verified the same just now
and I am only removing volume not any of
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@yvsubhash I did not mean we need clean up the snapshots.
in my understanding, if the volume has snapshots left, it is Expunged, but
not marked as Removed
your change just delete
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@rhtyd Can you please merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou Volume snapshots would be left over even in case of normal vm
destroy and that is expected. They can be used if there is a need to restore
the volume at a later point in time.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@yvsubhash can you reply to raised review comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
Packaging result: âcentos6 âcentos7 âdebian. JID-190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1726
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
Trillian test result (tid-179)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24929 seconds
Marvin logs:
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@koushik-das Added the null check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
Packaging result: âcentos6 âcentos7 âdebian. JID-91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1726
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
29 matches
Mail list logo
