[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-08 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1743 Good suggestion @ustcweizhou, done that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-08 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1743 @rhtyd @wido I would suggest one more change: move line 378-380 after line 360. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1743 @ustcweizhou @The-Loeki do we have LGTM from you guys on this? Thanks. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1743 Is this one ready to merge? It fixes a rather nasty bug in the VR which causes big problems when no DHCP offer is received by the Instance(s). --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 Trillian test result (tid-262) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26169 seconds Marvin logs:

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 Trillian test result (tid-254) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27962 seconds Marvin logs:

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1743 Previous Trillian test job failed due to backend issue, I've rekicked them now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1743 @The-Loeki as I remember, that is a bug in dhcp3-client. The issue does exist in Ubuntu 12.04 (guest vm), but fixed in Ubuntu 12.04.3. (I can not find the related link now). Anyway, the

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1743 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1743 Good feedback @ustcweizhou, addressed that. Thanks @The-Loeki for the report, this is indeed a upstream issue somewhere else, but if we can mitigate in the meantime that would be great.

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread The-Loeki
Github user The-Loeki commented on the issue: https://github.com/apache/cloudstack/pull/1743 See https://bugzilla.redhat.com/show_bug.cgi?id=910619 for what's actually going on (and what actually should be going on) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1743 @wido maybe the guy who made the change forgot to add it in fw_vpcrouter. In fw_router, it should be moved out from "if self.get_type() in ["public"]", because the network type is

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1743 Thanks @ustcweizhou for the pointer. It was already fixed in fw_router, but not in fw_vpcrouter there. How does this look? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1743 in 4.9, ALL iptables rules will be saved in /tmp/rules.save I think it is better to add the rules in systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ``` +

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1743 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

2016-11-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1743 LGTM, not sure if this can lead to any side-effects. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If