Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@karuturi @rafaelweingartner thanks! I closed Jira ticket 9379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1767
I have just reviewed the PR. There are only small suggestions I made.
BTW: from the Jira ticket
https://issues.apache.org/jira/browse/CLOUDSTACK-9457, I ended up at
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@karuturi Can we merge this one ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Trillian test result (tid-776)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43663 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Packaging result: âcentos6 âcentos7 âdebian. JID-451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@serg38 sure
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@rhtyd Can you kick off tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Hi @rhtyd @koushik-das @ustcweizhou,
I refactored this PR removing previously created API commands, only adding
an optional parameter (`cleanupdetails`) on `updateVirtualMachine` and
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@nvazquez @koushik-das If we go this route we might want to change update
API to behave consistently. It would make sense to allow overriding any
details.
---
If your project is set up for
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@serg38 @koushik-das sure, I can work on it, the actual way is passing
details as key value pairs on the update methods but I think it would require
to define a way to delete details (for
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das No I don't. I tend to agree with you but obviously the
implementation will be messier since configs are random. @nvazquez Do you think
it can be changes so that modification is
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@serg38 @nvazquez Thanks for the update. As I understand form some of the
detail parameter examples, these are tied to the lifecycle of the entity
(create/destroy or start/stop of the VM).
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das @ustcweizhou Just want to add on the use case. There is
growing need to change template/VM details for after the deployment e.g. to
switch root disk controller or change ratio of
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Hi @koushik-das @ustcweizhou,
For this new methods as they require the entity id (VM or template) I added
a basic validation to check if the entity is found on DB, but I realize that I
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1767
I have the same concerns as @koushik-das .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@nvazquez Can you add use case details that will be addressed by these new
methods? Also what kind of validation will be performed on the inputs and the
state of the entity (VM or
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Packaging result: âcentos6 âcentos7 âdebian. JID-166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
23 matches
Mail list logo
