[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2017-02-20 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1881 ### ACS CI BVT Run **Sumarry:** Build Number 365 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2017-02-14 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1881 configuration cleanup. needs BVT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1881 @sureshanaparti Thanks for the cleanup. LGTM @sateesh-chodapuneedi this is a good question. The changes here remove an attribute of an Enum that is not referenced anywhere. In my

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1881 @karuturi As this PR is about removal of a deprecated configuration setting which is no more referenced any where in the repo, can we merge this without functional tests? Or we

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2016-12-29 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1881 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and