Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
LGTM. @karuturi let's merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
Got it, thanks for the explanation. I saw that, and I was wondering if it
could have been a bug or something else.
LGTM then.
---
If your project is set up for it, you can
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@rafaelweingartner It was because the source string (en) has been chenged
by this PR 1803, so the translations have been deleted by Transifex to invite
the translator to make the new
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@milamberspace @rhtyd do you know why the entry "label.host.alerts" was
removed from some languages?
---
If your project is set up for it, you can reply to this email and have your
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@karuturi Since master (4.10) use now JSON files for the localization files
(and too because on Transifex the localization's resources for each version of
CS are different), so this PR
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@milamberspace Should the merge to master be an empty merge? Meaning is
this only for 4.9??
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@rhtyd missed this one. Thanks for reminding. merging now.
@milamberspace Thanks for keeping the translations updated for every
release :)
---
If your project is set up for it, you can
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@karuturi pure translation changes, we need one more LGTM, otherwise this
is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
LGTM, only text/translation changes. Thanks @milamberspace
Travis test LGTM, trillian smoke tests are not necessary.
---
If your project is set up for it, you can reply to this email and
