Github user ramkatru commented on the issue:
https://github.com/apache/cloudstack/pull/1900
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1900
### ACS CI BVT Run
**Sumarry:**
Build Number 416
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1900
LGTM for code changes.
Thanks @anshul1886 for the path.
@karuturi Seems this PR is ready for merge, as it has 2 LGTMs and latest
test results from @cloudmonger has 0
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1900
### ACS CI BVT Run
**Sumarry:**
Build Number 391
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@karuturi @koushik-das @sateesh-chodapuneedi , I had analysed those
failures and working on how to go about those. Issue here is that there are
marvin tests which are for something which was
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@anshul1886 can you take a look at the travis and jenkins failures?
volume related tests failed on travis
>
>
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1900
### ACS CI BVT Run
**Sumarry:**
Build Number 358
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1900
Rebased with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1900
### ACS CI BVT Run
**Sumarry:**
Build Number 324
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=7
_Link to logs Folder
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@ProjectMoon Yes it will work fine in clustered scenario as ultimate source
of truth is DB.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@anshul1886 I have not delved too deeply into the state machine transition
code, though I understand the basics of how it works. I think `synchronized` +
state transition should be enough
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@ProjectMoon We don't need both the commits. One of the commit is enough.
Correct me if I am missing something. And I think using state method is better
than using lock method.
---
If
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@anshul1886 I am fine with putting both commits on either PR. If you are
unopposed we can just stick it on mine?
---
If your project is set up for it, you can reply to this email and have
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1900
@ProjectMoon @anshul1886 #1898 and #1900 are for the same bug. Can you
please collaborate and put a single PR?
---
If your project is set up for it, you can reply to this email and have your
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1900
I don't have the resources in my lab available to perform tests on this at
this time, but the code itself LGTM.
Thanks for working on this JIRA ticket!
---
If your project is
15 matches
Mail list logo
