[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-14 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1965 @ustcweizhou We are saving the password in the user_vm_details explicitly. We are not checking if ssh key pair is set for this vm or not. I agree that ideally we should sync the

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1965 @bvbharatk Yes, you might know only the vm has sshkey attached will have the password in vm details. If the vm does not have ssh keypair, then the vm password will not saved into

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-12 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1965 @ustcweizhou Hi we are not saving the password to the router. we are saving the password in the VM details. When the VM starts we send the password to the router. Password reset cannot

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-07 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1965 ### ACS CI BVT Run **Sumarry:** Build Number 438 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1965 @bvbharatk I think the new password should be saved to one of the running routers, not all running routers. I disagree with change line 797. --- If your project is set up for it, you

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1965 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-27 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1965 ### ACS CI BVT Run **Sumarry:** Build Number 400 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-26 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1965 ### ACS CI BVT Run **Sumarry:** Build Number 394 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-23 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1965 @ustcweizhou Reformatted the code. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-23 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1965 @bvbharatk can you format the code ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this